Merge pull request urfave#2081 from dearchap/issue_2077

Fix:(issue_2077) Make sure onUsageError is invoked for command when a…

Author: dearchap

args_test.go

@@ -94,7 +94,14 @@ func TestArgumentsSubcommand(t *testing.T) {
 		},
 	}
 
+	numUsageErrors := 0
+	cmd.Commands[0].OnUsageError = func(ctx context.Context, cmd *Command, err error, isSubcommand bool) error {
+		numUsageErrors++
+		return err
+	}
+
 	require.Error(t, errors.New("sufficient count of arg sa not provided, given 0 expected 1"), cmd.Run(context.Background(), []string{"foo", "subcmd", "2006-01-02T15:04:05Z"}))
+	require.Equal(t, 1, numUsageErrors)
 
 	require.NoError(t, cmd.Run(context.Background(), []string{"foo", "subcmd", "2006-01-02T15:04:05Z", "fubar"}))
 	require.Equal(t, time.Date(2006, time.January, 2, 15, 4, 5, 0, time.UTC), tval)

command_run.go

@@ -313,6 +313,10 @@ func (cmd *Command) Run(ctx context.Context, osArgs []string) (deferErr error) {
 			rargs, err = arg.Parse(rargs)
 			if err != nil {
 				tracef("calling with %[1]v (cmd=%[2]q)", err, cmd.Name)
+				if cmd.OnUsageError != nil {
+					err = cmd.OnUsageError(ctx, cmd, err, cmd.parent != nil)
+				}
+				err = cmd.handleExitCoder(ctx, err)
 				return err
 			}
 		}