add golint

Author: c-wind

Makefile

@@ -1,7 +1,7 @@
 all: lint gate master notice store 
 
-LDFLAGS += -X "github.com/dearcode/candy/util.BUILD_TIME=$(shell date +%s)"
-LDFLAGS += -X "github.com/dearcode/candy/util.BUILD_VERSION=$(shell git rev-parse HEAD)"
+LDFLAGS += -X "github.com/dearcode/candy/util.BuildTime=$(shell date)"
+LDFLAGS += -X "github.com/dearcode/candy/util.BuildVersion=$(shell git rev-parse HEAD)"
 
 golint:
 	go get github.com/golang/lint/golint  
@@ -19,6 +19,8 @@ meta:
 lint: golint
 	golint gate/
 	golint store/
+	golint notice/
+	golint util/
 
 clean:
 	@rm -rf bin

notice/server.go

@@ -49,7 +49,7 @@ func (n *Notifer) Subscribe(c context.Context, req *meta.SubscribeRequest) (*met
 	return &meta.SubscribeResponse{}, nil
 }
 
-// Unsubscribe unsubscribe a Notifer.
+// UnSubscribe unsubscribe a Notifer.
 func (n *Notifer) UnSubscribe(_ context.Context, req *meta.UnSubscribeRequest) (*meta.UnSubscribeResponse, error) {
 	n.broker.UnSubscribe(req.ID)
 	return &meta.UnSubscribeResponse{}, nil

util/common.go

@@ -3,47 +3,60 @@ package util
 import (
 	"crypto/md5"
 	"fmt"
-	"strconv"
 	"time"
 )
 
 var (
-	BUILD_TIME    = ""
-	BUILD_VERSION = ""
+	// BuildTime 编译时间.
+	BuildTime = ""
+	// BuildVersion git版本.
+	BuildVersion = ""
 )
 
 const (
-	UserDBPath    = "user"
+	// UserDBPath 用户数据库位置.
+	UserDBPath = "user"
+	// MessageDBPath 消息数据库位置.
 	MessageDBPath = "message"
-	GroupDBPath   = "group"
+	// GroupDBPath 群组数据库位置.
+	GroupDBPath = "group"
 
 	// FileBlockPath 块文件存储位置
 	FileBlockPath = "file_block"
 	// FileDBPath 文件索引存储位置
 	FileDBPath = "file"
 
+	// MessageLogDBPath 消息记录数据库位置.
 	MessageLogDBPath = "message_log"
 
-	UserMessagePrefix     = int64(0)
+	// UserMessagePrefix 用户消息前缀.
+	UserMessagePrefix = int64(0)
+	// UserLastMessagePrefix 用户最后一个消息ID.
 	UserLastMessagePrefix = int64(1)
-	UserGroupPrefix       = int64(2)
-	UserFriendPrefix      = int64(3)
-	UserIDPrefix          = int64(4)
+	// UserGroupPrefix 用户组前缀.
+	UserGroupPrefix = int64(2)
+	// UserFriendPrefix 用户好友前缀.
+	UserFriendPrefix = int64(3)
+	// UserIDPrefix 用户前缀.
+	UserIDPrefix = int64(4)
 
+	// NetworkTimeout 超时.
 	NetworkTimeout = time.Second * 3
 )
 
+// PrintVersion 输出当前程序编译信息.
 func PrintVersion() {
 	fmt.Printf("Candy\n")
-	sec, _ := strconv.ParseInt(BUILD_TIME, 10, 32)
-	fmt.Printf("Build Time: %s\n", time.Unix(sec, 0).Format("2006-01-02 15:04:05"))
-	fmt.Printf("Git Version: %s\n", BUILD_VERSION)
+	fmt.Printf("Build Time: %s\n", BuildTime)
+	fmt.Printf("Git Version: %s\n", BuildVersion)
 }
 
+// EncodeInt64 编码int64到[]byte.
 func EncodeInt64(v int64) []byte {
 	return []byte{byte(v >> 56), byte(v >> 48), byte(v >> 40), byte(v >> 32), byte(v >> 24), byte(v >> 16), byte(v >> 8), byte(v)}
 }
 
+// DecodeInt64 解码[]byte到int64.
 func DecodeInt64(b []byte) int64 {
 	if len(b) < 8 {
 		return 0
@@ -52,6 +65,7 @@ func DecodeInt64(b []byte) int64 {
 	return int64(b[0])<<56 + int64(b[1])<<48 + int64(b[2])<<40 + int64(b[3])<<32 + int64(b[4])<<24 + int64(b[5])<<16 + int64(b[6])<<8 + int64(b[7])
 }
 
+// EncodeKey 编码int64数组到[]byte.
 func EncodeKey(args ...int64) []byte {
 	var key []byte
 	for _, v := range args {
@@ -60,6 +74,7 @@ func EncodeKey(args ...int64) []byte {
 	return key
 }
 
+// MD5 计算md5.
 func MD5(data []byte) []byte {
 	hash := md5.New()
 	hash.Write(data)

util/master.go

@@ -8,10 +8,12 @@ import (
 	"github.com/dearcode/candy/meta"
 )
 
+// Master 连接master服务.
 type Master struct {
 	client meta.MasterClient
 }
 
+// NewMaster 返回master client.
 func NewMaster(host string) (*Master, error) {
 	conn, err := grpc.Dial(host, grpc.WithInsecure(), grpc.WithTimeout(NetworkTimeout))
 	if err != nil {
@@ -20,6 +22,7 @@ func NewMaster(host string) (*Master, error) {
 	return &Master{client: meta.NewMasterClient(conn)}, nil
 }
 
+// NewID 生成新ID.
 func (m *Master) NewID() (int64, error) {
 	resp, err := m.client.NewID(context.Background(), &meta.NewIDRequest{})
 	if err != nil {

util/notice.go

@@ -9,10 +9,12 @@ import (
 	"github.com/dearcode/candy/util/log"
 )
 
+// Notice 连接notice服务.
 type Notice struct {
 	client meta.NoticeClient
 }
 
+// NewNotice 返回notice client.
 func NewNotice(host string) (*Notice, error) {
 	log.Debugf("dial host:%v", host)
 	conn, err := grpc.Dial(host, grpc.WithInsecure(), grpc.WithTimeout(NetworkTimeout))