Skip to content

Commit 421d092

Browse files
committed
fixed readme
1 parent fa94481 commit 421d092

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

README.md

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -191,20 +191,32 @@ const p256k_public_key = ecdsa.EcdsaSecp256k1Sha256.PublicKey;
191191
// generate p256 public key
192192
const p256_kp = ecdsa.EcdsaP256Sha256.KeyPair.generate();
193193
// from plain bytes
194-
const p256_secret_key = try ecdsa.EcdsaP256Sha256.SecretKey.fromBytes(pri_key_buf);
194+
const p256_secret_key = try ecdsa.EcdsaP256Sha256.SecretKey.fromBytes(pri_key_bytes);
195195
const p256_public_key = try ecdsa.EcdsaP256Sha256.PublicKey.fromSec1(pub_key_bytes);
196+
// from der bytes
197+
const p256_secret_key = try jwt.ecdsa.ParseP256Sha256Der.parseSecretKeyDer(pri_key_bytes);
198+
const p256_secret_key = try jwt.ecdsa.ParseP256Sha256Der.parseSecretKeyPKCS8Der(pri_key_bytes);
199+
const p256_public_key = try jwt.ecdsa.ParseP256Sha256Der.parsePublicKeyDer(pub_key_bytes);
196200
197201
// generate p384 public key
198202
const p384_kp = ecdsa.EcdsaP384Sha384.KeyPair.generate();
199203
// from plain bytes
200-
const p384_secret_key = try ecdsa.EcdsaP384Sha384.SecretKey.fromBytes(pri_key_buf);
204+
const p384_secret_key = try ecdsa.EcdsaP384Sha384.SecretKey.fromBytes(pri_key_bytes);
201205
const p384_public_key = try ecdsa.EcdsaP384Sha384.PublicKey.fromSec1(pub_key_bytes);
206+
// from der bytes
207+
const p384_secret_key = try jwt.ecdsa.ParseP384Sha384Der.parseSecretKeyDer(pri_key_bytes);
208+
const p384_secret_key = try jwt.ecdsa.ParseP384Sha384Der.parseSecretKeyPKCS8Der(pri_key_bytes);
209+
const p384_public_key = try jwt.ecdsa.ParseP384Sha384Der.parsePublicKeyDer(pub_key_bytes);
202210
203211
// generate p256k public key
204212
const p256k_kp = ecdsa.EcdsaSecp256k1Sha256.KeyPair.generate();
205213
// from plain bytes
206-
const p256k_secret_key = try ecdsa.EcdsaSecp256k1Sha256.SecretKey.fromBytes(pri_key_buf);
214+
const p256k_secret_key = try ecdsa.EcdsaSecp256k1Sha256.SecretKey.fromBytes(pri_key_bytes);
207215
const p256k_public_key = try ecdsa.EcdsaSecp256k1Sha256.PublicKey.fromSec1(pub_key_bytes);
216+
// from der bytes
217+
const p256k_secret_key = try jwt.ecdsa.ParseSecp256k1Sha256Der.parseSecretKeyDer(pri_key_bytes);
218+
const p256k_secret_key = try jwt.ecdsa.ParseSecp256k1Sha256Der.parseSecretKeyPKCS8Der(pri_key_bytes);
219+
const p256k_public_key = try jwt.ecdsa.ParseSecp256k1Sha256Der.parsePublicKeyDer(pub_key_bytes);
208220
~~~
209221

210222
EdDSA PublicKey:
@@ -218,8 +230,11 @@ const public_key = Ed25519.PublicKey;
218230
const kp = Ed25519.KeyPair.generate();
219231
220232
// from plain bytes
221-
const secret_key = try Ed25519.SecretKey.fromBytes(pri_key_buf);
222-
const public_key = try Ed25519.PublicKey.fromBytes(pub_key_buf);
233+
const secret_key = try Ed25519.SecretKey.fromBytes(pri_key_bytes);
234+
const public_key = try Ed25519.PublicKey.fromBytes(pub_key_bytes);
235+
// from der bytes
236+
const secret_key = try jwt.eddsa.parseSecretKeyDer(pri_key_bytes);
237+
const public_key = try jwt.eddsa.parsePublicKeyDer(pub_key_bytes);
223238
~~~
224239

225240

src/ecdsa.zig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ test "SigningES384 with der pkcs8 key" {
348348

349349
}
350350

351-
test "SigningES256K with der pkcs8 key no namedcurve" {
351+
test "SigningES256K with der pkcs8 key" {
352352
const alloc = std.heap.page_allocator;
353353

354354
const prikey = "MIGNAgEAMBAGByqGSM49AgEGBSuBBAAKBHYwdAIBAQQgWG7JTJJajqfBSxfzsmz44+xeJPLQtQwFl7lEEaI9I5mgBwYFK4EEAAqhRANCAAR4OeEraufi3V1WWqc6g1ossT/Y0lucIxFSxLL/P/Rq7OmaOEQtk3uFiAp7CnG9rF9U0gdvy1d+rTQOvHZw5450";

0 commit comments

Comments
 (0)