fix: move zod validation out of queries

fixes TIM-40: Remove non-fetch operations from queryFn to only exponentially backoff network requests

Author: debater-coder

apps/client/src/consumers/sbhsApi/useDailyNotices.ts

@@ -4,9 +4,7 @@ import { noticesSchema, sbhsKey } from "./schemas";
 import { useQuery } from "@tanstack/react-query";
 
 const queryFn = async (authActions: OAuth2Actions) => {
-  return noticesSchema.parse(
-    await authActions.fetchAuthenticated("dailynews/list.json")
-  );
+  return await authActions.fetchAuthenticated("dailynews/list.json");
 };
 
 const getQueryKey = sbhsKey("dailynews/list.json");
@@ -17,6 +15,7 @@ export const useDailyNotices = () => {
   return useQuery({
     queryKey: getQueryKey(),
     queryFn: () => queryFn(authActions),
+    select: (data) => noticesSchema.parse(data),
   });
 };
 

apps/client/src/consumers/sbhsApi/useDay.ts

@@ -8,16 +8,14 @@ const queryFn = async (
   from?: string,
   to?: string
 ) => {
-  return daySchema.parse(
-    await authActions.fetchAuthenticated(
-      "calendar/days.json",
-      from && to
-        ? {
-            from,
-            to,
-          }
-        : undefined
-    )
+  return await authActions.fetchAuthenticated(
+    "calendar/days.json",
+    from && to
+      ? {
+          from,
+          to,
+        }
+      : undefined
   );
 };
 
@@ -36,7 +34,7 @@ export const useDay = (from?: string, to?: string) => {
         : undefined
     ),
     queryFn: () => queryFn(authActions, from, to),
-    enabled: !!from && !!to,
+    select: (data) => daySchema.parse(data),
   });
 };
 

apps/client/src/consumers/sbhsApi/useDtt.ts

@@ -4,15 +4,13 @@ import { dttSchema, sbhsKey } from "./schemas";
 import { useQuery } from "@tanstack/react-query";
 
 const queryFn = async (authActions: OAuth2Actions, date?: string) => {
-  return dttSchema.parse(
-    await authActions.fetchAuthenticated(
-      "timetable/daytimetable.json",
-      date
-        ? {
-            date,
-          }
-        : undefined
-    )
+  return await authActions.fetchAuthenticated(
+    "timetable/daytimetable.json",
+    date
+      ? {
+          date,
+        }
+      : undefined
   );
 };
 
@@ -30,6 +28,7 @@ export const useDtt = (date?: string) => {
         : undefined
     ),
     queryFn: () => queryFn(authActions, date),
+    select: (data) => dttSchema.parse(data),
   });
 };
 

apps/client/src/consumers/sbhsApi/useProfile.ts

@@ -4,9 +4,7 @@ import { profileSchema, sbhsKey } from "./schemas";
 import { useQuery } from "@tanstack/react-query";
 
 const queryFn = async (authActions: OAuth2Actions) =>
-  profileSchema.parse(
-    await authActions.fetchAuthenticated("details/userinfo.json")
-  );
+  await authActions.fetchAuthenticated("details/userinfo.json");
 
 const getQueryKey = sbhsKey("details/userinfo.json");
 
@@ -16,6 +14,7 @@ export const useProfile = () => {
   return useQuery({
     queryKey: getQueryKey(),
     queryFn: () => queryFn(authActions),
+    select: (data) => profileSchema.parse(data),
   });
 };
 

apps/client/src/consumers/sbhsApi/useTimetable.ts

@@ -4,9 +4,7 @@ import { timetableSchema, sbhsKey } from "./schemas";
 import { useQuery } from "@tanstack/react-query";
 
 const queryFn = async (authActions: OAuth2Actions) => {
-  return timetableSchema.parse(
-    await authActions.fetchAuthenticated("timetable/timetable.json")
-  );
+  return await authActions.fetchAuthenticated("timetable/timetable.json");
 };
 
 const getQueryKey = sbhsKey("timetable/timetable.json");
@@ -17,6 +15,7 @@ export const useTimetable = () => {
   return useQuery({
     queryKey: getQueryKey(),
     queryFn: () => queryFn(authActions),
+    select: (data) => timetableSchema.parse(data),
   });
 };