lint: knip it before you ship it

debater-coder · debater-coder · commit ea251206c274 · 2023-12-10T14:23:13.000+11:00
diff --git a/apps/client/package.json b/apps/client/package.json
@@ -21,12 +21,10 @@
     "@chakra-ui/icons": "^2.0.19",
     "@chakra-ui/react": "^2.7.1",
     "@chakra-ui/theme-tools": "^2.0.18",
-    "@chakra-ui/toast": "^6.1.4",
     "@emotion/react": "^11.11.1",
     "@emotion/styled": "^11.8.1",
     "@fontsource/poppins": "^4.5.8",
     "@formspree/react": "^2.4.1",
-    "@highlight-run/react": "^3.2.1",
     "@nikolovlazar/chakra-ui-prose": "^1.2.1",
     "@rollup/plugin-replace": "^4.0.0",
     "@sentry/react": "^7.76.0",
diff --git a/apps/client/src/components/CanvasIcon/index.ts b/apps/client/src/components/CanvasIcon/index.ts
@@ -0,0 +1 @@
+export { default } from "./CanvasIcon";
diff --git a/apps/client/src/components/ClipboardIcon/index.ts b/apps/client/src/components/ClipboardIcon/index.ts
@@ -0,0 +1 @@
+export { default } from "./ClipboardIcon";
diff --git a/apps/client/src/components/Nav/Nav.tsx b/apps/client/src/components/Nav/Nav.tsx
@@ -106,7 +106,7 @@ const DarkModeBTN = ({
     colorScheme={"gray"}
   />
 );
-export const LogoutBTN = ({
+const LogoutBTN = ({
   logout,
   iconColor,
 }: {
@@ -133,7 +133,7 @@ export const LogoutBTN = ({
   );
 };
 
-export const SettingsBTN = ({
+const SettingsBTN = ({
   iconColor,
   pathname,
 }: {
diff --git a/apps/client/src/components/PdfViewer/PdfViewer.tsx b/apps/client/src/components/PdfViewer/PdfViewer.tsx
diff --git a/apps/client/src/components/PdfViewer/index.ts b/apps/client/src/components/PdfViewer/index.ts
diff --git a/apps/client/src/consumers/sbhsApi/schemas.ts b/apps/client/src/consumers/sbhsApi/schemas.ts
@@ -42,7 +42,7 @@ export enum NoticeYear {
   UNKNOWN,
 }
 
-export const yearMapping: Record<string, NoticeYear> = {
+const yearMapping: Record<string, NoticeYear> = {
   "7": NoticeYear.YEAR7,
   "8": NoticeYear.YEAR8,
   "9": NoticeYear.YEAR9,
@@ -97,7 +97,7 @@ export const noticesSchema = z
 
 export type TimetablNotice = z.output<typeof noticesSchema>[0];
 
-export const bellSchema = z.object({
+const bellSchema = z.object({
   time: z.string(),
   startTime: z.string(),
   endTime: z.string().nullish(),
@@ -106,14 +106,14 @@ export const bellSchema = z.object({
   period: z.string(),
 });
 
-export const subjectSchema = z.object({
+const subjectSchema = z.object({
   colour: z.string(),
   fullTeacher: z.string(),
   subject: z.string(),
   title: z.string(),
 });
 
-export const periodSchema = z.object({
+const periodSchema = z.object({
   fullTeacher: z.string().nullish(),
   teacher: z.string().nullish(),
   title: z.string().nullish(),
@@ -147,7 +147,7 @@ export type TimetablPeriod = {
   roomTo?: string;
 };
 
-export type TimetablDtt = {
+type TimetablDtt = {
   periods: TimetablPeriod[];
   date: string;
 };
diff --git a/apps/client/src/hooks/useDownloadBarcode.tsx b/apps/client/src/hooks/useDownloadBarcode.tsx
diff --git a/apps/client/src/routes/Main/Home/QuickLinks.tsx b/apps/client/src/routes/Main/Home/QuickLinks.tsx
@@ -1,5 +1,5 @@
-import CanvasIcon from "../../../components/CanvasIcon/CanvasIcon";
-import ClipboardIcon from "../../../components/ClipboardIcon/ClipboardIcon";
+import CanvasIcon from "../../../components/CanvasIcon";
+import ClipboardIcon from "../../../components/ClipboardIcon";
 import { Flex, Button } from "@chakra-ui/react";
 import { GraduationCap, Envelope } from "phosphor-react";
 import { JSXElementConstructor, ReactElement, ReactNode } from "react";
diff --git a/apps/client/src/routes/Main/Home/WeekTimetable.tsx b/apps/client/src/routes/Main/Home/WeekTimetable.tsx
diff --git a/apps/client/src/services/AppRouter/AppRouter.tsx b/apps/client/src/services/AppRouter/AppRouter.tsx
@@ -1,4 +1,4 @@
-import App from "../../components/App/App";
+import App from "../../components/App";
 import Empty from "../../components/Empty";
 import ErrorAlert from "../../components/ErrorAlert";
 import SpinnerSuspense from "../../components/SpinnerSuspense";
diff --git a/apps/client/src/services/AppRouter/pages.tsx b/apps/client/src/services/AppRouter/pages.tsx
@@ -22,7 +22,7 @@ const Page = ({ component }: { component: ReturnType<typeof React.lazy> }) => {
   );
 };
 
-export type TimetablPage = {
+type TimetablPage = {
   path: string;
   name: string;
   icon: React.JSXElementConstructor<
diff --git a/apps/client/src/services/OAuth2Actions/OAuth2Actions.ts b/apps/client/src/services/OAuth2Actions/OAuth2Actions.ts
@@ -21,7 +21,7 @@ const generateRandomString = () => {
   );
 };
 
-export interface AuthStore {
+interface AuthStore {
   setState: (state: Partial<AuthState>) => void;
   getState: () => AuthState;
 }
diff --git a/apps/client/src/stores/auth/auth.ts b/apps/client/src/stores/auth/auth.ts
@@ -20,7 +20,7 @@ export enum AuthStatus {
 /**
  * The possible authentication statuses that are considered logged in.
  */
-export const logged_in_states = [AuthStatus.LOGGED_IN, AuthStatus.EXPIRED];
+const logged_in_states = [AuthStatus.LOGGED_IN, AuthStatus.EXPIRED];
 
 /**
  * The authentication store state.
@@ -62,6 +62,6 @@ export const useAuthStatus = () => useAuthStore((state) => state.status);
 export const useIsLoggedIn = () =>
   useAuthStore((state) => logged_in_states.includes(state.status));
 
-export const resetAuthStore = () => {
+const resetAuthStore = () => {
   useAuthStore.setState(initialState);
 };
diff --git a/apps/client/src/stores/settings/settings.ts b/apps/client/src/stores/settings/settings.ts
@@ -2,7 +2,7 @@ import { ColourScheme } from "../../theme";
 import { create } from "zustand";
 import { devtools, persist } from "zustand/middleware";
 
-export type Actions = {
+type Actions = {
   setPrimary: (primary: ColourScheme) => void;
   setPeriodColours: (periodColours: "default" | "primary" | "none") => void;
   reset: () => void;
@@ -11,15 +11,15 @@ export type Actions = {
   setShowTimes: (showTimes: boolean) => void;
 };
 
-export type SettingsState = {
+type SettingsState = {
   primary: ColourScheme;
   periodColours: "default" | "primary" | "none";
   bgImage: string;
   darkenBlur: boolean;
   showTimes: boolean;
 };
 
-export const initialState: SettingsState = {
+const initialState: SettingsState = {
   primary: "blue",
   periodColours: "default",
   bgImage: "",
diff --git a/package.json b/package.json
@@ -13,7 +13,8 @@
   },
   "devDependencies": {
     "@trivago/prettier-plugin-sort-imports": "^4.2.0",
-    "typescript": "^5.1.6"
+    "typescript": "^5.1.6",
+    "knip": "^3.7.0"
   },
   "packageManager": "pnpm@7.28.0",
   "scripts": {
@@ -22,6 +23,8 @@
     "lint": "turbo run lint",
     "format": "turbo run format",
     "format:watch": "turbo run format:watch",
-    "test": "turbo run test"
+    "test": "turbo run test",
+    "knip": "knip",
+    "knip:fix": "knip --fix"
   }
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export { default } from "./CanvasIcon";`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export { default } from "./ClipboardIcon";`