debezium/dbz#1097 Add Milvus version property and enhance connection validation tests

Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>

Author: kartikangiras

debezium-platform-conductor/pom.xml

@@ -51,6 +51,7 @@
         <version.nats>2.17.6</version.nats>
         <version.oras>0.1.3</version.oras>
         <version.rabbitmq>5.20.0</version.rabbitmq>
+        <version.milvus>2.6.4</version.milvus>
 
         <format.formatter.goal>format</format.formatter.goal>
         <format.imports.goal>sort</format.imports.goal>
@@ -379,7 +380,7 @@
         <dependency>
             <groupId>io.milvus</groupId>
             <artifactId>milvus-sdk-java</artifactId>
-            <version>2.6.4</version>
+            <version>${version.milvus}</version>
         </dependency>
 
         <dependency>

debezium-platform-conductor/src/main/java/io/debezium/platform/environment/connection/destination/MilvusConnectionValidator.java

@@ -38,7 +38,6 @@
  * </ul>
  * </p>
  *
- * @author Pranav Tiwari
  */
 @ApplicationScoped
 @Named("MILVUS")

debezium-platform-conductor/src/main/java/io/debezium/platform/environment/database/MilvusTestResource.java

@@ -28,7 +28,6 @@
  * </ul>
  * </p>
  *
- * @author Pranav Tiwari
  */
 public class MilvusTestResource implements QuarkusTestResourceLifecycleManager {
 
@@ -62,4 +61,4 @@ public void stop() {
     public static GenericContainer<?> getContainer() {
         return milvusContainer;
     }
-}
+}

debezium-platform-conductor/src/test/java/io/debezium/platform/environment/connection/MilvusConnectionValidatorIT.java

@@ -23,7 +23,6 @@
 import io.debezium.platform.data.model.ConnectionEntity;
 import io.debezium.platform.domain.views.Connection;
 import io.debezium.platform.environment.connection.destination.MilvusConnectionValidator;
-import io.debezium.platform.environment.database.MilvusTestResource;
 import io.quarkus.test.common.QuarkusTestResource;
 import io.quarkus.test.junit.QuarkusTest;
 
@@ -34,7 +33,6 @@
  * connection validation against an actual Milvus instance without authentication.
  * </p>
  *
- * @author Pranav Tiwari
  */
 @QuarkusTest
 @QuarkusTestResource(MilvusTestResource.class)
@@ -62,6 +60,7 @@ void shouldConnectWithoutAuth() {
         ConnectionValidationResult result = connectionValidator.validate(connectionConfig);
 
         assertTrue(result.valid(), "Connection validation should succeed");
+        assertThat(result.message()).doesNotContainIgnoringCase("error", "fail", "invalid");
     }
 
     @Test
@@ -84,6 +83,7 @@ void shouldConnectWithDatabase() {
         ConnectionValidationResult result = connectionValidator.validate(connectionConfig);
 
         assertTrue(result.valid(), "Connection validation with database should succeed");
+        assertThat(result.message()).doesNotContainIgnoringCase("error", "fail", "invalid");
     }
 
     @Test
@@ -132,4 +132,123 @@ void shouldHandleTimeout() {
         assertFalse(result.valid(), "Connection validation should fail");
         assertThat(result.message()).containsAnyOf("timeout", "connect", "Connection timeout");
     }
+
+    @Test
+    @DisplayName("Should successfully connect with username and password authentication")
+    void shouldConnectWithUsernamePassword() {
+        GenericContainer<?> container = MilvusTestResource.getContainer();
+
+        Awaitility.await()
+                .atMost(300, TimeUnit.SECONDS)
+                .until(container::isRunning);
+
+        String uri = String.format("http://%s:%d",
+                container.getHost(),
+                container.getMappedPort(19530));
+
+        Connection connectionConfig = new TestConnectionView(ConnectionEntity.Type.MILVUS, Map.of(
+                "uri", uri,
+                "username", "root",
+                "password", "milvus"));
+
+        ConnectionValidationResult result = connectionValidator.validate(connectionConfig);
+
+        assertTrue(result.valid(), "Connection validation with username and password should succeed");
+        assertThat(result.message()).doesNotContainIgnoringCase("error", "fail", "invalid", "authentication");
+    }
+
+    @Test
+    @DisplayName("Should successfully connect with token authentication")
+    void shouldConnectWithTokenAuth() {
+        GenericContainer<?> container = MilvusTestResource.getContainer();
+
+        Awaitility.await()
+                .atMost(300, TimeUnit.SECONDS)
+                .until(container::isRunning);
+
+        String uri = String.format("http://%s:%d",
+                container.getHost(),
+                container.getMappedPort(19530));
+
+        Connection connectionConfig = new TestConnectionView(ConnectionEntity.Type.MILVUS, Map.of(
+                "uri", uri,
+                "token", "root:milvus"));
+
+        ConnectionValidationResult result = connectionValidator.validate(connectionConfig);
+
+        assertTrue(result.valid(), "Connection validation with token authentication should succeed");
+        assertThat(result.message()).doesNotContainIgnoringCase("error", "fail", "invalid", "authentication");
+    }
+
+    @Test
+    @DisplayName("Should fail with invalid username and password")
+    void shouldFailWithInvalidCredentials() {
+        GenericContainer<?> container = MilvusTestResource.getContainer();
+
+        Awaitility.await()
+                .atMost(300, TimeUnit.SECONDS)
+                .until(container::isRunning);
+
+        String uri = String.format("http://%s:%d",
+                container.getHost(),
+                container.getMappedPort(19530));
+
+        Connection connectionConfig = new TestConnectionView(ConnectionEntity.Type.MILVUS, Map.of(
+                "uri", uri,
+                "username", "root",
+                "password", "wrongpassword"));
+
+        ConnectionValidationResult result = connectionValidator.validate(connectionConfig);
+
+        assertFalse(result.valid(), "Connection validation with invalid credentials should fail");
+        assertThat(result.message()).containsAnyOf("authentication", "auth", "permission", "credentials");
+    }
+
+    @Test
+    @DisplayName("Should fail with invalid token")
+    void shouldFailWithInvalidToken() {
+        GenericContainer<?> container = MilvusTestResource.getContainer();
+
+        Awaitility.await()
+                .atMost(300, TimeUnit.SECONDS)
+                .until(container::isRunning);
+
+        String uri = String.format("http://%s:%d",
+                container.getHost(),
+                container.getMappedPort(19530));
+
+        Connection connectionConfig = new TestConnectionView(ConnectionEntity.Type.MILVUS, Map.of(
+                "uri", uri,
+                "token", "root:invalidtoken"));
+
+        ConnectionValidationResult result = connectionValidator.validate(connectionConfig);
+
+        assertFalse(result.valid(), "Connection validation with invalid token should fail");
+        assertThat(result.message()).containsAnyOf("authentication", "auth", "permission", "credentials");
+    }
+
+    @Test
+    @DisplayName("Should successfully connect with all parameters including authentication")
+    void shouldConnectWithAllParams() {
+        GenericContainer<?> container = MilvusTestResource.getContainer();
+
+        Awaitility.await()
+                .atMost(300, TimeUnit.SECONDS)
+                .until(container::isRunning);
+
+        String uri = String.format("http://%s:%d",
+                container.getHost(),
+                container.getMappedPort(19530));
+
+        Connection connectionConfig = new TestConnectionView(ConnectionEntity.Type.MILVUS, Map.of(
+                "uri", uri,
+                "database", "default",
+                "username", "root",
+                "password", "milvus"));
+
+        ConnectionValidationResult result = connectionValidator.validate(connectionConfig);
+
+        assertTrue(result.valid(), "Connection validation with all parameters should succeed");
+        assertThat(result.message()).doesNotContainIgnoringCase("error", "fail", "invalid", "authentication");
+    }
 }

debezium-platform-conductor/src/test/java/io/debezium/platform/environment/connection/MilvusConnectionValidatorTest.java

@@ -28,7 +28,6 @@
  * and edge cases in the validator implementation.
  * </p>
  *
- * @author Pranav Tiwari
  */
 class MilvusConnectionValidatorTest {
 
@@ -85,7 +84,7 @@ void shouldFailWhenUriIsWhitespace() {
     @Test
     @DisplayName("Should fail validation when URI doesn't start with http:// or https://")
     void shouldFailWhenUriHasInvalidProtocol() {
-        Connection connectionConfig = new TestConnectionView(ConnectionEntity.Type.MILVUS, 
+        Connection connectionConfig = new TestConnectionView(ConnectionEntity.Type.MILVUS,
                 Map.of("uri", "localhost:19530"));
 
         ConnectionValidationResult result = connectionValidator.validate(connectionConfig);