feat: adding tests (#224)

* feat: adding tests

adding tests for datastore for #25. one small fix for never-used parameter

* feat: adding tests

fixing mypy error

Author: deborahgu

pyproject.toml

@@ -37,4 +37,11 @@ include_trailing_comma = true
 plugins = ["pydantic.mypy"]
 
 
-[tool.pydantic-mypy]
+[tool.pydantic-mypy]
+
+[tool.pytest]
+minversion = "9.0"
+addopts = ["-ra", "--cov=soundcork", "--cov-report=term-missing:skip-covered"]
+testpaths = [
+    "tests",
+]

requirements.txt

@@ -5,5 +5,7 @@ gunicorn==23.0.0
 isort==8.0.0  # dev only
 mypy==1.19.1  # dev only
 pydantic-settings==2.13.1
+pytest==9.0.1  # dev only
+pytest-cov==7.0.0  # dev only
 telnetlib3==3.0.2
 upnpclient==1.0.3

soundcork/datastore.py

@@ -39,10 +39,6 @@ class DataStore:
     def __init__(self) -> None:
         logger.info("Initiating Datastore")
         self.data_dir = settings.data_dir
-        # def __init__(self, data_dir: str, settings: Settings) -> None:
-
-    def initialize_data_directory(self) -> None:
-        raise NotImplementedError
 
     def poweron_devices_dir(self) -> str:
         """returns the top-level directory that stores poweron info for all devices"""
@@ -64,11 +60,9 @@ def account_dir(self, account: str, create: bool = False) -> str:
     def account_devices_dir(self, account: str) -> str:
         return path.join(self.data_dir, account, DEVICES_DIR)
 
-    def account_device_dir(
-        self, account: str, device: str, create: bool = False
-    ) -> str:
+    def account_device_dir(self, account: str, device: str) -> str:
         dir = path.join(self.account_devices_dir(account), device)
-        if not path.exists(dir) and not create:
+        if not path.exists(dir):
             raise HTTPException(
                 HTTPStatus.NOT_FOUND,
                 f"Device {device} does not belong to account {account}",