Skip to content

Commit 1d82877

Browse files
Apply suggestions from code review
Co-authored-by: filip-debricked <135233582+filip-debricked@users.noreply.github.com>
1 parent 0bba7ed commit 1d82877

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

internal/cmd/scan/scan.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ var callgraphGenerateTimeout int
2121
var callgraphUploadTimeout int
2222
var commitAuthor string
2323
var commitName string
24-
var generateCommitNameBool bool
24+
var generateCommitName bool
2525
var debug bool
2626
var exclusions = file.Exclusions()
2727
var inclusions = file.Exclusions()
@@ -69,7 +69,7 @@ const (
6969
TagCommitAsReleaseFlag = "tag-commit-as-release"
7070
TagCommitAsReleaseEnv = "TAG_COMMIT_AS_RELEASE"
7171
ExperimentalFlag = "experimental"
72-
GenerateCommitName = "generate-commit-name"
72+
GenerateCommitNameFlag = "generate-commit-name"
7373
)
7474

7575
var scanCmdError error
@@ -90,7 +90,7 @@ If the given path contains a git repository all flags but "integration" will be
9090

9191
cmd.Flags().StringVarP(&repositoryName, RepositoryFlag, "r", "", "repository name")
9292
cmd.Flags().StringVarP(&commitName, CommitFlag, "c", "", "commit hash")
93-
cmd.Flags().BoolVar(&generateCommitNameBool, GenerateCommitName, false, "auto-generate a commit name if no commit hash is found (in -c or env)")
93+
cmd.Flags().BoolVar(&generateCommitName, GenerateCommitNameFlag, false, "auto-generate a commit name if no commit hash is found (in -c or env)")
9494
cmd.Flags().StringVarP(&branchName, BranchFlag, "b", "", "branch name")
9595
cmd.Flags().StringVarP(&commitAuthor, CommitAuthorFlag, "a", "", "commit author")
9696
cmd.Flags().StringVarP(&repositoryUrl, RepositoryUrlFlag, "u", "", "repository URL")
@@ -242,7 +242,7 @@ func RunE(s *scan.IScanner) func(_ *cobra.Command, args []string) error {
242242
VersionHint: viper.GetBool(VersionHintFlag),
243243
RepositoryName: viper.GetString(RepositoryFlag),
244244
CommitName: viper.GetString(CommitFlag),
245-
GenerateCommitName: viper.GetBool(GenerateCommitName),
245+
GenerateCommitName: viper.GetBool(GenerateCommitNameFlag),
246246
BranchName: viper.GetString(BranchFlag),
247247
CommitAuthor: viper.GetString(CommitAuthorFlag),
248248
RepositoryUrl: viper.GetString(RepositoryUrlFlag),

0 commit comments

Comments
 (0)