refactor: remove URL expectations from tests for improved stability (#31)

* refactor: remove URL expectations from tests for improved stability

* refactor: remove unused 'expect' import from list-test helper

* test: add URL expectations for genre links in movie details page

Author: debs-obrien

playwright.config.ts

@@ -26,7 +26,6 @@ export default defineConfig({
   /* Reporter to use. See https://playwright.dev/docs/test-reporters */
   reporter: process.env.CI ? [['html'], ['dot']] : 'html',
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
-  updateSourceMethod: 'overwrite',
   use: {
     /* Base URL to use in actions like `await page.goto('/')`. */
     baseURL: 'http://localhost:3000/',

tests/helpers/list-test.ts

@@ -1,4 +1,4 @@
-import { test as baseTest, Page, expect } from '@playwright/test';
+import { test as baseTest, Page } from '@playwright/test';
 import { createList, addMovie } from './list-utilities';
 
 /**
@@ -30,7 +30,6 @@ export const listTest = baseTest.extend<{ listPage: Page }>({
 
     await listTest.step('add image to list', async () => {
       await page.getByRole('link', { name: 'Choose Image' }).click();
-      await expect(page).toHaveURL(/choose-image/);
       const movie = page
         .getByRole('listitem', { name: 'movie' })
         .filter({ hasText: /Garfield/ })

tests/helpers/list-utilities.ts

@@ -42,8 +42,6 @@ export async function openLists(page: Page, name: string = 'My Lists') {
   await test.step('open list from menu', async () => {
     await page.getByRole('button', { name: 'User Profile' }).click();
     await page.getByRole('link', { name }).click();
-    const formattedName = name.toLowerCase().replace(/\s+/g, '-');
-    await expect(page).toHaveURL(new RegExp(`/${formattedName}`));
   });
 }
 
@@ -85,7 +83,6 @@ export async function addImageToList(page: Page, movieName: string) {
   await test.step('add image to list', async () => {
     // Click on the "Choose Image" link
     await page.getByRole('link', { name: 'Choose Image' }).click();
-    await expect(page).toHaveURL(/choose-image/);
 
     // Find the movie list item and verify its heading contains the movie name
     const movie = page.getByRole('listitem', { name: 'movie' });

tests/logged-in/manage-lists-fixtures.spec.ts

@@ -17,7 +17,6 @@ test('editing an existing list', async ({ listPage }) => {
     await expect(page.getByRole('textbox', { name: 'Name' })).toHaveValue('my action movies');
     await expect(page.getByRole('textbox', { name: 'Description' }))
       .toHaveValue('my favorite action movies');
-    // TODO: replace regex with text when Playwright is rolled.
     await expect(page.locator('main')).toMatchAriaSnapshot(`
       - heading "my action movies" [level=1]
       - textbox "Name": my action movies
@@ -108,7 +107,6 @@ test('deleting a list', async ({ listPage }) => {
   });
 
   // Verify that the list has been deleted
-  await expect(page).toHaveURL(/my-lists/);
   await expect(page.getByRole('heading', { level: 3 }))
     .toHaveText(/no lists/);
   await expect(page.getByRole('listitem', { name: 'movie' })).toHaveCount(0);