chore: replace timeout with waiting for navigation (#26)

Skn0tt · web-flow · commit a932b2000f1c · 2025-01-30T14:32:44.000+01:00
diff --git a/tests/helpers/list-utilities.ts b/tests/helpers/list-utilities.ts
@@ -23,7 +23,8 @@ export async function createList(
     await page.getByLabel('Name').fill(listName);
     await page.getByLabel('Description').fill(listDescription);
     await page.getByRole('button', { name: 'Continue' }).click();
-    await page.waitForTimeout(1000);
+    // wait until the list was created and we're on its add/remove movies page
+    await page.waitForURL(url => url.searchParams.has('listId'));
   });
 }
 

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,8 @@ export async function createList(`
`23`	`23`	`await page.getByLabel('Name').fill(listName);`
`24`	`24`	`await page.getByLabel('Description').fill(listDescription);`
`25`	`25`	`await page.getByRole('button', { name: 'Continue' }).click();`
`26`		`- await page.waitForTimeout(1000);`
	`26`	`+ // wait until the list was created and we're on its add/remove movies page`
	`27`	`+ await page.waitForURL(url => url.searchParams.has('listId'));`
`27`	`28`	`});`
`28`	`29`	`}`
`29`	`30`