Skip to content

Commit 76128d0

Browse files
committed
Don't always draw but draw when filter is on irrespective of the screen visibility
1 parent 529a3de commit 76128d0

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

app/public/js/main.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ var width;
66
var height;
77
var volume = 0.6;
88
var ULTIMATE_DREAM_KILLER = false; // https://github.com/debugger22/github-audio/pull/19
9-
var orgRepoFilterNames;
9+
var orgRepoFilterNames = [];
1010

1111
var scale_factor = 6,
1212
note_overlap = 2,
@@ -38,7 +38,7 @@ socket.on('github', function (data) {
3838
data.data.forEach(function(event){
3939
if(!isEventInQueue(event)){
4040
// Filter out events only specified by the user
41-
if(orgRepoFilterNames != null && orgRepoFilterNames != []){
41+
if(orgRepoFilterNames != []){
4242
// Don't consider pushes to github.io repos when org filter is on
4343
if(new RegExp(orgRepoFilterNames.join("|")).test(event.repo_name)
4444
&& event.repo_name.indexOf('github.io') == -1){
@@ -246,8 +246,8 @@ function playFromQueueExchange1(){
246246
var event = eventQueue.shift();
247247
if(event != null && event.message != null && !shouldEventBeIgnored(event) && svg != null){
248248
playSound(event.message.length*1.1, event.type);
249-
// if(!document.hidden)
250-
drawEvent(event, svg);
249+
if(!document.hidden !! orgRepoFilterNames != [])
250+
drawEvent(event, svg);
251251
}
252252
setTimeout(playFromQueueExchange1, Math.floor(Math.random() * 1000) + 500);
253253
$('.events-remaining-value').html(eventQueue.length);
@@ -257,8 +257,8 @@ function playFromQueueExchange2(){
257257
var event = eventQueue.shift();
258258
if(event != null && event.message != null && !shouldEventBeIgnored(event) && svg != null){
259259
playSound(event.message.length, event.type);
260-
// if(!document.hidden)
261-
drawEvent(event, svg);
260+
if(!document.hidden !! orgRepoFilterNames != [])
261+
drawEvent(event, svg);
262262
}
263263
setTimeout(playFromQueueExchange2, Math.floor(Math.random() * 800) + 500);
264264
$('.events-remaining-value').html(eventQueue.length);

0 commit comments

Comments
 (0)