Skip to content

Commit 66b7ad5

Browse files
authored
Allow codecombat to run through decaffeinate on recent node (#119)
It looks like running decaffeinate in node 8 will probabbly save a few minutes from the build and hopefully make it much less likely to time out. Also split the config up into multiple commands so it's easier to see timing information.
1 parent edd1e84 commit 66b7ad5

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

examples/codecombat/config.js

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,33 +6,32 @@ export default {
66
'babel-plugin-transform-remove-strict-mode',
77
'babel-loader',
88
],
9-
testCommands: [`
9+
testCommands: [
10+
`
1011
set -e
1112
export COCO_TRAVIS_TEST=1
1213
export DISPLAY=:99.0
1314
if [ -e /etc/init.d/xvfb ]; then
1415
sh -e /etc/init.d/xvfb start
1516
fi
1617
rm -rf public
17-
# Some dependency issues make the install fail the first time, so just try again.
18-
npm install || npm install
19-
# node-sass doesn't get set up correctly for some reason, so set it up again.
20-
npm install node-sass
21-
npm install request
22-
23-
./node_modules/.bin/bower install
24-
./node_modules/.bin/webpack
25-
26-
git add -f public/javascripts/test.js
27-
git commit -m 'Save bad built JS file for diagnostic purposes'
28-
29-
node index.js --unittest &
18+
`,
19+
'nvm install 5.10.1',
20+
// Some dependency issues make the install fail the first time, so just try again.
21+
'npm install || npm install',
22+
// node-sass doesn't get set up correctly for some reason, so set it up again.
23+
'npm install node-sass',
24+
'npm install request',
25+
'./node_modules/.bin/bower install',
26+
'./node_modules/.bin/webpack',
27+
'node index.js --unittest &',
28+
`
3029
n=0
3130
until [ $n -ge 60 ]; do curl http://localhost:3000 && break; n=$[$n+1]; sleep 1; done
32-
33-
./node_modules/karma/bin/karma start --browsers Firefox --single-run --reporters dots
34-
npm run jasmine
35-
`],
31+
`,
32+
'./node_modules/karma/bin/karma start --browsers Firefox --single-run --reporters dots',
33+
'npm run jasmine',
34+
],
3635
expectConversionSuccess: true,
3736
expectTestSuccess: true,
3837
};

0 commit comments

Comments
 (0)