fix: update code to enforce noImplicitAny (#236)

Author: alangpierce

package.json

@@ -22,9 +22,11 @@
     "dist/"
   ],
   "dependencies": {
+    "@types/babylon": "^6.16.1",
+    "@types/json-stable-stringify": "^1.0.31",
     "babylon": "^6.14.1",
     "coffee-lex": "^7.0.0",
-    "decaffeinate-coffeescript": "1.10.0-patch24",
+    "decaffeinate-coffeescript": "1.10.0-patch25",
     "json-stable-stringify": "^1.0.1",
     "lines-and-columns": "^1.1.6"
   },

script/check-file.ts

@@ -29,7 +29,7 @@ function processFile(path: string) {
   } catch (ex) {
     console.log(`NOT OK ${path}`);
     console.log(`    ${ex.message}`);
-    console.log(ex.stack.split('\n').map(line => `   ${line}`).join('\n'));
+    console.log(ex.stack.split('\n').map((line: string) => `   ${line}`).join('\n'));
   }
 }
 

src/mappers/mapAssign.ts

@@ -5,7 +5,7 @@ import UnsupportedNodeError from '../util/UnsupportedNodeError';
 import mapAny from './mapAny';
 import mapBase from './mapBase';
 
-const COMPOUND_ASSIGN_OPS = {
+const COMPOUND_ASSIGN_OPS: {[op: string]: string | undefined} = {
   '-=': SubtractOp.name,
   '+=': PlusOp.name,
   '/=': DivideOp.name,

src/mappers/mapLiteral.ts

@@ -56,7 +56,7 @@ export default function mapLiteral(context: ParseContext, node: Literal): Node {
     let regExp = parseRegExp(node.value);
     return new Regex(
       line, column, start, end, raw,
-      regExp.pattern, RegexFlags.parse(regExp.flags)
+      regExp.pattern, RegexFlags.parse(regExp.flags || '')
     );
   }
 

src/util/parseNumber.ts

@@ -1,8 +1,11 @@
+import { ExpressionStatement, NumericLiteral } from 'babel-types';
 import { parse } from 'babylon';
 
 /**
  * Parses JavaScript source representing a number.
  */
 export default function parseNumber(string: string): number {
-  return parse(`(${string})`).program.body[0].expression.value;
+  let expressionStatement = parse(`(${string})`).program.body[0] as ExpressionStatement;
+  let literal = expressionStatement.expression as NumericLiteral;
+  return literal.value;
 }

src/util/parseRegExp.ts

@@ -1,8 +1,11 @@
+import { ExpressionStatement, RegExpLiteral } from 'babel-types';
 import { parse } from 'babylon';
 
 /**
  * Parses JavaScript source representing a regular expression.
  */
-export default function parseRegExp(string: string): { pattern: string, flags: string } {
-  return parse(`(${string})`).program.body[0].expression;
+export default function parseRegExp(string: string): { pattern: string, flags?: string } {
+  let expressionStatement = parse(`(${string})`).program.body[0] as ExpressionStatement;
+  let literal = expressionStatement.expression as RegExpLiteral;
+  return literal;
 }

src/util/parseString.ts

@@ -1,8 +1,11 @@
+import { ExpressionStatement, StringLiteral } from 'babel-types';
 import { parse } from 'babylon';
 
 /**
  * Parses JavaScript source representing a string.
  */
 export default function parseString(string: string): string {
-  return parse(`(${string})`).program.body[0].expression.value;
+  let expressionStatement = parse(`(${string})`).program.body[0] as ExpressionStatement;
+  let literal = expressionStatement.expression as StringLiteral;
+  return literal.value;
 }

tsconfig.json

@@ -6,8 +6,10 @@
     "declaration": true,
     "lib": ["es2015"],
     "experimentalDecorators": true,
+    "noImplicitAny": true,
     "noUnusedParameters": true,
     "noUnusedLocals": true,
-    "noEmit": true
+    "noEmit": true,
+    "suppressImplicitAnyIndexErrors": true
   }
-}
+}

yarn.lock

@@ -35,6 +35,20 @@
     conventional-changelog "0.0.17"
     github-url-from-git "^1.4.0"
 
+"@types/babel-types@*":
+  version "6.7.16"
+  resolved "https://registry.npmjs.org/@types/babel-types/-/babel-types-6.7.16.tgz#e2602896636858a0067971f7ca4bb8678038293f"
+
+"@types/babylon@^6.16.1":
+  version "6.16.1"
+  resolved "https://registry.npmjs.org/@types/babylon/-/babylon-6.16.1.tgz#e4d10ab9e43a73703a17c6f41438bede28769340"
+  dependencies:
+    "@types/babel-types" "*"
+
+"@types/json-stable-stringify@^1.0.31":
+  version "1.0.31"
+  resolved "https://registry.npmjs.org/@types/json-stable-stringify/-/json-stable-stringify-1.0.31.tgz#b6c7bc507f5267e88cd2839b3ac6a2b39b653a32"
+
 "@types/mocha@^2.2.35":
   version "2.2.41"
   resolved "https://registry.npmjs.org/@types/mocha/-/mocha-2.2.41.tgz#e27cf0817153eb9f2713b2d3f6c68f1e1c3ca608"
@@ -864,9 +878,9 @@ debug@2.6.0:
   dependencies:
     ms "0.7.2"
 
-decaffeinate-coffeescript@1.10.0-patch24:
-  version "1.10.0-patch24"
-  resolved "https://registry.npmjs.org/decaffeinate-coffeescript/-/decaffeinate-coffeescript-1.10.0-patch24.tgz#11ed2b31c7253686ded645aa29521ba38741e811"
+decaffeinate-coffeescript@^1.10.0-patch25:
+  version "1.10.0-patch25"
+  resolved "https://registry.npmjs.org/decaffeinate-coffeescript/-/decaffeinate-coffeescript-1.10.0-patch25.tgz#81816adc6361bd7d1e59d9034c8c5bfcea00677e"
 
 decamelize@^1.1.2:
   version "1.2.0"