Skip to content

Commit ad36e6b

Browse files
authored
fix: Show errors when saving items in the EditPriceAndBeneficiaryModal (#2877)
1 parent 1180ab6 commit ad36e6b

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/components/Modals/EditPriceAndBeneficiaryModal/EditPriceAndBeneficiaryModal.container.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { connect } from 'react-redux'
22
import { isLoadingType } from 'decentraland-dapps/dist/modules/loading/selectors'
33

44
import { RootState } from 'modules/common/types'
5-
import { getAuthorizedItems, getLoading } from 'modules/item/selectors'
5+
import { getAuthorizedItems, getLoading, getError } from 'modules/item/selectors'
66
import {
77
saveItemRequest,
88
setPriceAndBeneficiaryRequest,
@@ -20,6 +20,7 @@ const mapState = (state: RootState, ownProps: OwnProps): MapStateProps => {
2020

2121
return {
2222
item,
23+
error: getError(state),
2324
isLoading:
2425
isLoadingType(getLoading(state), FETCH_ITEMS_REQUEST) ||
2526
isLoadingType(getLoading(state), SAVE_ITEM_REQUEST) ||

src/components/Modals/EditPriceAndBeneficiaryModal/EditPriceAndBeneficiaryModal.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ export default class EditPriceAndBeneficiaryModal extends React.PureComponent<Pr
129129
}
130130

131131
render() {
132-
const { name, isLoading, mountNode, onClose, onSkip } = this.props
132+
const { name, error, isLoading, mountNode, onClose, onSkip } = this.props
133133
const { isFree, isOwnerBeneficiary, price = '' } = this.state
134134
const beneficiary = this.getBeneficiary()
135135

@@ -204,6 +204,7 @@ export default class EditPriceAndBeneficiaryModal extends React.PureComponent<Pr
204204
</Card.Content>
205205
</Card>
206206
) : null}
207+
{error ? <p className="danger-text">{error}</p> : null}
207208
</ModalContent>
208209
<ModalActions>
209210
<NetworkButton primary disabled={this.isDisabled()} loading={isLoading} network={Network.MATIC}>

src/components/Modals/EditPriceAndBeneficiaryModal/EditPriceAndBeneficiaryModal.types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010

1111
export type Props = ModalProps & {
1212
item: Item
13+
error: string | null
1314
isLoading: boolean
1415
metadata: EditPriceAndBeneficiaryModalMetadata
1516
itemSortedContents?: Record<string, Blob>
@@ -31,6 +32,6 @@ export type EditPriceAndBeneficiaryModalMetadata = {
3132
}
3233

3334
export type OwnProps = Pick<Props, 'metadata' | 'item' | 'mountNode'>
34-
export type MapStateProps = Pick<Props, 'item' | 'isLoading'>
35+
export type MapStateProps = Pick<Props, 'item' | 'error' | 'isLoading'>
3536
export type MapDispatchProps = Pick<Props, 'onSave' | 'onSetPriceAndBeneficiary'>
3637
export type MapDispatch = Dispatch<SaveItemRequestAction | SetPriceAndBeneficiaryRequestAction>

0 commit comments

Comments
 (0)