-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Context
Currently, the logic for handling JumpIn (launcher detection, modal display, and redirects) is duplicated in both repositories:
jump-siteui2
This duplication increases maintenance cost and makes it harder to keep behavior consistent.
Problem
- The same modal logic is implemented in both codebases.
- The modal should not be shown anymore.
- The
JumpIncomponent inui2is the right place to centralize this logic.
Expected behavior
- Remove the modal behavior from
jump-site. - Reuse the
JumpIncomponent from UI2, ensuring that all the logic for handling sign-in state and redirects lives in one place.
Proposed changes
- Refactor
jump-siteto stop handling modal logic directly. - Import and reuse the
JumpIncomponent fromui2. - Pass the required props (
isSignedIn,downloadUrl,onboardingUrl) to the component. - Eliminate the duplicated modal-related code from
jump-site.
Expected outcome
- A single source of truth for
JumpInlogic in UI2. - Cleaner code in
jump-sitewithout modal handling. - Consistent user experience across dapps.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request