Validate atleast one personal data is present in a data agreement.

- Added validation function to 'personal_data' field in data agreement schema class
- Refactored test case, to instantiate the data agreement in the setUp() phase.
- Added unit test to make sure an exception is raise if personal data list is empty.

Signed-off-by: George J Padayatti <[email protected]>

Author: georgepadayatti

mydata_did/v1_0/models/data_agreement_model.py

@@ -579,7 +579,8 @@ def validate_usage_purpose_description(self, value):
     # Data agreement personal data (attributes)
     personal_data = fields.List(
         fields.Nested(DataAgreementPersonalDataSchema),
-        required=True
+        required=True,
+        validate=validate.Length(min=1)
     )
 
     # Data agreement DPIA metadata

mydata_did/v1_0/models/tests/test_data_agreement_model.py

@@ -6,8 +6,8 @@
 
 class TestDataAgreementV1Model(AsyncTestCase):
 
-    def test_data_agreement_model(self):
-        data_agreement_dict = {
+    def setUp(self) -> None:
+        self.data_agreement_dict = {
             "@context": "https://raw.githubusercontent.com/decentralised-dataexchange/automated-data-agreements/main/interface-specs/data-agreement-schema/v1/data-agreement-schema-context.jsonld",
             "data_controller_name": "XYZ Corp",
             "data_controller_url": "https://xyz.com",
@@ -37,7 +37,10 @@ def test_data_agreement_model(self):
             }
         }
 
-        data_agreement: DataAgreementV1 = DataAgreementV1Schema().load(data_agreement_dict)
+    def test_data_agreement_model(self):
+
+        data_agreement: DataAgreementV1 = DataAgreementV1Schema().load(
+            self.data_agreement_dict)
 
         assert data_agreement.pii_controller_name == "XYZ Corp"
 
@@ -46,9 +49,32 @@ def test_data_agreement_model(self):
         self.assertIsNone(
             data_agreement.personal_data[0].attribute_id, "Attribute ID should be None")
 
-        data_agreement_dict.pop("data_controller_name")
+        self.data_agreement_dict.pop("data_controller_name")
         with self.assertRaises(ValidationError) as ctx:
-            data_agreement: DataAgreementV1 = DataAgreementV1Schema().load(data_agreement_dict)
+            data_agreement: DataAgreementV1 = DataAgreementV1Schema().load(
+                self.data_agreement_dict)
 
         self.assertTrue(
             "Missing data for required field." in str(ctx.exception))
+
+    def test_data_agreement_model_without_personal_data(self):
+        self.data_agreement_dict.pop("personal_data")
+
+        with self.assertRaises(ValidationError) as ctx:
+            data_agreement: DataAgreementV1 = DataAgreementV1Schema().load(
+                self.data_agreement_dict)
+
+        self.assertTrue(
+            "Missing data for required field." in str(ctx.exception)
+        )
+    
+    def test_data_agreement_model_with_empty_personal_data(self):
+        self.data_agreement_dict["personal_data"] = []
+
+        with self.assertRaises(ValidationError) as ctx:
+            data_agreement: DataAgreementV1 = DataAgreementV1Schema().load(
+                self.data_agreement_dict)
+
+        self.assertTrue(
+            "Shorter than minimum length 1." in str(ctx.exception)
+        )