fix: mismatched ethers types when in esm project #211
Conversation
Fix mismatch of ethers/lib.commonjs Provider with ethers/lib.esm
Provider. This has been an issue when attempting to construct
configuration driven provider fallbacks for did-resolver
Drilling down to the Provider type via this package within an esm
package yielded a `lib.commonjs` `Provider` that did not match the esm
ethers `Provider`.
Restructure build directories into `lib.commonjs` and `lib.esm`. Matches
structure in ethers.js
Adjust .gitignore to exclude new out directories
Separated into two tsconfig files named `tsconfig.{common,esm}.json`
[package.json]
Removed `source` [not in spec]
Removed `type`, `module`, and `types` from top level
Added `import` and `require` to `exports` and re-added `types`
Modified `files` to point to new out dirs, removed LICENSE (included by
default), and src (no utility).
Modified script `clean`
Added new `build:` scripts both called from `build`
|
This might seem like a non-issue without some context. We're pulling two types, one from type ArgumentsType<T> = T extends (...args: infer U) => any ? U : never;
type FuncGetResolver = typeof ethrDidResolver;
type FuncParameter = ArgumentsType<FuncGetResolver>[0];
interface InfuraConfiguration {
infuraProjectId: string;
}
type MultiProviderConfiguration = Exclude<FuncParameter, InfuraConfiguration>;
type ProviderConfiguration = Exclude<
MultiProviderConfiguration['networks'],
undefined
>[number];
type ProviderOrConfig = ConstructorParameters<
typeof FallbackProvider
>[0][number];
type FallbackProviderConfig = ProviderOrConfig extends AbstractProvider
? never
: ProviderOrConfig;However, at the end of this process the |
pauldesmondparker
force-pushed
the
feat/split-esm-commonjs
branch
from
1a5ea48 to
1235b16
Compare
pauldesmondparker
force-pushed
the
feat/split-esm-commonjs
branch
from
1235b16 to
85e79b1
Compare
|
For ease of testing, use the branch #publish on my repo. Warning Only With "pnpm": {
"overrides": {
"ethr-did-resolver": "pauldesmondparker/ethr-did-resolver#publish"
}
},npm: "overrides": {
"ethr-did-resolver": "github:pauldesmondparker/ethr-did-resolver#publish"
}yarn: "resolutions": {
"ethr-did-resolver": "https://github.com/pauldesmondparker/ethr-did-resolver#publish"
} |
|
Fixed test. Forgot to specify a tsconfig file in Jest config. Locally I get a warning about linking for Ganache, but it's likely the version of node I used: Also ran format and lint. |
|
Using Note Tests are passing though. |
Fix mismatch of ethers/lib.commonjs Provider with ethers/lib.esm Provider. This has been an issue when attempting to construct configuration driven provider fallbacks for did-resolver
Drilling down to the Provider type via this package within an esm package yielded a
lib.commonjsProviderthat did not match the esm ethersProvider.Restructure build directories into
lib.commonjsandlib.esm. Matches structure in ethers.jsAdjust .gitignore to exclude new out directories
Separated into two tsconfig files named
tsconfig.{common,esm}.json[package.json]
Removed
source[not in spec]Removed
type,module, andtypesfrom top level Addedimportandrequiretoexportsand re-addedtypesModifiedfilesto point to new out dirs, removed LICENSE (included by default), and src (no utility).Modified script
cleanAdded new
build:scripts both called frombuild