Oauth 2.0 breaking change fix #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-version add auth scheme request body
|
Just ran into this issue when upgrading our oauth2 dependency from 1.4.1 to 2.0.9, this would be great to have as the default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uprading
oauth2to version 2.0.9 https://rubygems.org/gems/oauth2/versions/2.0.9 introduces breaking changes with:auth_scheme. The default value in 2.X.X is:basic_authbut it used to be:request_bodyin 1.X.X https://github.com/oauth-xx/oauth2/blob/main/lib/oauth2/client.rb#L54 and notes here https://github.com/oauth-xx/oauth2/tree/main?tab=readme-ov-file#what-is-new-for-v20Default value in 1.X.X https://gitlab.com/oauth-xx/oauth2/-/blob/1-4-stable/lib/oauth2/client.rb?ref_type=heads#L44
Some integrations still rely on
request_bodyand linkedin is one of them so adding this