fix: unload of editor should always be called when navigating away from it

Author: peterpeterparker

studio/src/app/components/core/app-menu-user/app-menu-user.tsx

@@ -146,13 +146,6 @@ export class AppMenuUser {
         });
     }
 
-    private navigateNewDeck() {
-        this.navService.navigate({
-            url: '/editor',
-            direction: NavDirection.ROOT
-        })
-    }
-
     private async filterDecksOnChange(e: CustomEvent) {
         if (e && e.detail) {
             await this.filterDecks(e.detail.value);
@@ -213,7 +206,7 @@ export class AppMenuUser {
 
             <ion-item-divider>
                 <ion-label>Presentations</ion-label>
-                <ion-button size="small" slot="end" shape="round" onClick={() => this.navigateNewDeck()} class="new ion-margin-end">
+                <ion-button size="small" slot="end" shape="round" href="/editor" routerDirection="root" class="new ion-margin-end">
                     <ion-icon name="book" slot="start"></ion-icon>
                     <ion-label>New</ion-label>
                 </ion-button>

studio/src/app/components/core/app-navigation-actions/app-navigation-actions.tsx

@@ -97,7 +97,7 @@ export class AppNavigationActions {
 
     private renderPresentationButton() {
         if (this.presentation) {
-            return <ion-button class="presentation ion-padding-end" shape="round" href="/editor" routerDirection="forward">
+            return <ion-button class="presentation ion-padding-end" shape="round" href="/editor" routerDirection="root">
                 <ion-label class="ion-text-uppercase">Write a presentation</ion-label>
             </ion-button>;
         } else {

studio/src/components.d.ts

@@ -8,9 +8,9 @@
 import '@stencil/core';
 
 import '@ionic/core';
-import 'ionicons';
 import 'deckdeckgo';
 import 'deckdeckgo-inline-editor';
+import 'ionicons';
 import {
   EventEmitter,
 } from '@stencil/core';