handler: feat: remove GET slides

Author: nmattia

infra/handler/app/Test.hs

@@ -65,22 +65,12 @@ main = do
     Right deck ->
       if deck == (Item deckId newDeck) then pure () else (error $ "Expected get deck, got: " <> show deck)
 
-  runClientM (slidesGet' b deckId) clientEnv >>= \case
-    Left err -> error $ "Expected slides, got error: " <> show err
-    Right slides ->
-      if slides == [Item slideId someSlide] then pure () else (error $ "Expected slides, got: " <> show slides)
-
   let updatedSlide = Slide "foo" "quux" HMS.empty
 
   runClientM (slidesPut' b deckId slideId updatedSlide) clientEnv >>= \case
     Left err -> error $ "Expected new slide, got error: " <> show err
     Right {} -> pure ()
 
-  runClientM (slidesGet' b deckId) clientEnv >>= \case
-    Left err -> error $ "Expected updated slides, got error: " <> show err
-    Right slides ->
-      if slides == [Item slideId updatedSlide] then pure () else (error $ "Expected updated slides, got: " <> show slides)
-
   runClientM (slidesGetSlideId' b deckId slideId) clientEnv >>= \case
     Left err -> error $ "Expected updated slide, got error: " <> show err
     Right slide ->
@@ -90,11 +80,6 @@ main = do
     Left err -> error $ "Expected slide delete, got error: " <> show err
     Right {} -> pure ()
 
-  runClientM (slidesGet' b deckId) clientEnv >>= \case
-    Left err -> error $ "Expected no slides, got error: " <> show err
-    Right slides ->
-      if slides == [] then pure () else (error $ "Expected no slides, got: " <> show slides)
-
   runClientM (decksDelete' b deckId) clientEnv >>= \case
     Left err -> error $ "Expected deck delete, got error: " <> show err
     Right {} -> pure ()
@@ -138,7 +123,6 @@ decksPost' :: T.Text -> Deck -> ClientM (Item DeckId Deck)
 decksPut' :: T.Text -> DeckId -> Deck -> ClientM (Item DeckId Deck)
 decksDelete' :: T.Text -> DeckId -> ClientM ()
 
-slidesGet' :: T.Text -> DeckId -> ClientM [Item SlideId Slide]
 slidesGetSlideId' :: T.Text -> DeckId -> SlideId -> ClientM (Item SlideId Slide)
 slidesPost' :: T.Text -> DeckId -> Slide -> ClientM (Item SlideId Slide)
 slidesPut' :: T.Text -> DeckId -> SlideId -> Slide -> ClientM (Item SlideId Slide)
@@ -158,7 +142,6 @@ slidesDelete' :: T.Text -> DeckId -> SlideId -> ClientM ()
   decksDelete'
   ) :<|>
   (
-  slidesGet' :<|>
   slidesGetSlideId' :<|>
   slidesPost' :<|>
   slidesPut' :<|>

infra/handler/src/DeckGo/Handler.hs

@@ -164,7 +164,6 @@ type DecksAPI =
       Capture "deck_id" DeckId :>
       ReqBody '[JSON] Deck :> Put '[JSON] (Item DeckId Deck) :<|>
     Protected :> Capture "deck_id" DeckId :> Delete '[JSON] ()
-    -- Capture "deck_id" DeckId :> "slides" :> SlidesAPI
 
 newtype DeckId = DeckId { unDeckId :: T.Text }
   deriving newtype (Aeson.FromJSON, Aeson.ToJSON, FromHttpApiData, ToHttpApiData, Show, Eq)
@@ -234,9 +233,6 @@ instance ToParamSchema DeckId where
 -- SLIDES
 
 type SlidesAPI =
-
-      -- Protected :> Capture "deck_id" DeckId :> Delete '[JSON] ()
-    Protected :> Capture "deck_id" DeckId :> "slides" :> Get '[JSON] [Item SlideId Slide] :<|>
     Protected :> Capture "deck_id" DeckId :> "slides" :>
       Capture "slide_id" SlideId :> Get '[JSON] (Item SlideId Slide) :<|>
     Protected :> Capture "deck_id" DeckId :> "slides" :>
@@ -331,7 +327,6 @@ server env = serveUsers :<|> serveDecks :<|> serveSlides
       decksPut env :<|>
       decksDelete env
     serveSlides =
-      slidesGet env :<|>
       slidesGetSlideId env :<|>
       slidesPost env :<|>
       slidesPut env :<|>
@@ -633,33 +628,6 @@ getDeck env deckId = do
 
 -- SLIDES
 
-slidesGet :: Aws.Env -> Firebase.UserId -> DeckId -> Servant.Handler [Item SlideId Slide]
-slidesGet env fuid deckId = do
-
-    getDeck env deckId >>= \case
-      Nothing -> do
-        liftIO $ putStrLn $ unwords
-          [ "Trying to GET slides for", show deckId, "but deck doesn't exist." ]
-        Servant.throwError Servant.err404
-      Just deck@Deck{deckOwnerId, deckSlides} -> do
-        when (Firebase.unUserId fuid /= unFirebaseId (unUserId deckOwnerId)) $ do
-          liftIO $ putStrLn $ unwords $
-            [ "Slides were requested for ", show deck, "but requester is not the owner", show fuid ]
-          Servant.throwError Servant.err404
-
-    res <- runAWS env $ Aws.send $ DynamoDB.scan "Slides"
-    case res of
-      Right scanResponse ->
-        case sequence $ scanResponse ^. DynamoDB.srsItems <&> itemToSlide of
-          Nothing -> do
-            liftIO $ putStrLn $ "Could not parse respose: " <> show scanResponse
-            Servant.throwError Servant.err500
-          Just ids -> pure ids
-
-      Left e -> do
-        liftIO $ print e
-        Servant.throwError Servant.err500
-
 slidesGetSlideId :: Aws.Env -> Firebase.UserId -> DeckId -> SlideId -> Servant.Handler (Item SlideId Slide)
 slidesGetSlideId env _ _ slideId = do
     res <- runAWS env $ Aws.send $ DynamoDB.getItem "Slides" &