Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Commit 46c31ac

Browse files
feat: improve code attributes UX
1 parent 608c65c commit 46c31ac

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

studio/src/app/popovers/editor/app-code/app-code.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,13 @@ app-code {
1717
--highlight-color-focused: transparent;
1818

1919
ion-input {
20-
border-bottom: 1px solid var(--ion-color-medium);
20+
border-bottom: 1px solid rgba(0,0,0, 0.33);
2121
}
2222
}
23+
24+
ion-input[class*="sc-ion-input"] {
25+
--placeholder-opacity: 0.33;
26+
}
2327

2428
&.select {
2529
ion-label:first-of-type {

studio/src/app/popovers/editor/app-code/app-code.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export class AppCode {
3636
private currentLanguage: string = 'javascript';
3737
private languages: PrismLanguage[];
3838

39-
private codeColorType: CodeColorType = CodeColorType.COMMENTS;
39+
private codeColorType: CodeColorType;
4040

4141
@State()
4242
private codeColor: string;
@@ -274,9 +274,10 @@ export class AppCode {
274274
<ion-item-divider class="ion-padding-top"><ion-label>Colors</ion-label></ion-item-divider>
275275

276276
<ion-item class="select">
277-
<ion-label>Color applied to</ion-label>
277+
<ion-label>Apply color to</ion-label>
278278

279-
<ion-select value={this.codeColorType} onIonChange={(e: CustomEvent) => this.toggleColorType(e)} class="ion-padding-start ion-padding-end">
279+
<ion-select value={this.codeColorType} placeholder="Select a category"
280+
onIonChange={(e: CustomEvent) => this.toggleColorType(e)} class="ion-padding-start ion-padding-end">
280281
<ion-select-option value={CodeColorType.COMMENTS}>Comments</ion-select-option>
281282
<ion-select-option value={CodeColorType.FUNCTION}>Functions</ion-select-option>
282283
<ion-select-option value={CodeColorType.KEYWORD}>Keywords</ion-select-option>
@@ -288,7 +289,7 @@ export class AppCode {
288289
</ion-select>
289290
</ion-item>
290291

291-
<ion-item>
292+
<ion-item disabled={!this.codeColorType}>
292293
<ion-label>Color</ion-label>
293294
<input type="color" value={this.codeColor} onChange={(e) => this.selectColor(e, this.setCodeColor)}></input>
294295
</ion-item>
@@ -306,7 +307,7 @@ export class AppCode {
306307
onIonChange={() => this.highlightSelectedLines()}></ion-input>
307308
</ion-item>
308309

309-
<ion-item>
310+
<ion-item disabled={!this.highlightLines}>
310311
<ion-label>Color</ion-label>
311312
<input type="color" value={this.highlightColor} onChange={(e) => this.selectColor(e, this.setHighlightColor)}></input>
312313
</ion-item>

0 commit comments

Comments
 (0)