feat: don't display help first time the editor is accessed (testusers behavior feedback)

Author: peterpeterparker

studio/src/app/components/editor/actions/app-editor-actions/app-editor-actions.tsx

@@ -1,4 +1,4 @@
-import {Component, Element, Event, EventEmitter, h, Listen, Method, Prop} from '@stencil/core';
+import {Component, Element, Event, EventEmitter, h, Listen, Prop} from '@stencil/core';
 import {OverlayEventDetail} from '@ionic/core';
 
 import {get, set} from 'idb-keyval';
@@ -49,18 +49,6 @@ export class AppEditorActions {
         this.anonymousService = AnonymousService.getInstance();
     }
 
-    @Method()
-    displayHelp(): Promise<void> {
-        return new Promise<void>(async (resolve) => {
-            const help: HTMLElement = this.el.querySelector('app-help-action');
-            if (help) {
-                await (help as any).displayHelp();
-            }
-
-            resolve();
-        });
-    }
-
     async onActionOpenSlideAdd($event: CustomEvent) {
         if (!$event || !$event.detail) {
             return;

studio/src/app/components/editor/actions/app-help-action/app-help-action.tsx

@@ -1,6 +1,4 @@
-import {Component, h, Element, Method} from '@stencil/core';
-
-import {get, set} from 'idb-keyval';
+import {Component, h, Element} from '@stencil/core';
 
 import {IonControllerUtils} from '../../../../utils/core/ion-controller-utils';
 
@@ -11,30 +9,13 @@ export class AppHelpAction {
 
     @Element() el: HTMLElement;
 
-    @Method()
-    async displayHelp() {
-        const helpDisplayedOnce: boolean = await get<boolean>('deckdeckgo_display_help');
-
-        if (!helpDisplayedOnce) {
-            const button: HTMLIonTabButtonElement = this.el.querySelector('ion-tab-button.get-help-action');
-
-            if (button) {
-                button.click();
-            }
-        }
-    }
-
     private async openGetHelp() {
         const popover: HTMLIonPopoverElement = await IonControllerUtils.createPopover({
             component: 'app-get-help',
             mode: 'ios',
             cssClass: 'info'
         });
 
-        popover.onDidDismiss().then(async () => {
-            await set('deckdeckgo_display_help', true);
-        });
-
         await popover.present();
     }
 

studio/src/app/pages/editor/app-editor/app-editor.tsx

@@ -133,8 +133,6 @@ export class AppEditor {
             this.slidesEditable = true;
 
             await this.contentEditable(slide);
-
-            await this.showHelp();
         });
 
         this.fullscreen = DeckDeckGoUtils.isFullscreen();
@@ -453,18 +451,6 @@ export class AppEditor {
         });
     }
 
-    private showHelp(): Promise<void> {
-        return new Promise<void>(async (resolve) => {
-           const actions: HTMLElement = this.el.querySelector('app-editor-actions');
-
-           if (actions) {
-               await (actions as any).displayHelp();
-           }
-
-           resolve();
-        });
-    }
-
     private stickyToolbarActivated($event: CustomEvent) {
         this.hideFooterActions = $event ? $event.detail : false;
         this.hideNavigation = $event ? DeckDeckGoUtils.isIOS() && $event.detail : false;

studio/src/components.d.ts

@@ -43,7 +43,6 @@ export namespace Components {
     'deckId': string;
   }
   interface AppEditorActions {
-    'displayHelp': () => Promise<void>;
     'fullscreen': boolean;
     'hideFooterActions': boolean;
     'slides': any[];
@@ -68,9 +67,7 @@ export namespace Components {
   interface AppFullscreenInfo {}
   interface AppGetHelp {}
   interface AppGif {}
-  interface AppHelpAction {
-    'displayHelp': () => Promise<void>;
-  }
+  interface AppHelpAction {}
   interface AppHome {}
   interface AppImage {
     'deckOrSlide': boolean;