Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Commit 8f0330f

Browse files
Merge pull request #776 from deckgo/feed-three-slides
feat: at least four slides to appear in feed
2 parents e64429c + 4399d30 commit 8f0330f

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

studio/src/app/services/editor/anonymous/anonymous.service.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import authStore from '../../../stores/auth.store';
22

3+
import {Resources} from '../../../utils/core/resources';
4+
35
export class AnonymousService {
46
private static instance: AnonymousService;
57

@@ -31,7 +33,7 @@ export class AnonymousService {
3133
return;
3234
}
3335

34-
resolve(slides.length < 3);
36+
resolve(slides.length < Resources.Constants.DECK.MIN_SLIDES);
3537
});
3638
}
3739

studio/src/app/services/editor/publish/publish.service.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ import {Deck, DeckMetaAuthor} from '../../../models/data/deck';
99
import {ApiDeck} from '../../../models/api/api.deck';
1010
import {Slide, SlideAttributes, SlideTemplate} from '../../../models/data/slide';
1111

12+
import {Resources} from '../../../utils/core/resources';
13+
1214
import {ApiPresentation} from '../../../models/api/api.presentation';
1315
import {ApiSlide} from '../../../models/api/api.slide';
1416

@@ -380,19 +382,22 @@ export class PublishService {
380382
const url: URL = new URL(publishedUrl);
381383
const now: firebase.firestore.Timestamp = firebase.firestore.Timestamp.now();
382384

385+
const feed: boolean = deck.data.slides && deck.data.slides.length > Resources.Constants.DECK.MIN_SLIDES;
386+
383387
if (!deck.data.meta) {
384388
deck.data.meta = {
385389
title: deck.data.name,
386390
pathname: url.pathname,
387391
published: true,
388392
published_at: now,
389-
feed: true,
393+
feed: feed,
390394
updated_at: now,
391395
};
392396
} else {
393397
deck.data.meta.title = deck.data.name;
394398
deck.data.meta.pathname = url.pathname;
395399
deck.data.meta.updated_at = now;
400+
deck.data.meta.feed = feed;
396401
}
397402

398403
if (description && description !== undefined && description !== '') {

studio/src/app/utils/core/resources.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ export class Resources {
33
return {
44
DECK: {
55
TITLE_MAX_LENGTH: 45,
6-
DESCRIPTION_MAX_LENGTH: 500
6+
DESCRIPTION_MAX_LENGTH: 500,
7+
MIN_SLIDES: 3,
78
},
89
STORAGE: {
9-
MAX_QUERY_RESULTS: 20
10-
}
10+
MAX_QUERY_RESULTS: 20,
11+
},
1112
};
1213
}
1314
}

0 commit comments

Comments
 (0)