Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Commit 90df088

Browse files
refactor: rename slideStart to slideDidChange
1 parent cd56d20 commit 90df088

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

doc/features/extra.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ await deck.print();
3737

3838
| Event | Emitted value | Description |
3939
| -------------------------- |:-----------------:|:-----------------:|
40-
| slideNextStart | number | Emitted when the next slide has started. Emit the index of the new active slide. |
41-
| slidePrevStart | number | Emitted when the previous slide has ended. Emit the index of the new active slide. |
40+
| slideNextDidChange | number | Emitted when the next slide has started. Emit the index of the new active slide. |
41+
| slidePrevDidChange | number | Emitted when the previous slide has ended. Emit the index of the new active slide. |
4242
| slideDrag | number | Emitted when the slider is actively being moved. Emit the transformX value of the deck. |
4343
| slideWillChange | number | Emitted before the active slide has changed. Emit the transformX value of the deck. |
4444

doc/features/navigation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const deck = document.getElementsByTagName('deckgo-deck');
3232
await deck.slideNext();
3333
```
3434

35-
*Optional parameter:* Optionally your could provide a boolean parameter to this method in case you would not like the event `slideNextStart` and `slidePrevStart` to be fired.
35+
*Optional parameter:* Optionally your could provide a boolean parameter to this method in case you would not like the event `slideNextDidChange` and `slidePrevDidChange` to be fired.
3636

3737
```
3838
await deck.slideNext(false);
@@ -44,7 +44,7 @@ await deck.slideNext(false);
4444
await deck.slidePrev();
4545
```
4646

47-
*Optional parameter:* Optionally your could provide a boolean parameter to this method in case you would not like the event `slideNextStart` and `slidePrevStart` to be fired.
47+
*Optional parameter:* Optionally your could provide a boolean parameter to this method in case you would not like the event `slideNextDidChange` and `slidePrevDidChange` to be fired.
4848

4949
```
5050
await deck.slidePrev(false);

src/components/deck/deckdeckgo-deck/deckdeckgo-deck.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ export class DeckdeckgoDeck {
3434
@State()
3535
private length: number = 0;
3636

37-
@Event() slideNextStart: EventEmitter<number>;
38-
@Event() slidePrevStart: EventEmitter<number>;
37+
@Event() slideNextDidChange: EventEmitter<number>;
38+
@Event() slidePrevDidChange: EventEmitter<number>;
3939
@Event() slideDrag: EventEmitter<number>;
4040
@Event() slideWillChange: EventEmitter<number>;
4141

@@ -174,13 +174,13 @@ export class DeckdeckgoDeck {
174174
this.activeIndex++;
175175

176176
if (emitEvent) {
177-
this.slideNextStart.emit(this.activeIndex);
177+
this.slideNextDidChange.emit(this.activeIndex);
178178
}
179179
} else {
180180
this.activeIndex--;
181181

182182
if (emitEvent) {
183-
this.slidePrevStart.emit(this.activeIndex);
183+
this.slidePrevDidChange.emit(this.activeIndex);
184184
}
185185
}
186186
}

0 commit comments

Comments
 (0)