feat(#115): reflect lineNumbers to attributes for studio and default value to false

Author: peterpeterparker

webcomponents/highlight-code/src/components.d.ts

@@ -10,6 +10,7 @@ import {
   DeckdeckgoHighlightCodeAnchor,
 } from './components/declarations/deckdeckgo-highlight-code-anchor';
 
+
 export namespace Components {
   interface DeckgoHighlightCode {
     'anchor': string;

webcomponents/highlight-code/src/components/highlight-code/deckdeckgo-highlight-code.tsx

@@ -25,7 +25,7 @@ export class DeckdeckgoHighlightCode {
   @Prop({ reflectToAttr: true }) language: string = 'javascript';
 
   @Prop({ reflectToAttr: true }) highlightLines: string;
-  @Prop() lineNumbers: boolean = true;
+  @Prop({ reflectToAttr: true }) lineNumbers: boolean = false;
 
   @Prop() editable: boolean = false;
 

webcomponents/highlight-code/src/components/highlight-code/readme.md

@@ -15,7 +15,7 @@
 | `hideAnchor`     | `hide-anchor`     |             | `boolean` | `true`                |
 | `highlightLines` | `highlight-lines` |             | `string`  | `undefined`           |
 | `language`       | `language`        |             | `string`  | `'javascript'`        |
-| `lineNumbers`    | `line-numbers`    |             | `boolean` | `true`                |
+| `lineNumbers`    | `line-numbers`    |             | `boolean` | `false`               |
 | `src`            | `src`             |             | `string`  | `undefined`           |
 
 

webcomponents/highlight-code/src/index.html

@@ -13,7 +13,7 @@
 
 <h1>Editable:</h1>
 
-<deckgo-highlight-code language="java" editable="true" highlight-lines="0,2 6,6">
+<deckgo-highlight-code language="java" editable="true" highlight-lines="0,2 6,6" line-numbers="true">
   <code slot="code">interface NumericTest {
     boolean computeTest(int n);
     }
@@ -38,12 +38,12 @@ <h1>Editable empty:</h1>
 
 <h1>From src:</h1>
 
-<deckgo-highlight-code src="https://raw.githubusercontent.com/deckgo/deckdeckgo/master/webcomponents/core/src/components/deck/deckdeckgo-deck/deckdeckgo-deck.tsx">
+<deckgo-highlight-code line-numbers="true" src="https://raw.githubusercontent.com/deckgo/deckdeckgo/master/webcomponents/core/src/components/deck/deckdeckgo-deck/deckdeckgo-deck.tsx">
 </deckgo-highlight-code>
 
 <h1>Typescript</h1>
 
-<deckgo-highlight-code language="typescript" highlight-lines="1,1" style="--deckgo-highlight-code-line-background: lightgrey;">
+<deckgo-highlight-code language="typescript" highlight-lines="1,1" line-numbers="true" style="--deckgo-highlight-code-line-background: lightgrey;">
   <code slot="code">@Method()
 isMobile(): Promise&lt;boolean> {
   return new Promise&lt;boolean>((resolve) => {
@@ -71,7 +71,7 @@ <h1>Plain code and java language:</h1>
     }</code>
 </deckgo-highlight-code>
 
-<deckgo-highlight-code language="bash">
+<deckgo-highlight-code language="bash" line-numbers="true">
   <code slot="code">npm init deckdeckgo</code>
 </deckgo-highlight-code>
 
@@ -88,7 +88,7 @@ <h1>Plain code and java language:</h1>
 </deckgo-highlight-code>
 
 <h1>Without line numbers</h1>
-<deckgo-highlight-code language="java" line-numbers="false" highlight-lines="0,2 6,6">
+<deckgo-highlight-code language="java" highlight-lines="0,2 6,6">
   <code slot="code">interface NumericTest {
     boolean computeTest(int n);
     }