Merge pull request #656 from ble/fix-rotation-jump

peterpeterparker · web-flow · commit a7a59a56cb3f · 2020-03-03T21:02:08.000+01:00
Fix #655: Calculate center for element correctly
diff --git a/webcomponents/drag-resize-rotate/src/components/deckdeckgo-drr.tsx b/webcomponents/drag-resize-rotate/src/components/deckdeckgo-drr.tsx
@@ -214,8 +214,9 @@ export class DeckdeckgoDragResizeRotate {
   }
 
   private initStartPositionsRotation() {
-    this.centerX = this.el.getBoundingClientRect().left + this.el.offsetWidth / 2;
-    this.centerY = this.el.getBoundingClientRect().top + this.el.offsetHeight / 2;
+    let rect = this.el.getBoundingClientRect();
+    this.centerX = rect.left + rect.width / 2;
+    this.centerY = rect.top + rect.height / 2;
   }
 
   private initStartPositionsResize() {

Original file line number	Diff line number	Diff line change
`@@ -214,8 +214,9 @@ export class DeckdeckgoDragResizeRotate {`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`private initStartPositionsRotation() {`
`217`		`- this.centerX = this.el.getBoundingClientRect().left + this.el.offsetWidth / 2;`
`218`		`- this.centerY = this.el.getBoundingClientRect().top + this.el.offsetHeight / 2;`
	`217`	`+ let rect = this.el.getBoundingClientRect();`
	`218`	`+ this.centerX = rect.left + rect.width / 2;`
	`219`	`+ this.centerY = rect.top + rect.height / 2;`
`219`	`220`	`}`
`220`	`221`
`221`	`222`	`private initStartPositionsResize() {`