feat: remove deck settings modal

Author: peterpeterparker

studio/src/app/modals/editor/app-deck-settings/app-deck-settings.scss

@@ -3,24 +3,22 @@ import {OverlayEventDetail} from '@ionic/core';
 
 import {filter, take} from 'rxjs/operators';
 
-
-import {CreateSlidesUtils} from '../../../utils/editor/create-slides.utils';
-
 import {AuthUser} from '../../../models/auth-user';
 import {Slide, SlideTemplate} from '../../../models/slide';
 import {Deck} from '../../../models/deck';
 
+import {CreateSlidesUtils} from '../../../utils/editor/create-slides.utils';
 import {ParseStyleUtils} from '../../../utils/editor/parse-style.utils';
 
 import {DeckEventsHandler} from '../../../handlers/editor/deck-events/deck-events.handler';
 
+import {EditorHelper} from '../../../helpers/editor/editor.helper';
+
 import {AuthService} from '../../../services/auth/auth.service';
 import {GuestService} from '../../../services/guest/guest.service';
 import {NavDirection, NavService} from '../../../services/nav/nav.service';
-
-import {EditorHelper} from '../../../helpers/editor/editor.helper';
-import {DeckAction} from '../../../popovers/editor/app-deck-actions/deck-action';
 import {DeckEditorService} from '../../../services/deck/deck-editor.service';
+import {DeckAction} from '../../../popovers/editor/app-deck-actions/deck-action';
 
 @Component({
     tag: 'app-editor',
@@ -545,27 +543,13 @@ export class AppEditor {
                     await this.toggleFullScreen();
                 } else if (detail.data.action === DeckAction.JUMP_TO) {
                     await this.openSlideNavigate();
-                } else if (detail.data.action === DeckAction.SETTINGS) {
-                    await this.openDeckSettings();
                 }
             }
         });
 
         await popover.present();
     }
 
-    async openDeckSettings() {
-        const modal: HTMLIonModalElement = await this.modalController.create({
-            component: 'app-deck-settings'
-        });
-
-        modal.onDidDismiss().then(async (_detail: OverlayEventDetail) => {
-            // Nothing special
-        });
-
-        await modal.present();
-    }
-
     render() {
         return [
             <app-navigation publish={true}></app-navigation>,
@@ -605,11 +589,6 @@ export class AppEditor {
                             <ion-label>Fullscreen</ion-label>
                         </ion-tab-button>
 
-                        <ion-tab-button onClick={() => this.openDeckSettings()} color="primary" class="wider-devices">
-                            <ion-icon name="settings"></ion-icon>
-                            <ion-label>Settings</ion-label>
-                        </ion-tab-button>
-
                         <ion-tab-button onClick={(e: UIEvent) => this.openDeckActions(e)} color="primary" class="small-devices">
                             <ion-icon md="md-more" ios="md-more"></ion-icon>
                             <ion-label>More</ion-label>

studio/src/app/modals/editor/app-deck-settings/app-deck-settings.tsx

@@ -17,10 +17,11 @@ export class AppDeckActions {
     }
 
     render() {
+        // TODO: Share when published
+
         return <div padding>
             <a onClick={() => this.closePopover(DeckAction.JUMP_TO)}><p>Jump to slide</p></a>
             <a onClick={() => this.closePopover(DeckAction.FULLSCREEN)}><p>Fullscreen</p></a>
-            <a onClick={() => this.closePopover(DeckAction.SETTINGS)}><p>Settings</p></a>
         </div>
     }
 }

studio/src/app/pages/editor/app-editor/app-editor.tsx

@@ -1,5 +1,4 @@
 export enum DeckAction {
-    SETTINGS,
     FULLSCREEN,
     JUMP_TO
 }

studio/src/app/popovers/editor/app-deck-actions/app-deck-actions.tsx

@@ -8,9 +8,9 @@
 import '@stencil/core';
 
 import '@ionic/core';
+import 'ionicons';
 import 'deckdeckgo';
 import 'deckdeckgo-inline-editor';
-import 'ionicons';
 import {
   EventEmitter,
 } from '@stencil/core';
@@ -114,9 +114,6 @@ export namespace Components {
   interface AppFeedLazyImg {}
   interface AppFeedLazyImgAttributes extends StencilHTMLAttributes {}
 
-  interface AppDeckSettings {}
-  interface AppDeckSettingsAttributes extends StencilHTMLAttributes {}
-
   interface AppGif {}
   interface AppGifAttributes extends StencilHTMLAttributes {}
 
@@ -210,7 +207,6 @@ declare global {
     'AppPopular': Components.AppPopular;
     'AppFeedCard': Components.AppFeedCard;
     'AppFeedLazyImg': Components.AppFeedLazyImg;
-    'AppDeckSettings': Components.AppDeckSettings;
     'AppGif': Components.AppGif;
     'AppPublish': Components.AppPublish;
     'AppSlideNavigate': Components.AppSlideNavigate;
@@ -246,7 +242,6 @@ declare global {
     'app-popular': Components.AppPopularAttributes;
     'app-feed-card': Components.AppFeedCardAttributes;
     'app-feed-lazy-img': Components.AppFeedLazyImgAttributes;
-    'app-deck-settings': Components.AppDeckSettingsAttributes;
     'app-gif': Components.AppGifAttributes;
     'app-publish': Components.AppPublishAttributes;
     'app-slide-navigate': Components.AppSlideNavigateAttributes;
@@ -352,12 +347,6 @@ declare global {
     new (): HTMLAppFeedLazyImgElement;
   };
 
-  interface HTMLAppDeckSettingsElement extends Components.AppDeckSettings, HTMLStencilElement {}
-  var HTMLAppDeckSettingsElement: {
-    prototype: HTMLAppDeckSettingsElement;
-    new (): HTMLAppDeckSettingsElement;
-  };
-
   interface HTMLAppGifElement extends Components.AppGif, HTMLStencilElement {}
   var HTMLAppGifElement: {
     prototype: HTMLAppGifElement;
@@ -481,7 +470,6 @@ declare global {
     'app-popular': HTMLAppPopularElement
     'app-feed-card': HTMLAppFeedCardElement
     'app-feed-lazy-img': HTMLAppFeedLazyImgElement
-    'app-deck-settings': HTMLAppDeckSettingsElement
     'app-gif': HTMLAppGifElement
     'app-publish': HTMLAppPublishElement
     'app-slide-navigate': HTMLAppSlideNavigateElement
@@ -517,7 +505,6 @@ declare global {
     'app-popular': HTMLAppPopularElement;
     'app-feed-card': HTMLAppFeedCardElement;
     'app-feed-lazy-img': HTMLAppFeedLazyImgElement;
-    'app-deck-settings': HTMLAppDeckSettingsElement;
     'app-gif': HTMLAppGifElement;
     'app-publish': HTMLAppPublishElement;
     'app-slide-navigate': HTMLAppSlideNavigateElement;