fix: compare Firestore delete

peterpeterparker · peterpeterparker · commit b8e053617012 · 2020-11-28T14:11:09.000+01:00
diff --git a/studio/src/app/utils/editor/firestore.utils.tsx b/studio/src/app/utils/editor/firestore.utils.tsx
@@ -1,3 +1,6 @@
+import firebase from 'firebase/app';
+import 'firebase/firestore';
+
 export class FirestoreUtils {
   static filterDelete<T>(obj: T, replaceWithNull: boolean = false): T {
     if (typeof obj !== 'object' || Array.isArray(obj)) {
@@ -30,10 +33,6 @@ export class FirestoreUtils {
       return false;
     }
 
-    const firestoreDelete = Object.keys(attr).find((key: string) => {
-      return attr[key] === 'FieldValue.delete';
-    });
-
-    return firestoreDelete !== null && firestoreDelete !== undefined;
+    return JSON.stringify(attr) === JSON.stringify(firebase.firestore.FieldValue.delete());
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,6 @@`
	`1`	`+import firebase from 'firebase/app';`
	`2`	`+import 'firebase/firestore';`
	`3`	`+`
`1`	`4`	`export class FirestoreUtils {`
`2`	`5`	`static filterDelete<T>(obj: T, replaceWithNull: boolean = false): T {`
`3`	`6`	`if (typeof obj !== 'object' \|\| Array.isArray(obj)) {`
`@@ -30,10 +33,6 @@ export class FirestoreUtils {`
`30`	`33`	`return false;`
`31`	`34`	`}`
`32`	`35`
`33`		`- const firestoreDelete = Object.keys(attr).find((key: string) => {`
`34`		`- return attr[key] === 'FieldValue.delete';`
`35`		`- });`
`36`		`-`
`37`		`- return firestoreDelete !== null && firestoreDelete !== undefined;`
	`36`	`+ return JSON.stringify(attr) === JSON.stringify(firebase.firestore.FieldValue.delete());`
`38`	`37`	`}`
`39`	`38`	`}`