Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Commit d477777

Browse files
feat: slide gif per default fullscreen
1 parent 772d120 commit d477777

File tree

7 files changed

+13
-6
lines changed

7 files changed

+13
-6
lines changed

docs/docs/slides/app-slide-gif/app-slide-gif.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ This component offers the following options which could be set using attributes:
6363
| -------------------------- |-----------------|-----------------|-----------------|
6464
| src | string | | The source url, the src, of the Gif. Could be an embeddable external url or a local one. |
6565
| alt | string | | And alt information could be provided for accessibility reason. |
66-
| fullscreen | number | false | If set to true, the gif width and height will be related to the slide width and height respectively will be fullscreen. |
66+
| fullscreen | number | true | If set to true, the gif width and height will be related to the slide width and height respectively will be fullscreen. |
6767

6868
## Theming
6969

docs/src/app/pages/docs/slides/app-slide-gif/app-slide-gif.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export class AppSlideGif {
9494
<tr>
9595
<td>fullscreen</td>
9696
<td>number</td>
97-
<td>false</td>
97+
<td>true</td>
9898
<td>If set to true, the gif width and height will be related to the slide width and height respectively will be fullscreen.</td>
9999
</tr>
100100
</tbody></table>

studio/src/app/popovers/editor/app-slide-type/app-slide-type.scss

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,13 @@ app-slide-type {
7676
font-size: 0.2rem;
7777
}
7878
}
79+
80+
deckgo-slide-gif {
81+
p {
82+
min-height: inherit;
83+
width: inherit;
84+
}
85+
}
7986
}
8087

8188
div.swipe {

studio/src/app/popovers/editor/app-slide-type/app-slide-type.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export class AppSlideType {
6363
</deckgo-slide-split>
6464
</div>
6565
<div class="item" custom-tappable onClick={() => this.addSlide(SlideTemplate.GIF)}>
66-
<deckgo-slide-gif src="./assets/img/example.gif" alt="Slide Gif" fullscreen={true}>
66+
<deckgo-slide-gif src="./assets/img/example.gif" alt="Slide Gif">
6767
<p slot="footer" style={{"font-size": "var(--font-size-very-small)", padding: "2px", "border-radius": "4px"}}>GIFs</p>
6868
</deckgo-slide-gif>
6969
</div>

studio/src/app/utils/editor-utils.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export class EditorUtils {
121121
{this.DEFAULT_CAPTION}
122122
</h2>;
123123

124-
const slide: any = <deckgo-slide-gif src="./assets/img/example.gif" fullscreen={true}>
124+
const slide: any = <deckgo-slide-gif src="./assets/img/example.gif">
125125
{title}
126126
{content}
127127
</deckgo-slide-gif>;

webcomponents/core/src/components/slides/deckdeckgo-slide-gif/deckdeckgo-slide-gif.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export class DeckdeckgoSlideGif implements DeckdeckgoSlide {
1717
@Prop() src: string;
1818
@Prop() alt: string;
1919

20-
@Prop() fullscreen: boolean = false;
20+
@Prop() fullscreen: boolean = true;
2121

2222
@State() loaded: boolean = false;
2323

webcomponents/core/src/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ <h2>David Dal Busco</h2>
4242
<div slot="social-link"><deckgo-social full-url="https://stackoverflow.com/users/5404186/peter-parker">stackoverflow</deckgo-social></div>
4343
</deckgo-slide-author>
4444

45-
<deckgo-slide-gif src="https://media.giphy.com/media/xUA7baWfTjfHGLZc3e/giphy.gif" alt="My title" fullscreen="true">
45+
<deckgo-slide-gif src="https://media.giphy.com/media/xUA7baWfTjfHGLZc3e/giphy.gif" alt="My title">
4646
<h1 slot="title">Gif</h1>
4747
<h1 slot="header">Hey Sani</h1>
4848
<h2 slot="footer" style="--background: white; --color: blue;">Cool?</h2>

0 commit comments

Comments
 (0)