fix: decks pwa screenshot size

peterpeterparker · web-flow · commit dac59ee58aa1 · 2021-04-03T09:37:20.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -26,9 +26,9 @@
 - cli: v2.2.1 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/cli/CHANGELOG.md))
 - cloud: v2.2.0 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/cloud/CHANGELOG.md))
 - deck-utils: v3.4.1 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/utils/deck/CHANGELOG.md))
-- kit: v3.0.0 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/kit/CHANGELOG.md))
+- kit: v3.0.1 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/kit/CHANGELOG.md))
 - starter kit: v8.0.0 ([CHANGELOG](https://github.com/deckgo/starter-kit/blob/master/CHANGELOG.md))
-- studio kit: v8.0.0 ([CHANGELOG](https://github.com/deckgo/studio-kit/blob/master/CHANGELOG.md))
+- studio kit: v8.0.1 ([CHANGELOG](https://github.com/deckgo/studio-kit/blob/master/CHANGELOG.md))
 
 <a name="4.4.0"></a>
 
diff --git a/README.md b/README.md
@@ -142,7 +142,7 @@ If you like the project, you can become a sponsor at [Open Collective](https://o
 | **Gatsby plugin highlight code** |                                                                                          | [![version](https://img.shields.io/npm/v/gatsby-remark-highlight-code/latest.svg?color=success)](https://www.npmjs.com/package/gatsby-remark-highlight-code) | [`Repo`](https://github.com/deckgo/gatsby-remark-highlight-code/) | [`CHANGELOG`](https://github.com/deckgo/gatsby-remark-highlight-code/blob/master/CHANGELOG.md) |
 | **Infrastructure**               |                                                                                          |                                                                                                                                                              |                    [`README`](infra/README.md)                    |                                                                                                |
 | **Starter kit**                  |                                                                                          | ![version](https://img.shields.io/static/v1.svg?label=version&message=v8.0.0&color=success)                                                                  |          [`Repo`](http://github.com/deckgo/starter-kit/)          |         [`CHANGELOG`](https://github.com/deckgo/starter-kit/blob/master/CHANGELOG.md)          |
-| **Studio kit**                   |                                                                                          | ![version](https://img.shields.io/static/v1.svg?label=version&message=v8.0.0&color=success)                                                                  |          [`Repo`](http://github.com/deckgo/studio-kit/)           |          [`CHANGELOG`](https://github.com/deckgo/studio-kit/blob/master/CHANGELOG.md)          |
+| **Studio kit**                   |                                                                                          | ![version](https://img.shields.io/static/v1.svg?label=version&message=v8.0.1&color=success)                                                                  |          [`Repo`](http://github.com/deckgo/studio-kit/)           |          [`CHANGELOG`](https://github.com/deckgo/studio-kit/blob/master/CHANGELOG.md)          |
 | **Template kit**                 |                                                                                          | ![version](https://img.shields.io/static/v1.svg?label=version&message=v1.0.0&color=success)                                                                  |         [`Repo`](http://github.com/deckgo/template-kit/)          |         [`CHANGELOG`](https://github.com/deckgo/template-kit/blob/master/CHANGELOG.md)         |
 | **WAI Lambda**                   |                                                                                          |                                                                                                                                                              |          [`Repo`](https://github.com/deckgo/wai-lambda)           |                                                                                                |
 | **Webpack plugins**              | [`deckdeckgo-webpack-plugins`](https://www.npmjs.com/package/deckdeckgo-webpack-plugins) | [![version](https://img.shields.io/npm/v/deckdeckgo-webpack-plugins/latest.svg?color=success)](https://www.npmjs.com/package/deckdeckgo-webpack-plugins)     |                   [`README`](webpack/README.md)                   |                              [`CHANGELOG`](webpack/CHANGELOG.md)                               |
diff --git a/utils/kit/CHANGELOG.md b/utils/kit/CHANGELOG.md
@@ -1,3 +1,9 @@
+# 3.0.1 (2021-04-03)
+
+### Fix
+
+- full deck size whe a screenshot is taken 
+
 # 3.0.0 (2021-03-28)
 
 ### Breaking
diff --git a/utils/kit/package-lock.json b/utils/kit/package-lock.json
diff --git a/utils/kit/package.json b/utils/kit/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@deckdeckgo/kit",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "author": "David Dal Busco",
   "description": "Functions, utils and styles for the DeckDeckGo presentations created with the kits",
   "license": "MIT",
diff --git a/utils/kit/src/loading/loading.ts b/utils/kit/src/loading/loading.ts
@@ -1,5 +1,6 @@
 import {initEmbedded} from '../embed/embedded';
 import { initSize } from "../size/size";
+import { isScreenshot } from "../utils/utils.deck";
 
 export const postLoading = async () => {
   const app = document.querySelector('ion-app');
@@ -18,10 +19,7 @@ async function initSreenshot() {
     return;
   }
 
-  const url = new URL(window.location.href);
-  const screenshot = url && url.searchParams ? url.searchParams.has('screenshot') : false;
-
-  if (screenshot) {
+  if (isScreenshot()) {
     const menu: HTMLElement | null = document.querySelector('#fullscreen-menu');
 
     if (menu) {
diff --git a/utils/kit/src/size/size.ts b/utils/kit/src/size/size.ts
@@ -1,4 +1,4 @@
-import {isPapyrus} from '../utils/utils.deck';
+import { isPapyrus, isScreenshot } from "../utils/utils.deck";
 import { isFullscreen } from "@deckdeckgo/utils";
 
 interface Size {
@@ -49,7 +49,7 @@ const initMainSize = async () => {
     return;
   }
 
-  if (EMBEDDED || isPapyrus(deck) || isFullscreen()) {
+  if (EMBEDDED || isPapyrus(deck) || isFullscreen() || isScreenshot()) {
     defaultSize(main);
   } else {
     aspectRatioSize({content, main});
diff --git a/utils/kit/src/utils/utils.deck.ts b/utils/kit/src/utils/utils.deck.ts
@@ -9,3 +9,8 @@ export function isVertical(deck: HTMLDeckgoDeckElement): boolean {
   const mobile = isMobile();
   return (deck.direction === 'vertical' && !mobile) || (deck.directionMobile === 'vertical' && mobile);
 }
+
+export function isScreenshot(): boolean {
+  const url: URL | undefined = new URL(window?.location?.href);
+  return url && url.searchParams ? url.searchParams.has('screenshot') : false;
+}

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@deckdeckgo/kit",`
`3`		`- "version": "3.0.0",`
	`3`	`+ "version": "3.0.1",`
`4`	`4`	`"author": "David Dal Busco",`
`5`	`5`	`"description": "Functions, utils and styles for the DeckDeckGo presentations created with the kits",`
`6`	`6`	`"license": "MIT",`
Original file line number	Diff line number	Diff line change
`@@ -9,3 +9,8 @@ export function isVertical(deck: HTMLDeckgoDeckElement): boolean {`
`9`	`9`	`const mobile = isMobile();`
`10`	`10`	`return (deck.direction === 'vertical' && !mobile) \|\| (deck.directionMobile === 'vertical' && mobile);`
`11`	`11`	`}`
	`12`	`+`
	`13`	`+export function isScreenshot(): boolean {`
	`14`	`+ const url: URL \| undefined = new URL(window?.location?.href);`
	`15`	`+ return url && url.searchParams ? url.searchParams.has('screenshot') : false;`
	`16`	`+}`