lint

ldmonster · ldmonster · commit f540a463c158 · 2026-01-26T17:58:23.000+03:00
Signed-off-by: Pavel Okhlopkov &lt;pavel.okhlopkov@flant.com&gt;
diff --git a/internal/metrics/storage.go b/internal/metrics/storage.go
@@ -193,7 +193,7 @@ func (m *metricStorage) registerHistogram(metric string, labels map[string]strin
 
 // labelNames returns sorted label keys
 func labelNames(labels map[string]string) []string {
-	names := make([]string, 0)
+	names := make([]string, 0, len(labels))
 	for labelName := range labels {
 		names = append(names, labelName)
 	}
diff --git a/internal/module/module.go b/internal/module/module.go
@@ -201,8 +201,8 @@ func mapContainerRules(linterSettings *pkg.LintersSettings, configSettings *conf
 		globalConfig.Container.Rules.NamespaceLabelsRule.Impact,
 		configSettings.Container.Impact,
 	)
-	linterSettings.Container.Rules.ApiVersionRule.SetLevel(
-		globalConfig.Container.Rules.ApiVersionRule.Impact,
+	linterSettings.Container.Rules.APIVersionRule.SetLevel(
+		globalConfig.Container.Rules.APIVersionRule.Impact,
 		configSettings.Container.Impact,
 	)
 	linterSettings.Container.Rules.PriorityClassRule.SetLevel(
diff --git a/internal/promremote/convert.go b/internal/promremote/convert.go
@@ -44,11 +44,12 @@ func ConvertMetric(metric prometheus.Metric, name string) TimeSeries {
 	var value float64
 	var timestamp time.Time
 
-	if dtoMetric.Gauge != nil {
+	switch {
+	case dtoMetric.Gauge != nil:
 		value = dtoMetric.Gauge.GetValue()
-	} else if dtoMetric.Counter != nil {
+	case dtoMetric.Counter != nil:
 		value = dtoMetric.Counter.GetValue()
-	} else if dtoMetric.Untyped != nil {
+	case dtoMetric.Untyped != nil:
 		value = dtoMetric.Untyped.GetValue()
 	}
 
diff --git a/internal/promremote/promremote.go b/internal/promremote/promremote.go
@@ -26,7 +26,7 @@ import (
 	"net/http"
 	"time"
 
-	"github.com/golang/protobuf/proto"
+	"github.com/golang/protobuf/proto" //nolint:staticcheck // Required for prompb compatibility
 	"github.com/golang/snappy"
 	"github.com/prometheus/prometheus/prompb"
 )
diff --git a/internal/promtool/checkrule.go b/internal/promtool/checkrule.go
@@ -53,14 +53,14 @@ func CheckRules(data []byte) error {
 	rgs, errs := rulefmt.Parse(data, ls.ignoreUnknownFields)
 	var ruleErrors, checkGroupErrors error
 	if errs != nil {
-		errStr := make([]string, len(errs))
+		errStr := make([]string, 0, len(errs))
 		for _, e := range errs {
 			errStr = append(errStr, e.Error())
 		}
 		ruleErrors = fmt.Errorf("%s", strings.Join(errStr, "\n"))
 	}
 	if errs := checkRuleGroups(rgs, ls); errs != nil {
-		errStr := make([]string, len(errs))
+		errStr := make([]string, 0, len(errs))
 		for _, e := range errs {
 			errStr = append(errStr, e.Error())
 		}
@@ -118,7 +118,7 @@ func compare(a, b compareRuleType) int {
 
 func checkDuplicates(groups []rulefmt.RuleGroup) []compareRuleType {
 	var duplicates []compareRuleType
-	var cRules compareRuleTypes
+	cRules := make(compareRuleTypes, 0, 100) // Preallocate with reasonable capacity
 
 	for _, group := range groups {
 		for _, rule := range group.Rules {
diff --git a/internal/storage/storage_test.go b/internal/storage/storage_test.go
@@ -199,7 +199,7 @@ func TestStoreObject_GetInitContainers(t *testing.T) {
 				require.Error(t, err)
 			} else {
 				require.NoError(t, err)
-				var containerNames []string
+				var containerNames []string //nolint:prealloc // Must return nil when no containers
 				for _, container := range initContainers {
 					containerNames = append(containerNames, container.Name)
 				}
@@ -283,7 +283,7 @@ func TestStoreObject_GetContainers(t *testing.T) {
 				require.Error(t, err)
 			} else {
 				require.NoError(t, err)
-				var containerNames []string
+				var containerNames []string //nolint:prealloc // Must return nil when no containers
 				for _, container := range containers {
 					containerNames = append(containerNames, container.Name)
 				}
@@ -387,7 +387,7 @@ func TestStoreObject_GetAllContainers(t *testing.T) {
 				require.Error(t, err)
 			} else {
 				require.NoError(t, err)
-				var containerNames []string
+				var containerNames []string //nolint:prealloc // Must return nil when no containers
 				for _, container := range allContainers {
 					containerNames = append(containerNames, container.Name)
 				}
diff --git a/pkg/config.go b/pkg/config.go
@@ -292,7 +292,7 @@ func (l PrefixRuleExcludeList) Get() []PrefixRuleExclude {
 type ContainerLinterRules struct {
 	RecommendedLabelsRule         RuleConfig
 	NamespaceLabelsRule           RuleConfig
-	ApiVersionRule                RuleConfig
+	APIVersionRule                RuleConfig
 	PriorityClassRule             RuleConfig
 	DNSPolicyRule                 RuleConfig
 	ControllerSecurityContextRule RuleConfig
diff --git a/pkg/config/global/global.go b/pkg/config/global/global.go
@@ -47,7 +47,7 @@ type ContainerLinterConfig struct {
 type ContainerRules struct {
 	RecommendedLabelsRule         RuleConfig `mapstructure:"recommended-labels"`
 	NamespaceLabelsRule           RuleConfig `mapstructure:"namespace-labels"`
-	ApiVersionRule                RuleConfig `mapstructure:"api-version"`
+	APIVersionRule                RuleConfig `mapstructure:"api-version"`
 	PriorityClassRule             RuleConfig `mapstructure:"priority-class"`
 	DNSPolicyRule                 RuleConfig `mapstructure:"dns-policy"`
 	ControllerSecurityContextRule RuleConfig `mapstructure:"controller-security-context"`
diff --git a/pkg/linters/container/rules.go b/pkg/linters/container/rules.go
@@ -29,7 +29,7 @@ func (l *Container) applyContainerRules(object storage.StoreObject, storageMap m
 
 	rules.NewRecommendedLabelsRule().ObjectRecommendedLabels(object, errorList.WithMaxLevel(l.cfg.Rules.RecommendedLabelsRule.GetLevel()))
 	rules.NewNamespaceLabelsRule().ObjectNamespaceLabels(object, storageMap, errorList.WithMaxLevel(l.cfg.Rules.NamespaceLabelsRule.GetLevel()))
-	rules.NewAPIVersionRule().ObjectAPIVersion(object, errorList.WithMaxLevel(l.cfg.Rules.ApiVersionRule.GetLevel()))
+	rules.NewAPIVersionRule().ObjectAPIVersion(object, errorList.WithMaxLevel(l.cfg.Rules.APIVersionRule.GetLevel()))
 	rules.NewPriorityClassRule().ObjectPriorityClass(object, errorList.WithMaxLevel(l.cfg.Rules.PriorityClassRule.GetLevel()))
 	rules.NewDNSPolicyRule(l.cfg.ExcludeRules.DNSPolicy.Get()).
 		ObjectDNSPolicy(object, errorList.WithMaxLevel(l.cfg.Rules.DNSPolicyRule.GetLevel()))
diff --git a/pkg/linters/module/rules/license_parser.go b/pkg/linters/module/rules/license_parser.go
@@ -406,7 +406,7 @@ func (*LicenseParser) normalizeText(text string) string {
 
 	// Remove common comment line prefixes
 	lines := strings.Split(text, "\n")
-	var normalized []string
+	normalized := make([]string, 0, len(lines))
 
 	for _, line := range lines {
 		line = strings.TrimSpace(line)
diff --git a/pkg/linters/module/rules/module_yaml_test.go b/pkg/linters/module/rules/module_yaml_test.go
@@ -308,15 +308,15 @@ stage: Experimental
 	errorList := errors.NewLintRuleErrorsList()
 	rule.CheckDefinitionFile(tempDir, errorList)
 
-	got_errors := []string{}
+	gotErrors := []string{}
 	for _, e := range errorList.GetErrors() {
 		if e.Level == pkg.Error {
-			got_errors = append(got_errors, e.Text)
+			gotErrors = append(gotErrors, e.Text)
 		}
 	}
-	assert.NotEmpty(t, got_errors, "Expected error for missing descriptions.en")
+	assert.NotEmpty(t, gotErrors, "Expected error for missing descriptions.en")
 	found := false
-	for _, w := range got_errors {
+	for _, w := range gotErrors {
 		if w == "Module `descriptions.en` field is required" {
 			found = true
 		}
@@ -633,7 +633,7 @@ update:
 	rule.CheckDefinitionFile(tempDir, errorList)
 	assert.True(t, errorList.ContainsErrors(), "Expected errors for missing from/to fields")
 
-	errorTexts := []string{}
+	errorTexts := make([]string, 0, 10) // Preallocate with reasonable capacity
 	for _, e := range errorList.GetErrors() {
 		errorTexts = append(errorTexts, e.Text)
 	}
@@ -685,7 +685,7 @@ update:
 	rule.CheckDefinitionFile(tempDir, errorList)
 	assert.True(t, errorList.ContainsErrors(), "Expected errors for patch versions")
 
-	errorTexts := []string{}
+	errorTexts := make([]string, 0, 10) // Preallocate with reasonable capacity
 	for _, e := range errorList.GetErrors() {
 		errorTexts = append(errorTexts, e.Text)
 	}

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ func (m *metricStorage) registerHistogram(metric string, labels map[string]strin`
`193`	`193`
`194`	`194`	`// labelNames returns sorted label keys`
`195`	`195`	`func labelNames(labels map[string]string) []string {`
`196`		`- names := make([]string, 0)`
	`196`	`+ names := make([]string, 0, len(labels))`
`197`	`197`	`for labelName := range labels {`
`198`	`198`	`names = append(names, labelName)`
`199`	`199`	`}`
Original file line number	Diff line number	Diff line change
`@@ -201,8 +201,8 @@ func mapContainerRules(linterSettings pkg.LintersSettings, configSettings conf`
`201`	`201`	`globalConfig.Container.Rules.NamespaceLabelsRule.Impact,`
`202`	`202`	`configSettings.Container.Impact,`
`203`	`203`	`)`
`204`		`- linterSettings.Container.Rules.ApiVersionRule.SetLevel(`
`205`		`- globalConfig.Container.Rules.ApiVersionRule.Impact,`
	`204`	`+ linterSettings.Container.Rules.APIVersionRule.SetLevel(`
	`205`	`+ globalConfig.Container.Rules.APIVersionRule.Impact,`
`206`	`206`	`configSettings.Container.Impact,`
`207`	`207`	`)`
`208`	`208`	`linterSettings.Container.Rules.PriorityClassRule.SetLevel(`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ import (`
`26`	`26`	`"net/http"`
`27`	`27`	`"time"`
`28`	`28`
`29`		`- "github.com/golang/protobuf/proto"`
	`29`	`+ "github.com/golang/protobuf/proto" //nolint:staticcheck // Required for prompb compatibility`
`30`	`30`	`"github.com/golang/snappy"`
`31`	`31`	`"github.com/prometheus/prometheus/prompb"`
`32`	`32`	`)`