Skip to content

Fix all TODOs #461

@astef

Description

@astef

// TODO: forbid changing properties more then once
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/api/v1alpha1/replicated_volume_replica.go#L142

// TODO: remove after testing
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/api/v1alpha1/replicated_volume_consts.go#L62

// TODO: Revisit this in the spec
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rv_status_config_quorum/reconciler.go#L100

// TODO: reconsider this approach, maybe we should not use DeepEqual and just patch all conditions?
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rv_status_conditions/reconciler.go#L99

// TODO: use meta.FindStatusCondition
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rv_status_conditions/reconciler.go#L132

// TODO use OnlyControllerOwner everywhere if possible.
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rv_status_config_shared_secret/controller.go#L40

// - RVRs with invalid nodeID: log and ignore. TODO: Revisit this in spec
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_status_config_node_id/reconciler.go#L88

extURL := os.Getenv("SCHEDULER_EXTENDER_URL") // TODO init in the other place later
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_scheduling_controller/scheduler_extender.go#L62

return nil, err // TODO: implement graceful shutdown
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_scheduling_controller/reconciler.go#L64

// TODO: fix checking for deletion
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_scheduling_controller/reconciler.go#L918

// TODO: fail ReplicatedVolume if it has empty ReplicatedStorageClassName
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_tie_breaker_count/reconciler.go#L70

// TODO: tieBreakerCount <= totalBaseReplicas is not the best approach, need to rework later
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_tie_breaker_count/reconciler.go#L295

// TODO: Update sds-node-configurator to export this contants and reuse here
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_volume/reconciler.go#L38

// TODO: Can record the reconcile error in the message to the condition
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_volume/reconciler.go#L103

// TODO: Can record the reconcile error in the message to the condition
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_volume/reconciler.go#L152

// TODO: Define in our spec how to handle IsAlreadyExists here (LLV with this name already exists)
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_volume/reconciler.go#L282

// TODO: replace with direct in place assignment for clarity. Code duplication will be resolved by grouping tests together and having initialisation in BeforeEach blocks once for multiple cases
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_diskful_count/reconciler_test.go#L38

// TODO: replace with direct in place assignment for clarity. Code duplication will be resolved by grouping tests together and having initialisation in BeforeEach blocks once for multiple cases
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/controller/internal/controllers/rvr_diskful_count/reconciler_test.go#L45

// TODO: add index
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/agent/internal/scanner/scanner.go#L201

// TODO streaming
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/agent/pkg/drbdconf/writer.go#L45

// TODO: we need all items to be sorted and not rely on sorting on DRBD side
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/agent/pkg/drbdsetup/status.go#L113

// TODO: Add snapshot support if needed
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/csi-driver/driver/controller.go#L294

return d.httpSrv.Shutdown(context.Background()) // TODO: Should we use just ctx here?
https://github.com/deckhouse/sds-replicated-volume/blob/astef-prototype/images/csi-driver/driver/driver.go#L169

Metadata

Metadata

Assignees

No one assigned

    Labels

    TODOSomething needs to be donetriaged-oncewe've checked that once and decided it's not important for now

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions