fix(vmop): exit maintenance mode after restore failure (#2094)

Description
When a restore operation fails, the VM remains in maintenance mode because the lifecycle handler ignores the Failed phase and never calls ExitMaintenanceStep.

This fix adds a check: for restore operations (vmop.Spec.Restore != nil), continue processing after Failed phase to allow ExitMaintenanceStep to run and exit maintenance mode.

Also adds handling when VirtualDisk is not found during restore - instead of failing, wait for disk to appear (watcher will trigger reconcile).


---------

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

Author: danilrwx

images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/handler/lifecycle.go

@@ -62,9 +62,14 @@ func (h LifecycleHandler) Handle(ctx context.Context, vmop *v1alpha2.VirtualMach
 		return reconcile.Result{}, nil
 	}
 
+	maintenanced, foundMaintenance := conditions.GetCondition(vmopcondition.TypeMaintenanceMode, vmop.Status.Conditions)
+
 	// Ignore if VMOP is in final state or failed.
 	if vmop.Status.Phase == v1alpha2.VMOPPhaseCompleted || vmop.Status.Phase == v1alpha2.VMOPPhaseFailed {
-		return reconcile.Result{}, nil
+		// Skip: not a restore operation OR already exited maintenance
+		if vmop.Spec.Restore == nil || !foundMaintenance || maintenanced.Status == metav1.ConditionFalse {
+			return reconcile.Result{}, nil
+		}
 	}
 
 	completed, completedFound := conditions.GetCondition(vmopcondition.TypeCompleted, vmop.Status.Conditions)

images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/waiting_disk_ready_step.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"fmt"
 
+	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -75,6 +76,11 @@ func (s WaitingDisksReadyStep) Take(ctx context.Context, vmop *v1alpha2.VirtualM
 		vdKey := types.NamespacedName{Namespace: vmop.Namespace, Name: status.Name}
 		err := s.client.Get(ctx, vdKey, &vd)
 		if err != nil {
+			if k8serrors.IsNotFound(err) {
+				cb.Message("Waiting for resource readiness.")
+				conditions.SetCondition(cb, &vmop.Status.Conditions)
+				return nil, nil
+			}
 			return &reconcile.Result{}, fmt.Errorf("failed to get the `VirtualDisk`: %w", err)
 		}