fix(api, vmop): set Completed condition to InProgress on restore/clone start

- Set Completed condition to False with CloneInProgress/RestoreInProgress reason
  when VMOP phase transitions to InProgress, fixing condition showing Unknown
- Skip process clone/restore steps if VMOP is already completed to prevent
  re-running finished operations

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

Author: danilrwx

images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/handler/lifecycle.go

@@ -116,6 +116,16 @@ func (h LifecycleHandler) Handle(ctx context.Context, vmop *v1alpha2.VirtualMach
 
 	// 6. The Operation is valid, and can be executed.
 	vmop.Status.Phase = v1alpha2.VMOPPhaseInProgress
+
+	reason := svcOp.GetInProgressReason()
+	conditions.SetCondition(
+		conditions.NewConditionBuilder(vmopcondition.TypeCompleted).
+			Generation(vmop.GetGeneration()).
+			Reason(reason).
+			Message("Wait for operation to complete").
+			Status(metav1.ConditionFalse),
+		&vmop.Status.Conditions)
+
 	return svcOp.Execute(ctx)
 }
 

images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/process_clone_step.go

@@ -21,16 +21,19 @@ import (
 	"errors"
 
 	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
 
 	"github.com/deckhouse/virtualization-controller/pkg/common/annotations"
 	"github.com/deckhouse/virtualization-controller/pkg/common/object"
+	"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
 	"github.com/deckhouse/virtualization-controller/pkg/controller/service/restorer"
 	"github.com/deckhouse/virtualization-controller/pkg/controller/service/restorer/common"
 	"github.com/deckhouse/virtualization-controller/pkg/eventrecord"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2"
+	"github.com/deckhouse/virtualization/api/core/v1alpha2/vmopcondition"
 )
 
 type ProcessCloneStep struct {
@@ -49,6 +52,11 @@ func NewProcessCloneStep(
 }
 
 func (s ProcessCloneStep) Take(ctx context.Context, vmop *v1alpha2.VirtualMachineOperation) (*reconcile.Result, error) {
+	cond, found := conditions.GetCondition(vmopcondition.TypeCompleted, vmop.Status.Conditions)
+	if found && cond.Status == metav1.ConditionTrue {
+		return nil, nil
+	}
+
 	snapshotName, ok := vmop.Annotations[annotations.AnnVMOPSnapshotName]
 	if !ok {
 		return &reconcile.Result{}, errors.New("snapshot name annotation not found")

images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/process_restore_step.go

@@ -51,6 +51,11 @@ func NewProcessRestoreStep(
 }
 
 func (s ProcessRestoreStep) Take(ctx context.Context, vmop *v1alpha2.VirtualMachineOperation) (*reconcile.Result, error) {
+	cond, found := conditions.GetCondition(vmopcondition.TypeCompleted, vmop.Status.Conditions)
+	if found && cond.Status == metav1.ConditionTrue {
+		return nil, nil
+	}
+
 	maintenanceModeCondition, found := conditions.GetCondition(vmopcondition.TypeMaintenanceMode, vmop.Status.Conditions)
 	if vmop.Spec.Restore.Mode != v1alpha2.SnapshotOperationModeDryRun && (!found || maintenanceModeCondition.Status == metav1.ConditionFalse) {
 		return &reconcile.Result{}, nil