@@ -19,6 +19,7 @@ package usb
1919import (
2020 "context"
2121 "fmt"
22+ "io/fs"
2223 "log/slog"
2324 "strings"
2425 "sync"
@@ -271,9 +272,9 @@ func (s *AllocationStore) makeContainerEdits(claimUID string, device *resourceap
271272 Env : []string {
272273 fmt .Sprintf ("DRA_USB_CLAIM_UID_%s=%s" , claimUIDUpper , claimUID ),
273274 fmt .Sprintf ("DRA_USB_DEVICE_NAME_%s=%s" , deviceNameUpper , device .Name ),
274- fmt .Sprintf ("DRA_USB_CLAIM_UID_%s_DEVICE =%s" , claimUIDUpper , device .Name ),
275- fmt .Sprintf ("DRA_USB_DEVICE_PATH_%s =%s" , deviceNameUpper , devicePath ), // dra env
276- fmt .Sprintf ("USB_RESOURCE_%s =%s:%s" , deviceNameUpper , bus , deviceNum ), // kubevirt env
275+ fmt .Sprintf ("DRA_USB_CLAIM_UID_%s_DEVICE_NAME =%s" , claimUIDUpper , device .Name ),
276+ fmt .Sprintf ("DRA_USB_%s_DEVICE_PATH =%s" , deviceNameUpper , devicePath ),
277+ fmt .Sprintf ("DRA_USB_%s_BUS_DEVICENUMBER =%s:%s" , deviceNameUpper , bus , deviceNum ),
277278 },
278279 DeviceNodes : []* cdispec.DeviceNode {
279280 {
@@ -282,6 +283,7 @@ func (s *AllocationStore) makeContainerEdits(claimUID string, device *resourceap
282283 Type : "c" ,
283284 Major : major ,
284285 Minor : minor ,
286+ FileMode : ptr .To (fs .ModeCharDevice ),
285287 Permissions : "mrw" ,
286288 UID : ptr .To (uint32 (107 )), // qemu user. TODO: make this configurable
287289 GID : ptr .To (uint32 (107 )), // qemu group. TODO: make this configurable
@@ -352,11 +354,11 @@ func parseDraEnvToClaimAllocations(envs []string) (map[types.UID][]string, error
352354 key := parts [0 ]
353355 value := parts [1 ]
354356
355- if ! strings .HasPrefix (key , "DRA_USB_CLAIM_UID_" ) || ! strings .HasSuffix (key , "_DEVICE " ) {
357+ if ! strings .HasPrefix (key , "DRA_USB_CLAIM_UID_" ) || ! strings .HasSuffix (key , "_DEVICE_NAME " ) {
356358 continue
357359 }
358360 uid := strings .TrimPrefix (key , "DRA_USB_CLAIM_UID_" )
359- uid = strings .TrimSuffix (uid , "_DEVICE " )
361+ uid = strings .TrimSuffix (uid , "_DEVICE_NAME " )
360362 uid = strings .ToLower (uid )
361363 claimUID := types .UID (uid )
362364
0 commit comments