fix(vmip): fix vmip phase assignment for a vm in the terminating phase (#2048)

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>

Author: eofff

images/virtualization-artifact/pkg/controller/vmip/internal/attached_handler.go

@@ -125,6 +125,10 @@ func (h *AttachedHandler) getAttachedVirtualMachine(ctx context.Context, vmip *v
 	}
 
 	if attachedVM != nil {
+		// A VM that is being deleted is not considered attached so the VMIP can be released and, if managed, removed (e.g. during cascade deletion).
+		if !attachedVM.GetDeletionTimestamp().IsZero() && len(attachedVM.Status.VirtualMachinePods) == 0 {
+			return nil, nil
+		}
 		if network.HasMainNetworkStatus(attachedVM.Status.Networks) {
 			return attachedVM, nil
 		}

images/virtualization-artifact/pkg/controller/vmip/internal/watcher/vm_watcher.go

@@ -71,6 +71,10 @@ func (w VirtualMachineWatcher) Watch(mgr manager.Manager, ctr controller.Control
 						return true
 					}
 
+					if len(oldVM.Status.VirtualMachinePods) != len(newVM.Status.VirtualMachinePods) {
+						return true
+					}
+
 					return false
 				},
 			},