fix(vmbda): fix VMBDA stuck in InProgress when cloning VM with hotplug disks (#2080)

Root cause: when cloning a VM, getVirtualDisks() set AttachedToVirtualMachines
to the original VM name from vmSnapshot.Spec.VirtualMachineName. This caused
WaitForFirstConsumer logic to bypass correctly since len(AttachedToVirtualMachines)==1.

Fix:
- snapshot_resources.go: pass operation type to getVirtualDisks() and only set
  AttachedToVirtualMachines for restore operation. For clone, leave it empty
  so WaitForFirstConsumer logic works correctly.
- vd_restorer.go: update AttachedToVirtualMachines in Customize() method for
  defense in depth.

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

Author: danilrwx

images/virtualization-artifact/pkg/controller/service/restorer/restorers/vd_restorer.go

@@ -70,6 +70,11 @@ func (v *VirtualDiskHandler) Override(rules []v1alpha2.NameReplacement) {
 
 func (v *VirtualDiskHandler) Customize(prefix, suffix string) {
 	v.vd.Name = common.ApplyNameCustomization(v.vd.Name, prefix, suffix)
+
+	for i := range v.vd.Status.AttachedToVirtualMachines {
+		oldName := v.vd.Status.AttachedToVirtualMachines[i].Name
+		v.vd.Status.AttachedToVirtualMachines[i].Name = common.ApplyNameCustomization(oldName, prefix, suffix)
+	}
 }
 
 func (v *VirtualDiskHandler) ValidateRestore(ctx context.Context) error {

images/virtualization-artifact/pkg/controller/service/restorer/snapshot_resources.go

@@ -112,7 +112,7 @@ func (r *SnapshotResources) Prepare(ctx context.Context) error {
 		return err
 	}
 
-	vds, err := getVirtualDisks(ctx, r.client, r.vmSnapshot)
+	vds, err := getVirtualDisks(ctx, r.client, r.vmSnapshot, r.kind)
 	if err != nil {
 		return err
 	}
@@ -329,7 +329,7 @@ func isRetryError(err error) bool {
 	return false
 }
 
-func getVirtualDisks(ctx context.Context, client client.Client, vmSnapshot *v1alpha2.VirtualMachineSnapshot) ([]*v1alpha2.VirtualDisk, error) {
+func getVirtualDisks(ctx context.Context, client client.Client, vmSnapshot *v1alpha2.VirtualMachineSnapshot, kind v1alpha2.VMOPType) ([]*v1alpha2.VirtualDisk, error) {
 	vds := make([]*v1alpha2.VirtualDisk, 0, len(vmSnapshot.Status.VirtualDiskSnapshotNames))
 
 	for _, vdSnapshotName := range vmSnapshot.Status.VirtualDiskSnapshotNames {
@@ -343,6 +343,15 @@ func getVirtualDisks(ctx context.Context, client client.Client, vmSnapshot *v1al
 			return nil, fmt.Errorf("failed to get the virtual disk snapshot %q: %w", vdSnapshotName, common.ErrVirtualDiskSnapshotNotFound)
 		}
 
+		// Set AttachedToVirtualMachines only for restore operation.
+		// For clone operation, leave it empty so WaitForFirstConsumer logic works correctly.
+		var attachedVMs []v1alpha2.AttachedVirtualMachine
+		if kind == v1alpha2.VMOPTypeRestore {
+			attachedVMs = []v1alpha2.AttachedVirtualMachine{
+				{Name: vmSnapshot.Spec.VirtualMachineName, Mounted: true},
+			}
+		}
+
 		vd := v1alpha2.VirtualDisk{
 			TypeMeta: metav1.TypeMeta{
 				Kind:       v1alpha2.VirtualDiskKind,
@@ -362,9 +371,7 @@ func getVirtualDisks(ctx context.Context, client client.Client, vmSnapshot *v1al
 				},
 			},
 			Status: v1alpha2.VirtualDiskStatus{
-				AttachedToVirtualMachines: []v1alpha2.AttachedVirtualMachine{
-					{Name: vmSnapshot.Spec.VirtualMachineName, Mounted: true},
-				},
+				AttachedToVirtualMachines: attachedVMs,
 			},
 		}