Merge branch 'main' into pt-debug

Signed-off-by: Nikita Korolev <[email protected]>

Author: universal-itengineer

.github/scripts/prs_notifier.mjs

@@ -212,7 +212,7 @@ function getPullRequestGroup(reviews, requestedReviewers) {
     }
 
     const submittedAt = new Date(review.submitted_at)
-    submittedAt.setDate(submittedAt.getDate() + 1);
+    submittedAt.setTime(submittedAt.getTime() + 1.5 * 24 * 60 * 60 * 1000); // submittedAt + 1.5 days.
     if (now.getDay() !== 1 && submittedAt < now) {
       return STUCK;
     }

.github/workflows/check-changelog-entry.yml

@@ -0,0 +1,65 @@
+# Copyright 2024 Flant JSC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Check Changelog entry
+
+on:
+  pull_request:
+    types: [opened, synchronize, reopened, edited]
+
+# Cancel in-progress jobs for the same PR (pull_request_target event) or for the same branch (push event).
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  changelog:
+    name: Check Changelog entry
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/[email protected]
+      - name: Check Changelog entry
+        id: entry-check
+        uses: deckhouse/[email protected]
+        with:
+          validate_only: true
+          allowed_sections: |
+            api
+            vm
+            vmop
+            vmbda
+            vmclass
+            vmip
+            vmipl
+            vdsnapshot
+            vmsnapshot
+            vmrestore
+            disks
+            vd
+            images
+            vi
+            cvi
+            core
+            api-service:low
+            vm-route-forge:low
+            kubevirt:low
+            kube-api-rewriter:low
+            cdi:low
+            dvcr:low
+            module
+            observability
+            ci:low
+            docs
+            network

.github/workflows/cve-weekly.yaml

@@ -57,6 +57,14 @@ jobs:
       - name: Remove unwanted software
         uses: ./.github/actions/remove-unwanted-software
 
-      - uses: deckhouse/modules-actions/setup@v1
+      - uses: deckhouse/modules-actions/setup@v2
+        with:
+          registry: ${{ vars.DEV_REGISTRY }}
+          registry_login: ${{ vars.DEV_MODULES_REGISTRY_LOGIN }}
+          registry_password: ${{ secrets.DEV_MODULES_REGISTRY_PASSWORD }}
 
-      - uses: deckhouse/modules-actions/build@v1
+      - uses: deckhouse/modules-actions/build@v2
+        with:
+          module_source: ${{ vars.DEV_MODULE_SOURCE}}
+          module_name: ${{ vars.MODULE_NAME }}
+          module_tag: "$MODULES_MODULE_TAG"

.github/workflows/dev_build_precache.yml

@@ -53,7 +53,7 @@ concurrency:
 
 jobs:
   deploy-dev:
-    runs-on: [self-hosted, regular, selectel]
+    runs-on: [self-hosted, large]
     name: Deploy dev
     steps:
       - name: PRINT VARS
@@ -81,8 +81,22 @@ jobs:
       - name: Checkout specified tag
         run: git checkout tags/${{ github.event.inputs.tag }}
 
-      - uses: deckhouse/modules-actions/setup@v1
+      - uses: deckhouse/modules-actions/setup@v2
+        with:
+          registry: ${{ vars.DEV_REGISTRY }}
+          registry_login: ${{ vars.DEV_MODULES_REGISTRY_LOGIN }}
+          registry_password: ${{ secrets.DEV_MODULES_REGISTRY_PASSWORD }}
+
       - if: ${{ github.event.inputs.enableBuild == 'true' }}
-        uses: deckhouse/modules-actions/build@v1
+        uses: deckhouse/modules-actions/build@v2
+        with:
+          module_source: "$MODULES_MODULE_SOURCE"
+          module_name: ${{ vars.MODULE_NAME }}
+          module_tag: "$MODULES_MODULE_TAG"
 
-      - uses: deckhouse/modules-actions/deploy@v1
+      - uses: deckhouse/modules-actions/deploy@v2
+        with:
+          module_source: "$MODULES_MODULE_SOURCE"
+          module_name: ${{ vars.MODULE_NAME }}
+          module_tag: "$MODULES_MODULE_TAG"
+          release_channel: ${{ github.event.inputs.version }}

.github/workflows/dev_module_build-and-registration.yml

@@ -22,6 +22,7 @@ env:
   MODULES_REGISTRY_LOGIN: ${{ vars.DEV_MODULES_REGISTRY_LOGIN }}
   MODULES_REGISTRY_PASSWORD: ${{ secrets.DEV_MODULES_REGISTRY_PASSWORD }}
   GO_VERSION: "1.22.7"
+  GOLANGCI_LINT_VERSION: "1.64.8"
   SOURCE_REPO: "${{secrets.SOURCE_REPO}}"
 
 on:
@@ -177,10 +178,85 @@ jobs:
         with:
           ref: ${{ github.event.pull_request.head.sha || github.sha }}
 
-      - name: Run lint virtualization-controller
+      - name: Install golangci-lint
         run: |
-          task virtualization-controller:init
-          task virtualization-controller:lint:go
+          echo "Installing golangci-lint..."
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v${{ env.GOLANGCI_LINT_VERSION}}
+          echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
+          echo "golangci-lint v${{ env.GOLANGCI_LINT_VERSION}} installed successfully!"
+
+      - name: Lint all directories with golangci-lint
+        id: linters
+        # continue-on-error: true
+        shell: bash
+        run: |
+          # Find directories containing .golangci.yaml
+          mapfile -t config_dirs < <(find . -type f -name '.golangci.yaml' -printf '%h\0' | xargs -0 -n1 | sort -u)
+          count=${#config_dirs[@]}
+          echo "::notice title=Lint Setup::🔍 Found $count directories with linter configurations"
+
+          report=""
+          error_count=0
+          find_errors=0
+
+          for dir in "${config_dirs[@]}"; do
+            # echo "::group::📂 Linting directory: $dir"
+            # cd "$dir" || { echo "::error::Failed to access directory $dir"; exit 1; }
+
+            cd "$dir" || { echo "::error::Failed to access directory $dir"; continue; }
+            
+            # Run linter with multiple formats
+            
+            output=$(golangci-lint run --out-format=json 2>/dev/null | jq '{warning: .Report.Warnings, error: .Report.Error}' || true)
+            find_errors=$(echo $output | jq '.error | select(.!=null)' | wc -l)
+            
+            # Track errors
+            if [ $find_errors -ne 0 ]; then
+              error_count=$(( error_count + 1 ))
+              echo "::group::📂 Linting directory ❌: $dir"
+            else
+              echo "::group::📂 Linting directory ✅: $dir"
+            fi
+            
+            report_out_warning=$(echo $output | jq '.warning')
+            report_out_error=$(echo $output | jq '.error')
+
+            # Build report section
+            report+="\n\n### Directory: $dir\n"
+            report+="Find Errors: $find_errors\n"
+            report+="Output:\n\`\`\`\n$report_out_warning\n$report_out_error\n\`\`\`\n"
+            report+="---\n"
+
+            cd - &>/dev/null
+            
+            if [ $find_errors -ne 0 ]; then
+              echo -e "⚠️ Warnings:\n$report_out_warning"
+              echo -e "❌ Errors:\n$report_out_error\n"
+            else
+              echo -e "✅ All check passed\n"
+            fi
+
+            echo "::endgroup::"
+          done
+
+          echo "directory_count=$count" >> "$GITHUB_OUTPUT"
+
+          has_errors=$( [[ "$error_count" -gt 0 ]] && echo true || echo false)
+          echo "has_errors=$has_errors" >> "$GITHUB_OUTPUT"
+
+          if [ $error_count -gt 0 ]; then
+            exit 1
+          fi
+
+      - name: Final status check
+        if: always()
+        run: |
+          if ${{ steps.linters.outputs.has_errors }}; then
+            echo "::error::🔥 Lint errors found in $error_count directories. Check step 'Lint all directories with golangci-lint' for details."
+            exit 1
+          else
+            echo "::notice::✅ All linters passed successfully in ${{ steps.linters.outputs.directory_count }} directories"
+          fi
 
   lint_yaml:
     runs-on: ubuntu-latest
@@ -252,7 +328,17 @@ jobs:
         if: ${{ !contains(needs.set_vars.outputs.runner_type, 'self-hosted') }}
         uses: ./.github/actions/remove-unwanted-software
 
-      - uses: deckhouse/modules-actions/setup@v1
+      - uses: deckhouse/modules-actions/setup@v2
+        with:
+          registry: ${{ vars.DEV_REGISTRY }}
+          registry_login: ${{ vars.DEV_MODULES_REGISTRY_LOGIN }}
+          registry_password: ${{ secrets.DEV_MODULES_REGISTRY_PASSWORD }}
+
+      - uses: deckhouse/modules-actions/build@v2
+        with:
+          module_source: ${{ vars.DEV_MODULE_SOURCE}}
+          module_name: ${{ vars.MODULE_NAME }}
+          module_tag: "$MODULES_MODULE_TAG"
 
       - name: Set git postBuffer 1048576000
         run: |

.github/workflows/dev_module_build.yml

@@ -38,7 +38,11 @@ jobs:
     name: Run cleanup
     steps:
       - uses: actions/checkout@v4
-      - uses: deckhouse/modules-actions/setup@v1
+      - uses: deckhouse/modules-actions/setup@v2
+        with:
+          registry: ${{ vars.DEV_REGISTRY }}
+          registry_login: ${{ vars.DEV_MODULES_REGISTRY_LOGIN }}
+          registry_password: ${{ secrets.DEV_MODULES_REGISTRY_PASSWORD }}
 
       - name: Cleanup
         run: |