Skip to content

fix: handle JSON parsing errors in loader (#907) #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcoferreiradev wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: handle JSON parsing errors in loader (#907) #907

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa591be
fix: handle JSON parsing errors in loader (#907)
marcoferreiradev Apr 24, 2025
77bec26
fix: handle JSON parsing errors in loader (#907)
marcoferreiradev Apr 24, 2025
9257f63
fix: improve error logging in JSON parsing by including loader and UR…
marcoferreiradev Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion blocks/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,13 @@ const wrapLoader = (
stats.cache.add(1, { status, loader });
}

return await matched.json();
const json = await matched.text();
try {
return JSON.parse(json);
} catch (error) {
logger.error("MATCHED", {json: json || "no json", loader, url: url.toString()});
throw error;
}
};

return await flights.do(request.url, staleWhileRevalidate);
Expand Down
Loading