build: Test against Go 1.25 and Node LTS (#2022)

Author: dajohi

.github/workflows/build.yml

@@ -9,22 +9,26 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        go: ['1.20', '1.21']
+        go: ['1.24', '1.25']
     steps:
-    - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
-
+    - name: Check out source
+      uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
     - name: Set up Go
-      uses: actions/setup-go@fac708d6674e30b6ba41289acaab6d4b75aa0753 #v4.0.1
+      uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
       with:
         go-version: ${{ matrix.go }}
-
+    - name: Use lint cache
+      uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 # v4.2.4
+      with:
+        path: |
+          ~/.cache/golangci-lint
+        key: go-lint-${{ matrix.go }}-${{ hashFiles('./go.sum') }}
+        restore-keys: go-lint-${{ matrix.go }}
+    - name: Install Linters
+      run: "go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.5.0"
     - name: Go Build dcrdata
       run: go build -v ./...
       working-directory: ./cmd/dcrdata
-
-    - name: Install Linters
-      run: "curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.55.2"
-
     - name: Go Tests
       run: |
         ./run_tests.sh
@@ -34,12 +38,12 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16.x, 18.x]
+        node-version: ['lts/*']
     steps:
-      - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
 
       - name: Use nodejs ${{ matrix.node-version }}
-        uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c #v3.6.0
+        uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 #v5.0.0
         with:
           node-version: ${{ matrix.node-version }}
 

.github/workflows/docker.yml

@@ -5,6 +5,6 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab #v3.5.2
+    - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
     - name: Build the Docker image
       run: docker build -t decred/dcrdata:$(date +%s) .

.golangci.yml

@@ -1,27 +1,43 @@
+version: "2"
 run:
   timeout: 10m
-
-output:
-  format: github-actions,colored-line-number
-
 linters:
-  disable-all: true
+  default: none
   enable:
     - asciicheck
     - bidichk
     - durationcheck
-    - exportloopref
-    - gofmt
-    - goimports
-    - gosimple
+    - errchkjson
     - govet
     - grouper
     - ineffassign
     - makezero
     - misspell
+    - nilerr
     - nosprintfhostport
     - reassign
+    - rowserrcheck
     - tparallel
-    - typecheck
     - unconvert
     - unparam
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

db/dbtypes/types.go

@@ -1047,8 +1047,11 @@ func (p *VinTxPropertyARRAY) Scan(src interface{}) error {
 		if !ok {
 			return fmt.Errorf("type assertion .(map[string]interface) failed")
 		}
-		b, _ := json.Marshal(VinTxPropertyMapIface)
-		err := json.Unmarshal(b, &ba[ii])
+		b, err := json.Marshal(VinTxPropertyMapIface)
+		if err != nil {
+			return err
+		}
+		err = json.Unmarshal(b, &ba[ii])
 		if err != nil {
 			return err
 		}

db/dcrpg/pgblockchain.go

@@ -307,7 +307,7 @@ func (pgb *ChainDB) timeoutError() string {
 // replaces a sql.ErrNoRows with a dbtypes.ErrNoResult.
 func (pgb *ChainDB) replaceCancelError(err error) error {
 	if err == nil {
-		return err
+		return nil
 	}
 
 	if errors.Is(err, sql.ErrNoRows) {
@@ -5036,7 +5036,7 @@ func (pgb *ChainDB) GetVoteInfo(txhash *chainhash.Hash) (*apitypes.VoteInfo, err
 	tx, err := pgb.Client.GetRawTransaction(pgb.ctx, txhash)
 	if err != nil {
 		log.Errorf("GetRawTransaction failed for: %v", txhash)
-		return nil, nil
+		return nil, err
 	}
 
 	validation, version, bits, choices, tspendVotes, err := txhelpers.SSGenVoteChoices(tx.MsgTx(), pgb.chainParams)
@@ -5618,7 +5618,6 @@ func (pgb *ChainDB) GetAddressTransactionsRawWithSkip(addr string, count, skip i
 		log.Errorf("GetAddressTransactionsRawWithSkip: SelectVinsForAddress %s: %v", addr, err)
 		return nil
 	}
-	defer rows.Close()
 
 	type vinIndexed struct {
 		*apitypes.VinShort
@@ -5633,6 +5632,7 @@ func (pgb *ChainDB) GetAddressTransactionsRawWithSkip(addr string, count, skip i
 		if err = rows.Scan(&txid, &idx, &vinTxID, &vin.Vout, &vin.Tree, &val,
 			&vin.BlockHeight, &vin.BlockIndex); err != nil {
 			log.Errorf("GetAddressTransactionsRawWithSkip: SelectVinsForAddress %s: %v", addr, err)
+			rows.Close()
 			return nil
 		}
 		vin.Txid = vinTxID.String()
@@ -5643,14 +5643,21 @@ func (pgb *ChainDB) GetAddressTransactionsRawWithSkip(addr string, count, skip i
 		// Coinbase, Stakebase, etc. booleans are set on TxType detection below.
 		vins[txid] = append(vins[txid], &vinIndexed{&vin, idx})
 	}
+	if err = rows.Err(); err != nil {
+		log.Errorf("GetAddressTransactionsRawWithSkip: %v", err)
+		return nil
+	}
+	if err = rows.Close(); err != nil {
+		log.Errorf("GetAddressTransactionsRawWithSkip: %v", err)
+		return nil
+	}
 
 	// tx
 	rows, err = pgb.db.QueryContext(ctx, internal.SelectAddressTxns, addr, count, skip)
 	if err != nil {
 		log.Errorf("GetAddressTransactionsRawWithSkip: SelectAddressTxns %s: %v", addr, err)
 		return nil
 	}
-	defer rows.Close()
 
 	txns := make(map[dbtypes.ChainHash]*apitypes.AddressTxRaw)
 
@@ -5663,6 +5670,7 @@ func (pgb *ChainDB) GetAddressTransactionsRawWithSkip(addr string, count, skip i
 		if err = rows.Scan(&txid, &blockHash, &blockHeight,
 			&tx.Time.S, &tx.Version, &tx.Locktime, &tx.Size, &tx.Type, &numVins, &numVouts /*, &vinDbIDs, &voutDbIDs*/); err != nil {
 			log.Errorf("GetAddressTransactionsRawWithSkip: Scan %s: %v", addr, err)
+			rows.Close()
 			return nil
 		}
 		tx.TxID = txid.String()
@@ -5701,21 +5709,29 @@ func (pgb *ChainDB) GetAddressTransactionsRawWithSkip(addr string, count, skip i
 
 		txs = append(txs, &tx)
 	}
+	if err = rows.Err(); err != nil {
+		log.Errorf("GetAddressTransactionsRawWithSkip: %v", err)
+		return nil
+	}
+	if err = rows.Close(); err != nil {
+		log.Errorf("GetAddressTransactionsRawWithSkip: %v", err)
+		return nil
+	}
 
 	// vouts
 	rows, err = pgb.db.QueryContext(ctx, internal.SelectVoutsForAddress, addr, count, skip)
 	if err != nil {
 		log.Errorf("GetAddressTransactionsRawWithSkip: SelectVoutsForAddress %s: %v", addr, err)
 		return nil
 	}
-	defer rows.Close()
 
 	for rows.Next() {
 		var txid dbtypes.ChainHash // funding tx
 		var vout apitypes.Vout
 		var val int64
 		if err = rows.Scan(&val, &txid, &vout.N, &vout.Version); err != nil {
 			log.Errorf("GetAddressTransactionsRawWithSkip: SelectVoutsForAddress %s: %v", addr, err)
+			rows.Close()
 			return nil
 		}
 
@@ -5733,6 +5749,14 @@ func (pgb *ChainDB) GetAddressTransactionsRawWithSkip(addr string, count, skip i
 		// vout.ScriptPubKeyDecoded = decPkScript(vout.Version, pkScript, isTicketCommit, pgb.chainParams)
 		tx.Vout = append(tx.Vout, vout)
 	}
+	if err = rows.Err(); err != nil {
+		log.Errorf("GetAddressTransactionsRawWithSkip: %v", err)
+		return nil
+	}
+	if err = rows.Close(); err != nil {
+		log.Errorf("GetAddressTransactionsRawWithSkip: %v", err)
+		return nil
+	}
 
 	// Get pkscripts that db doesn't have.
 	for hash, atx := range txns {

db/dcrpg/queries.go

@@ -3634,10 +3634,13 @@ func insertBlock(db *sql.DB, dbBlock *dbtypes.Block, isValid, isMainchain, check
 func insertBlockPrevNext(db *sql.DB, blockDbID uint64,
 	hash, prev, next *dbtypes.ChainHash) error {
 	rows, err := db.Query(internal.InsertBlockPrevNext, blockDbID, prev, hash, next)
-	if err == nil {
-		return rows.Close()
+	if err != nil {
+		return err
 	}
-	return err
+	if err = rows.Err(); err != nil {
+		return err
+	}
+	return rows.Close()
 }
 
 // insertBlockStats inserts the block stats into the stats table.

db/dcrpg/system.go

@@ -197,6 +197,9 @@ func retrieveSysSettings(stmt string, db *sql.DB) (PGSettings, error) {
 			SourceLine: line,
 		}
 	}
+	if err = rows.Err(); err != nil {
+		return nil, err
+	}
 
 	return settings, nil
 }

db/dcrpg/tables.go

@@ -59,7 +59,7 @@ func TableExists(db *sql.DB, tableName string) (bool, error) {
 			log.Errorf("Close of Query failed: %v", e)
 		}
 	}()
-	return rows.Next(), nil
+	return rows.Next(), rows.Err()
 }
 
 func dropTable(db SqlExecutor, tableName string) error {

pubsub/psclient/client_test.go

@@ -788,7 +788,10 @@ func TestDecodeMsgNewBlock(t *testing.T) {
 
 func TestDecodeMsgPing(t *testing.T) {
 	expectedInt := 2
-	MessageJSON, _ := json.Marshal(expectedInt)
+	MessageJSON, err := json.Marshal(expectedInt)
+	if err != nil {
+		t.Fatalf("Failed to marshal %d: %v", expectedInt, err)
+	}
 	msgPing := &pstypes.WebSocketMessage{
 		EventId: "ping",
 		Message: MessageJSON,
@@ -806,7 +809,10 @@ func TestDecodeMsgPing(t *testing.T) {
 
 func TestDecodeMsgString(t *testing.T) {
 	expectedStr := "meow"
-	MessageJSON, _ := json.Marshal(expectedStr)
+	MessageJSON, err := json.Marshal(expectedStr)
+	if err != nil {
+		t.Fatalf("Failed to marshal %q: %v", expectedStr, err)
+	}
 	msgPing := &pstypes.WebSocketMessage{
 		EventId: "message",
 		Message: MessageJSON,