ui: fix tx popup explorer links (#3573)

If multiple popups were being opened in succession, the subsequent popups
would show the initial popup's explorer link.

Author: martonp

client/webserver/site/src/js/wallets.ts

@@ -1956,7 +1956,7 @@ export default class WalletsPage extends BasePage {
   txHistoryRow (tx: WalletTransaction, assetID: number): PageElement {
     const row = this.page.txHistoryRowTmpl.cloneNode(true) as PageElement
     row.dataset.txid = tx.id
-    Doc.bind(row, 'click', () => this.showTxDetailsPopup(tx))
+    Doc.bind(row, 'click', () => this.showTxDetailsPopup(tx, assetID))
     this.updateTxHistoryRow(row, tx, assetID)
     return row
   }
@@ -1968,19 +1968,21 @@ export default class WalletsPage extends BasePage {
     return row
   }
 
-  setTxDetailsPopupElements (tx: WalletTransaction) {
+  setTxDetailsPopupElements (tx: WalletTransaction, assetID: number) {
     const page = this.page
 
     // Block explorer
-    const assetExplorer = CoinExplorers[this.selectedWalletID]
+    page.txViewBlockExplorer.removeAttribute('href')
+    const explorerAssetID = app().assets[assetID]?.token?.parentID ?? assetID
+    const assetExplorer = CoinExplorers[explorerAssetID]
     if (assetExplorer && assetExplorer[net]) {
       const explorerID = (tx.isRelay && tx.relayTxID) ? tx.relayTxID : tx.id
       page.txViewBlockExplorer.href = assetExplorer[net](explorerID)
     }
 
     // Tx type
     let txType = txTypeString(tx.type)
-    if (tx.tokenID && tx.tokenID !== this.selectedWalletID) {
+    if (tx.tokenID && tx.tokenID !== assetID) {
       const tokenSymbol = app().assets[tx.tokenID].symbol.split('.')[0].toUpperCase()
       txType = `${tokenSymbol} ${txType}`
     }
@@ -1992,18 +1994,18 @@ export default class WalletsPage extends BasePage {
     if (noAmtTxTypes.includes(tx.type)) {
       Doc.hide(page.txDetailsAmtSection)
     } else {
-      let assetID = this.selectedWalletID
-      if (tx.tokenID) assetID = tx.tokenID
+      let amountAssetID = assetID
+      if (tx.tokenID) amountAssetID = tx.tokenID
       Doc.show(page.txDetailsAmtSection)
-      const ui = app().unitInfo(assetID)
+      const ui = app().unitInfo(amountAssetID)
       const amt = Doc.formatCoinValue(tx.amount, ui)
       const [s, c] = txTypeSignAndClass(tx.type)
       page.txDetailsAmount.textContent = `${s}${amt} ${ui.conventional.unit}`
       if (c !== '') page.txDetailsAmount.classList.add(c)
     }
 
     // Fee
-    let feeAsset = this.selectedWalletID
+    let feeAsset = assetID
     if (tx.tokenID !== undefined) {
       const asset = app().assets[tx.tokenID]
       if (asset.token) {
@@ -2072,9 +2074,9 @@ export default class WalletsPage extends BasePage {
     }
   }
 
-  showTxDetailsPopup (tx: WalletTransaction) {
+  showTxDetailsPopup (tx: WalletTransaction, assetID = this.txHistory.assetID) {
     this.currTx = tx
-    this.setTxDetailsPopupElements(tx)
+    this.setTxDetailsPopupElements(tx, assetID)
     this.forms.show(this.page.txDetails)
   }