simnet: Add per-match address tests and README. (#3562)

* simnet: Expand trade tests and fix multi-asset harness issues.

Add four new simnet trade tests exercising per-match swap address
protocol: notakeraddr, nomakeraddr, notakerredeem, and missedcpaddr.
Enhance trade monitoring to verify per-match SwapAddr uniqueness and
CounterPartyAddr population. Add sendFilter to tConn and
withRequestFilter/withSendFilter helpers for cleaner filter lifecycle.

Fix polygon simnet FinalizeConfs (was 64, now 2 on simnet) so polygon
redeems confirm within the test timeout. Fix orderstatus test Badger
DB lock by disabling wallets after disconnect to prevent background
bond maintenance from reconnecting old wallets. Skip EVM balance
assertions in missedcpaddr test (same rationale as simpleTradeTest).

Clamp test order rates to the market minimum rate so markets like
zec_btc with high minimum rates don't reject orders. Bump ZEC simnet
maxFeeRate from 200 to 10000 to match the wallet's ZIP-317 fee rate.

Add new markets (LTC/DASH, DOGE/POLYGON, BCH/ETH, FIRO/BTC) to
enable running more test pairs in parallel without wallet conflicts.

Switch EVM harness connections from IPC to websocket endpoints in both
simnet trade tests and loadbot. Add build commit/dirty logging to the
run script. Add README for simnet-trade-tests.

Document per-match address design rationale in server/swap/swap.go
and client/core/trade.go.

* zec: Fix refund fee calculation for ZIP-317 compliance.

The refund was passing the per-action fee rate (5000 zats) as the
absolute fee, but a refund tx has 2 logical actions under ZIP-317,
requiring 10,000 zats. Calculate the proper fee using TxFeesZIP317
based on actual input/output sizes.

* btc: Retry block tx lookup in FindRedemption for multi-node setups.

In multi-node configurations (e.g. DASH), there can be a delay between
one node reporting a transaction in a block via gettransaction and that
block's full data being available from getblock on a different node.
Add a retry loop (up to 10 attempts with 1s delay) in
checkRedemptionBlockDetails to handle this race condition.

* multi: DRY up v1 token gas values and fix simnet.

Define tokenV1Gases once per chain (eth, polygon, base) from the
measured usdt mainnet values and reference it everywhere instead of
duplicating the same gas values across every token and network. Also
fix simnet v1 token gas estimates that were either empty or incorrectly
measured from ETH native swaps instead of token swaps.

* ui: Fix wallet unlock affecting all networks for same ticker.

openWallet was iterating over all networkAssets sharing the same
normalized ticker and unlocking every one. This meant unlocking ETH
on Ethereum would also unlock ETH on Base. The lock side already
operated on individual assets. Align unlock to match.

* ui: Show disabled state for individually disabled token wallets.

The per-network wallet row and actions modal only checked the parent
wallet's disabled state. A token wallet disabled independently (e.g.
polygon.eth via RPC) would appear enabled in the UI with no way to
re-enable it. Now both the status icon and the Enable action check
the token wallet's own disabled flag.

Author: JoeGruffins

client/asset/btc/redemption_finder.go

@@ -191,15 +191,28 @@ func (r *RedemptionFinder) checkRedemptionBlockDetails(outPt OutPoint, blockHash
 	}
 
 	var tx *wire.MsgTx
-out:
-	for _, iTx := range blk.Transactions {
-		if *r.hashTx(iTx) == outPt.TxHash {
-			tx = iTx
-			break out
+	for try := 0; ; try++ {
+		for _, iTx := range blk.Transactions {
+			if *r.hashTx(iTx) == outPt.TxHash {
+				tx = iTx
+				break
+			}
+		}
+		if tx != nil {
+			break
+		}
+		if try >= 10 {
+			return 0, fmt.Errorf("transaction %s not found in block %s after retries", outPt.TxHash, blockHash)
+		}
+		// Multi-node setups can have a delay between one node reporting
+		// a transaction in a block and that block's full data being
+		// available from getblock. Retry with a short delay.
+		r.log.Debugf("Transaction %s not yet found in block %s (attempt %d), retrying...", outPt.TxHash, blockHash, try+1)
+		time.Sleep(time.Second)
+		blk, err = r.getBlock(*blockHash)
+		if err != nil {
+			return 0, fmt.Errorf("error re-retrieving block %s: %w", blockHash, err)
 		}
-	}
-	if tx == nil {
-		return 0, fmt.Errorf("transaction %s not found in block %s", outPt.TxHash, blockHash)
 	}
 	if uint32(len(tx.TxOut)) < outPt.Vout+1 {
 		return 0, fmt.Errorf("no output %d in redemption transaction %s found in block %s", outPt.Vout, outPt.TxHash, blockHash)

client/asset/polygon/polygon.go

@@ -97,6 +97,13 @@ var (
 	}
 )
 
+func polygonFinalizeConfs(net dex.Network) uint64 {
+	if net == dex.Simnet {
+		return 2
+	}
+	return 64
+}
+
 type Driver struct{}
 
 // Open opens the Polygon exchange wallet. Start the wallet with its Run method.
@@ -149,7 +156,7 @@ func (d *Driver) Open(cfg *asset.WalletConfig, logger dex.Logger, net dex.Networ
 		CompatData:         &compat,
 		VersionedGases:     dexpolygon.VersionedGases,
 		Tokens:             dexpolygon.Tokens,
-		FinalizeConfs:      64,
+		FinalizeConfs:      polygonFinalizeConfs(net),
 		Logger:             logger,
 		BaseChainContracts: contracts,
 		MultiBalAddress:    dexpolygon.MultiBalanceAddresses[net],

client/asset/zec/zec.go

@@ -2028,7 +2028,13 @@ func (w *zecWallet) Refund(ctx context.Context, coinID, contract dex.Bytes, feeR
 	if utxo == nil {
 		return nil, asset.CoinNotFoundError // spent
 	}
-	msgTx, err := w.refundTx(ctx, txHash, vout, contract, uint64(utxo.Value), nil, feeRate)
+	// Calculate ZIP-317 compliant fees for the refund tx. The feeRate
+	// parameter is per-action, but ZIP-317 requires fees based on logical
+	// actions derived from tx structure, not a simple rate.
+	var inputsSize uint64 = dexbtc.TxInOverhead + dexbtc.RefundSigScriptSize + 1
+	var outputsSize uint64 = dexbtc.P2PKHOutputSize + 1
+	refundFees := dexzec.TxFeesZIP317(inputsSize, outputsSize, 0, 0, 0, 0)
+	msgTx, err := w.refundTx(ctx, txHash, vout, contract, uint64(utxo.Value), nil, refundFees)
 	if err != nil {
 		return nil, fmt.Errorf("error creating refund tx: %w", err)
 	}

client/cmd/simnet-trade-tests/README.md

@@ -0,0 +1,120 @@
+# Simnet Trade Tests
+
+End-to-end integration tests that exercise real trades on simnet using asset
+harnesses. Two simulated DEX clients place orders, match, and settle (or fail
+to settle) across a variety of scenarios.
+
+## Prerequisites
+
+Start the asset harnesses for the pair you want to test, then start the dcrdex
+harness. For example, to test DCR-BTC:
+
+```sh
+cd ~/dextest
+./dcr/harness.sh
+./btc/harness.sh
+./dcrdex/harness.sh
+```
+
+The asset harnesses run background miners (`watch -n 15 ./mine-alpha 1`) by
+default. The trade tests mine their own blocks at specific points, so
+background mining can interfere with confirmation counting. Disable it by
+exporting `NOMINER=1` before starting each asset harness:
+
+```sh
+export NOMINER=1
+./dcr/harness.sh
+./btc/harness.sh
+```
+
+## Building
+
+The tests require the `harness` build tag:
+
+```sh
+go build -tags harness ./client/cmd/simnet-trade-tests/
+```
+
+## Running
+
+The easiest way is through the `run` script, which rebuilds with shortened swap
+lock times (3m taker, 6m maker) and selects the right node flags for each pair:
+
+```sh
+./run dcrbtc
+```
+
+Run `./run help` to see all pre-configured pairs and available flags.
+
+### Pre-configured pairs
+
+| Command            | Market          | Notes                         |
+| ------------------ | --------------- | ----------------------------- |
+| `dcrbtc`           | DCR-BTC         | RPC wallets                   |
+| `dcrspvbtc`        | DCR-BTC         | DCR SPV, BTC RPC              |
+| `dcrbtcspv`        | DCR-BTC         | DCR RPC, BTC SPV              |
+| `dcrbtcelectrum`   | DCR-BTC         | DCR RPC, BTC Electrum         |
+| `bchdcr`           | BCH-DCR         | RPC wallets                   |
+| `bchspvdcr`        | BCH-DCR         | BCH SPV, DCR RPC              |
+| `ltcdcr`           | LTC-DCR         | RPC wallets                   |
+| `ltcspvdcr`        | LTC-DCR         | LTC SPV, DCR RPC              |
+| `ltcelectrumdcr`   | LTC-DCR         | LTC Electrum, DCR RPC         |
+| `dcrdash`          | DCR-DASH        | RPC wallets                   |
+| `dcrdoge`          | DCR-DOGE        | RPC wallets                   |
+| `dcrdgb`           | DCR-DGB         | RPC wallets                   |
+| `dcreth`           | DCR-ETH         | DCR RPC, ETH native           |
+| `dcrfiro`          | DCR-FIRO        | RPC wallets                   |
+| `dcrfiroelectrum`  | DCR-FIRO        | DCR RPC, FIRO Electrum        |
+| `zecbtc`           | ZEC-BTC         | RPC wallets                   |
+| `dcrusdc`          | DCR-USDC.ETH    | ERC-20 token on Ethereum      |
+| `polygondcr`       | POLYGON-DCR     | Polygon RPC, DCR RPC          |
+| `dcrusdcpolygon`   | DCR-USDC.POLYGON| ERC-20 token on Polygon       |
+| `zclbtc`           | ZCL-BTC         | RPC wallets                   |
+
+### Selecting tests
+
+By default only the `success` test runs. Use `-t` to pick specific tests, or
+`--all` to run everything:
+
+```sh
+./run dcrbtc -t success -t nomakerswap
+./run dcrbtc --all
+./run dcrbtc --all --except=orderstatus
+```
+
+Available tests:
+
+| Test             | Description                                              |
+| ---------------- | -------------------------------------------------------- |
+| `success`        | Complete trade with swaps and redeems on both sides      |
+| `nomakerswap`    | Maker fails to send swap tx                              |
+| `notakerswap`    | Taker fails to swap; refund after locktime               |
+| `nomakerredeem`  | Maker fails to redeem; both sides refund                 |
+| `makerghost`     | Maker disappears after taker redeems; auto-redeem tested |
+| `orderstatus`    | Order status recovery after client disconnection         |
+| `resendpending`  | Resending of pending trade requests                      |
+| `notakeraddr`    | Taker omits per-match swap address; taker penalized      |
+| `nomakeraddr`    | Maker omits per-match swap address; maker penalized      |
+| `notakerredeem`  | Taker fails to redeem after maker redeems; taker penalty |
+| `missedcpaddr`   | Counterparty address re-delivered after reconnect        |
+
+Each test runs twice by default, swapping which client is maker and which is
+taker. Pass `--runonce` to only run each test once.
+
+### Other useful flags
+
+```
+--debug          Log at debug level
+--trace          Log at trace level
+--color <color>  Log color: green (default), white, blue, yellow, magenta, red
+--regasset <sym> Asset for bond registration (default: base asset)
+```
+
+## Troubleshooting
+
+- **"coin locked"** - The DEX hasn't revoked a previously failed match. Wait a
+  few seconds and retry, or clear the dcrdex db and restart the dcrdex harness.
+- **"not enough to cover requested funds"** - Use the asset harness to send
+  more funds to the affected wallet.
+- **Fee payment confirmation issues** - Restart the dcr harness then the dcrdex
+  harness (stop dcrdex first).

client/cmd/simnet-trade-tests/main.go

@@ -10,6 +10,7 @@ import (
 
 	"decred.org/dcrdex/client/core"
 	"decred.org/dcrdex/dex"
+	dexbase "decred.org/dcrdex/dex/networks/base"
 	dexeth "decred.org/dcrdex/dex/networks/eth"
 	dexpolygon "decred.org/dcrdex/dex/networks/polygon"
 	"github.com/fatih/color"
@@ -223,4 +224,5 @@ func (f *flagArray) Set(value string) error {
 func init() {
 	dexeth.MaybeReadSimnetAddrs()
 	dexpolygon.MaybeReadSimnetAddrs()
+	dexbase.MaybeReadSimnetAddrs()
 }

client/cmd/simnet-trade-tests/run

@@ -1,6 +1,8 @@
 #!/bin/bash
 set -e
 
+echo "Building simnet-trade-tests at commit $(git rev-parse --short HEAD) ($(git diff --stat --quiet 2>/dev/null && echo 'clean' || echo 'dirty'))"
+
 go build -tags harness -ldflags \
     "-X 'decred.org/dcrdex/dex.testLockTimeTaker=3m' \
     -X 'decred.org/dcrdex/dex.testLockTimeMaker=6m'"
@@ -28,11 +30,6 @@ case $1 in
 		--regasset dcr ${@:2}
     ;;
 
-  bchspvdcr)
-    ./simnet-trade-tests --base bch --quote dcr --quote1node trading1 --quote2node trading2 \
-		--regasset dcr --base1type=spv ${@:2}
-    ;;
-
   ltcdcr)
     ./simnet-trade-tests --base ltc --quote dcr --quote1node trading1 --quote2node trading2 \
 		--regasset dcr ${@:2}
@@ -66,6 +63,10 @@ case $1 in
     ./simnet-trade-tests --base1node trading1 --base2node trading2 --quote eth ${@:2}
     ;;
 
+  dcrspveth)
+    ./simnet-trade-tests --base1node trading1 --base2node trading2 --quote eth --base1type spv ${@:2}
+    ;;
+
   dcrfiro)
     ./simnet-trade-tests --base1node trading1 --base2node trading2 --quote firo ${@:2}
     ;;
@@ -90,6 +91,67 @@ case $1 in
     ./simnet-trade-tests --quote1node trading1 --quote2node trading2 --base usdc.polygon --quote dcr --regasset dcr  ${@:2}
     ;;
 
+  ethbtc)
+    ./simnet-trade-tests --base eth --quote btc --regasset btc ${@:2}
+    ;;
+
+  ltceth)
+    ./simnet-trade-tests --base ltc --quote eth --regasset ltc ${@:2}
+    ;;
+
+  bchpolygon)
+    ./simnet-trade-tests --base bch --quote polygon --regasset bch ${@:2}
+    ;;
+
+  ltcdash)
+    ./simnet-trade-tests --base ltc --quote dash --regasset ltc \
+		--quote1node gamma --quote2node delta ${@:2}
+    ;;
+
+  dogepolygon)
+    ./simnet-trade-tests --base doge --quote polygon --regasset doge ${@:2}
+    ;;
+
+  bcheth)
+    ./simnet-trade-tests --base bch --quote eth --regasset bch ${@:2}
+    ;;
+
+  ltcspveth)
+    ./simnet-trade-tests --base ltc --quote eth --regasset ltc --base1type spv ${@:2}
+    ;;
+
+  firobtc)
+    ./simnet-trade-tests --base firo --quote btc --regasset btc ${@:2}
+    ;;
+
+  firobtcspv)
+    ./simnet-trade-tests --base firo --quote btc --regasset btc --quote1type spv ${@:2}
+    ;;
+
+  firodoge)
+    ./simnet-trade-tests --base firo --quote doge --regasset doge ${@:2}
+    ;;
+
+  btcusdceth)
+    ./simnet-trade-tests --base btc --quote usdc.eth --regasset btc ${@:2}
+    ;;
+
+  btcusdteth)
+    ./simnet-trade-tests --base btc --quote usdt.eth --regasset btc ${@:2}
+    ;;
+
+  ltcusdcbase)
+    ./simnet-trade-tests --base ltc --quote usdc.base --regasset ltc ${@:2}
+    ;;
+
+  dcrusdtpolygon)
+    ./simnet-trade-tests --base1node trading1 --base2node trading2 --quote usdt.polygon ${@:2}
+    ;;
+
+  dcrusdtbase)
+    ./simnet-trade-tests --base1node trading1 --base2node trading2 --quote usdt.base ${@:2}
+    ;;
+
   zclbtc)
     ./simnet-trade-tests --base zcl --quote btc --regasset btc ${@:2}
     ;;
@@ -107,20 +169,35 @@ dcrspvbtc - Decred SPV wallet and Bitcoin RPC wallet on DCR-BTC
 dcrbtcspv - Decred RPC wallet and Bitcoin SPV wallet on DCR-BTC market
 dcrbtcelectrum - Decred RPC wallet and Bitcoin Electrum wallet on DCR-BTC market
 bchdcr - RPC wallets on BCH-DCR market
-bchspvdcr - Bitcoin Cash SPV wallet and Decred RPC Wallet on BCH-DCR market
 ltcdcr - RPC wallets on LTC-DCR market
 ltcspvdcr - Litecoin SPV wallet and Decred RPC Wallet on LTC-DCR market
 ltcelectrumdcr - Litecoin Electrum wallet and Decred RPC wallet on LTC-DCR market
 dcrdash - RPC wallets on DCR-DASH market
 dcrdoge - RPC wallets on DCR-DOGE market
 dcrdgb - RPC wallets on DCR-DGB market
 dcreth - Decred RPC wallet and Ethereum RPC wallet on DCR-ETH market
+dcrspveth - Decred SPV wallet and Ethereum wallet on DCR-ETH market
 dcrfiro - RPC wallets on DCR-FIRO market
 dcrfiroelectrum - Decred RPC wallet and Firo Electrum wallet on DCR-FIRO market
 zecbtc - RPC wallets on ZEC-BTC market
 dcrusdc - Decred RPC wallet and Ethereum wallet with usdc.eth test token on market DCR-USDC.ETH
 polygondcr - Decred RPC wallet and Polygon RPC wallet on POLYGON-DCR market
 dcrusdcpolygon - Decred RPC wallet and Polygon wallet with usdc.polygon test token on market DCR-USDC.POLYGON
+ethbtc - Ethereum wallet and Bitcoin RPC wallet on ETH-BTC market
+ltceth - Litecoin RPC wallet and Ethereum wallet on LTC-ETH market
+bchpolygon - Bitcoin Cash RPC wallet and Polygon wallet on BCH-POLYGON market
+ltcdash - Litecoin RPC wallet and Dash RPC wallet on LTC-DASH market
+dogepolygon - Dogecoin RPC wallet and Polygon wallet on DOGE-POLYGON market
+bcheth - Bitcoin Cash RPC wallet and Ethereum wallet on BCH-ETH market
+ltcspveth - Litecoin SPV wallet and Ethereum wallet on LTC-ETH market
+firobtc - Firo RPC wallet and Bitcoin RPC wallet on FIRO-BTC market
+firobtcspv - Firo RPC wallet and Bitcoin SPV wallet on FIRO-BTC market
+firodoge - Firo RPC wallet and Dogecoin RPC wallet on FIRO-DOGE market
+btcusdceth - Bitcoin RPC wallet and USDC.ETH token on BTC-USDC.ETH market
+btcusdteth - Bitcoin RPC wallet and USDT.ETH token on BTC-USDT.ETH market
+ltcusdcbase - Litecoin RPC wallet and USDC.BASE token on LTC-USDC.BASE market
+dcrusdtpolygon - Decred RPC wallet and USDT.POLYGON token on DCR-USDT.POLYGON market
+dcrusdtbase - Decred RPC wallet and USDT.BASE token on DCR-USDT.BASE market
 zclbtc - Zclassic RPC wallet and Bitcoin RPC wallet on ZCL-BTC
 
 ---------------------