Optional relation incorrectly mapped on JsonResource

[apasquini95]

Hi everyone, I'm having an issue with a model's JsonResource while mapping an optional relation. These are the models:

Schema::create('my_models', function (Blueprint $table) {
    $table->id();
    $table->string('name');
});
        
Schema::create('my_related_models', function (Blueprint $table) {
    $table->id();
    $table->foreignIdFor(\App\Models\MyModel::class)->constrained();
    $table->integer('value');
});

/**
 * @property int $id
 * @property string $name
 */
class MyModel extends Model
{
    /**
     * Summary of relatedModel
     * @return HasOne<MyRelatedModel, MyModel>
     */
    public function relatedModel(): HasOne
    {
        return $this->hasOne(MyRelatedModel::class);
    }
}

/**
 * @property int $id
 * @property int $value
 */
class MyRelatedModel extends Model
{
    //
}

Once I configure the MyModelResource optionally adding a field representing the value property of an optional related model, the generated openapi specification fallbacks to string instead of integer:

/**
 * @property \App\Models\MyModel $resource
 * @mixin \App\Models\MyModel
 */
class MyModelResource extends JsonResource
{
    /**
     * Transform the resource into an array.
     *
     * @return array<string, mixed>
     */
    public function toArray(Request $request): array
    {
        return [
            'id' => $this->resource->id,
            'related' => $this->whenNotNull($this->resource->relatedModel?->value)
        ];
    }
}

{
    "components": {
        "schemas": {
            "MyModelResource": {
                "type": "object",
                "properties": {
                    "id": {
                        "type": "integer"
                    },
                    "related": {
                        "type": "string"       // <-- Why is this string?
                    }
                },
                "required": [
                    "id"
                ],
                "title": "MyModelResource"
            }
        }
    }
}

Obviously if I explicitly declare the type with a phpdoc it works, but I wondered if there's a way to make this automatic:

  return [
      'id' => $this->resource->id,
      /** @var int */
      'related' => $this->whenNotNull($this->resource->relatedModel?->value)
  ];

Am I missing something?
For this purpose I created a branch for reproduction in this repository:
https://github.com/apasquini95/demo_scramble/tree/optional_relation_resource_property

[romalytvynenko]

@apasquini95 Seems like Scramble is not aware of ?-> operator.

Do you think you want to create a PR for this?

This should be a simple one.

The only difference with -> operator (method call expression, look at Scope class) is that ?-> expression produces MethodCallReferenceType|null type (union). Scramble will take care of handling MethodCallReferenceType.