Request param with rule date_format:H:i has incorrect format

[apasquini95]

Hi everyone, I'm having an issue with a FormRequest when it has a field of type string, which is validated against the rule date_format:H:i:

class MyRequest extends FormRequest
{
    /**
     * Get the validation rules that apply to the request.
     *
     * @return array<string, string>
     */
    public function rules(): array
    {
        return [
            'my_param' => ['required', 'string', 'date_format:H:i']
        ];
    }
}

It might seem strange, but the aim of this request body is to be sure to have as input a valid time string (excluding seconds). For example:

{
  "my_param" : "15:30"
}

The generated openapi specification for this request body gives the additional information of format using the type date:

{
  "schemas": {
      "MyRequest": {
          "type": "object",
          "properties": {
              "my_param": {
                  "type": "string",
                  "format": "date"        // <-- Is it really a date-string?
              }
          },
          "required": [
              "my_param"
          ],
          "title": "MyRequest"
      }
  }
}

This format causes me an issue with my openapi-typescript converter, because I set a convertion rule which maps the format: date to a Date type. But Is really a string with the format H:i a date? Since Laravel allows using any format in date_format rule, wouldn't it be safer if only the full date/date-time formats would be treated as valid date-strings? For example:

• Y-m-d -> date
• Y-m-d H:i:s -> date-time
• m-d -> string
• H:i -> string

and so on...

If this is not possible, can I override the format in the request body? I tried to put a phpdoc over the field as I used to do in JsonResource, but it doesn't work:

public function rules(): array
{
    return [
        /** @format H:i */
        'my_param' => ['required', 'string', 'date_format:H:i']
    ];
}

For this purpose I created a branch for reproduction on this repository:
https://github.com/apasquini95/demo_scramble/tree/request_date_format

[romalytvynenko]

Hey @apasquini95

Yup, seems legit!

Would you mind creating a PR? It also looks like a simple one!

[apasquini95]

#983