fix(typink): persisted neworks (#285)

* fix persisted networks with reset default networks

* tests

* fix ci

* clean up

Author: sinzii

packages/typink/src/atoms/clientAtoms.ts

@@ -11,6 +11,14 @@ export const networkConnectionsAtom = atomWithStorage<NetworkConnection[]>(
   { getOnInit: true },
 );
 
+// Persistent atom for storing the intended default network IDs as JSON string to detect changes
+export const persistedDefaultNetworkIdsAtom = atomWithStorage<string>(
+  'TYPINK::DEFAULT_NETWORK_IDS',
+  '',
+  undefined,
+  { getOnInit: true },
+);
+
 // Atom for supported networks (set during provider initialization)
 export const supportedNetworksAtom = atom<NetworkInfo[]>([]);
 

packages/typink/src/hooks/__tests__/useCheckMappedAccount.test.ts

@@ -39,6 +39,10 @@ describe('useCheckMappedAccount', () => {
   };
 
   beforeEach(() => {
+    // Mock console methods to suppress expected error messages
+    vi.spyOn(console, 'error').mockImplementation(() => {});
+    vi.spyOn(console, 'warn').mockImplementation(() => {});
+
     vi.mocked(useTypink).mockReturnValue(defaultMockTypink as any);
     vi.mocked(usePolkadotClient).mockReturnValue({
       client: mockClient,

packages/typink/src/hooks/__tests__/useLazyStorage.test.ts

@@ -73,6 +73,10 @@ const createMockContract = (lazyStorageData: any): Contract<MockContractApi> =>
 
 describe('useLazyStorage', () => {
   beforeEach(() => {
+    // Mock console methods to suppress expected error messages
+    vi.spyOn(console, 'error').mockImplementation(() => {});
+    vi.spyOn(console, 'warn').mockImplementation(() => {});
+
     vi.clearAllMocks();
   });
 
@@ -247,7 +251,7 @@ describe('useLazyStorage', () => {
     expect(callCount).toBe(1);
 
     // Trigger refresh
-    result.current.refresh();
+    await result.current.refresh();
 
     await waitFor(() => {
       expect(result.current.isRefreshing).toBe(false);

packages/typink/src/hooks/__tests__/useRootStorage.test.ts

@@ -14,6 +14,10 @@ describe('useRootStorage', () => {
   let mockContract: any;
 
   beforeEach(() => {
+    // Mock console methods to suppress expected error messages
+    vi.spyOn(console, 'error').mockImplementation(() => {});
+    vi.spyOn(console, 'warn').mockImplementation(() => {});
+
     mockClient = {
       query: {
         system: {

packages/typink/src/providers/ClientProvider.tsx

@@ -15,6 +15,7 @@ import {
   currentNetworkAtom,
   currentNetworksAtom,
   networkConnectionsAtom,
+  persistedDefaultNetworkIdsAtom,
   setNetworkAtom,
   setNetworksAtom,
   supportedNetworksAtom,
@@ -156,26 +157,49 @@ export function ClientProvider({
   // Get network connections from localStorage (via atomWithStorage)
   const [networkConnections, setNetworkConnections] = useAtom(networkConnectionsAtom);
 
+  // Get persisted default network IDs from localStorage (as JSON string)
+  const [persistedDefaultNetworkIdsJson, setPersistedDefaultNetworkIdsJson] = useAtom(persistedDefaultNetworkIdsAtom);
+
   // Initialize network connections and default network ID properly
   useMemo(() => {
     if (supportedNetworks.length === 0) return;
 
+    // Extract current default network IDs from initialConnections
+    const currentDefaultNetworkIdsJson = JSON.stringify(initialConnections);
+
     // Check if we have stored connections from localStorage
     if (networkConnections.length === 0 && initialConnections.length > 0) {
       setNetworkConnections(initialConnections);
+      setPersistedDefaultNetworkIdsJson(currentDefaultNetworkIdsJson);
     } else if (networkConnections.length > 0) {
-      // Check if all existing connections are in the supported networks or default networks list
+      // Check if default network IDs have changed (simple string comparison)
+      const defaultNetworkIdsChanged =
+        !!persistedDefaultNetworkIdsJson && persistedDefaultNetworkIdsJson !== currentDefaultNetworkIdsJson;
+
+      // Check if default network IDs have changed (developer changed defaultNetworkIds/defaultNetworkId)
+      if (defaultNetworkIdsChanged) {
+        console.log(`Default network configuration changed. Resetting to new default networks.`);
+        setNetworkConnections(initialConnections);
+        setPersistedDefaultNetworkIdsJson(currentDefaultNetworkIdsJson);
+        return; // Skip further validation since we're resetting
+      }
+
+      // If we don't have persisted default network IDs yet (first run), store them
+      if (!persistedDefaultNetworkIdsJson) {
+        setPersistedDefaultNetworkIdsJson(currentDefaultNetworkIdsJson);
+      }
+
+      // Check if all existing connections are in the supported networks
       const hasInvalidNetwork = networkConnections.some(
-        (conn) =>
-          !supportedNetworks.find((n) => n.id === conn.networkId) ||
-          !initialConnections.find((n) => n.networkId === conn.networkId),
+        (conn) => !supportedNetworks.find((n) => n.id === conn.networkId),
       );
 
       if (hasInvalidNetwork) {
         console.warn(
           'Some persisted network connections are not in the supported networks list. Resetting to default networks.',
         );
         setNetworkConnections(initialConnections);
+        setPersistedDefaultNetworkIdsJson(currentDefaultNetworkIdsJson);
       }
     }
   }, []); // Empty deps - only runs once on mount

packages/typink/src/providers/__tests__/ClientProvider.integration.test.tsx

@@ -1,4 +1,4 @@
-import { beforeEach, describe, expect, it } from 'vitest';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { renderHook } from '@testing-library/react';
 import { ClientProvider, useClient } from '../ClientProvider.js';
 import { NetworkInfo } from '../../types.js';
@@ -30,12 +30,21 @@ describe('ClientProvider Integration Tests', () => {
   beforeEach(() => {
     // Create fresh store for each test
     store = createStore();
+
+    // Mock console methods to suppress expected error messages
+    vi.spyOn(console, 'error').mockImplementation(() => {});
+    vi.spyOn(console, 'warn').mockImplementation(() => {});
+
     // Clear localStorage to ensure clean state
     if (typeof window !== 'undefined' && window.localStorage) {
       window.localStorage.clear();
     }
   });
 
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
   describe('Single Client Mode (Backward Compatibility)', () => {
     it('should provide client context with single network', () => {
       const wrapper = ({ children }: { children: React.ReactNode }) => (