Fix: Nil pointer exception on is_instance_group,is_instance_group_manager, is_instance_gropu_manager_policy

Author: kavya498

ibm/resource_ibm_is_instance_group.go

@@ -220,7 +220,7 @@ func resourceIBMISInstanceGroupCreate(d *schema.ResourceData, meta interface{})
 	}
 
 	instanceGroup, response, err := sess.CreateInstanceGroup(&instanceGroupOptions)
-	if err != nil {
+	if err != nil || instanceGroup == nil {
 		return fmt.Errorf("Error Creating InstanceGroup: %s\n%s", err, response)
 	}
 	d.SetId(*instanceGroup.ID)
@@ -258,7 +258,7 @@ func resourceIBMISInstanceGroupUpdate(d *schema.ResourceData, meta interface{})
 		instanceGroupID := d.Id()
 		getInstanceGroupOptions := vpcv1.GetInstanceGroupOptions{ID: &instanceGroupID}
 		instanceGroup, response, err := sess.GetInstanceGroup(&getInstanceGroupOptions)
-		if err != nil {
+		if err != nil || instanceGroup == nil {
 			return fmt.Errorf("Error getting instance group: %s\n%s", err, response)
 		}
 		oldList, newList := d.GetChange("tags")
@@ -342,7 +342,7 @@ func resourceIBMISInstanceGroupRead(d *schema.ResourceData, meta interface{}) er
 	instanceGroupID := d.Id()
 	getInstanceGroupOptions := vpcv1.GetInstanceGroupOptions{ID: &instanceGroupID}
 	instanceGroup, response, err := sess.GetInstanceGroup(&getInstanceGroupOptions)
-	if err != nil {
+	if err != nil || instanceGroup == nil {
 		if response != nil && response.StatusCode == 404 {
 			d.SetId("")
 			return nil
@@ -397,7 +397,7 @@ func resourceIBMISInstanceGroupDelete(d *schema.ResourceData, meta interface{})
 	instanceGroupPatchModel := vpcv1.InstanceGroupPatch{}
 
 	instanceGroupPatchModel.MembershipCount = &zeroMembers
-	instanceGroupPatch, _ := instanceGroupPatchModel.AsPatch()
+	instanceGroupPatch, err := instanceGroupPatchModel.AsPatch()
 	if err != nil {
 		return fmt.Errorf("Error calling asPatch for ImagePatch: %s", err)
 	}
@@ -461,10 +461,11 @@ func waitForHealthyInstanceGroup(d *schema.ResourceData, meta interface{}, timeo
 		Target:  []string{HEALTHY},
 		Refresh: func() (interface{}, string, error) {
 			instanceGroup, response, err := sess.GetInstanceGroup(&getInstanceGroupOptions)
-			log.Println("Status : ", *instanceGroup.Status)
-			if err != nil {
+			if err != nil || instanceGroup == nil {
 				return nil, SCALING, fmt.Errorf("Error Getting InstanceGroup: %s\n%s", err, response)
 			}
+			log.Println("Status : ", *instanceGroup.Status)
+
 			if *instanceGroup.Status == "" {
 				return instanceGroup, SCALING, nil
 			}

ibm/resource_ibm_is_instance_group_manager.go

@@ -194,7 +194,7 @@ func resourceIBMISInstanceGroupManagerCreate(d *schema.ResourceData, meta interf
 		InstanceGroupManagerPrototype: &instanceGroupManagerPrototype,
 	}
 	instanceGroupManager, response, err := sess.CreateInstanceGroupManager(&createInstanceGroupManagerOptions)
-	if err != nil {
+	if err != nil || instanceGroupManager == nil {
 		return fmt.Errorf("Error creating InstanceGroup manager: %s\n%s", err, response)
 	}
 	d.SetId(fmt.Sprintf("%s/%s", instanceGroupID, *instanceGroupManager.ID))
@@ -289,7 +289,7 @@ func resourceIBMISInstanceGroupManagerRead(d *schema.ResourceData, meta interfac
 		InstanceGroupID: &instanceGroupID,
 	}
 	instanceGroupManager, response, err := sess.GetInstanceGroupManager(&getInstanceGroupManagerOptions)
-	if err != nil {
+	if err != nil || instanceGroupManager == nil {
 		if response != nil && response.StatusCode == 404 {
 			d.SetId("")
 			return nil

ibm/resource_ibm_is_instance_group_manager_policy.go

@@ -126,7 +126,7 @@ func resourceIBMISInstanceGroupManagerPolicyCreate(d *schema.ResourceData, meta
 		InstanceGroupManagerPolicyPrototype: &instanceGroupManagerPolicyPrototype,
 	}
 	data, response, err := sess.CreateInstanceGroupManagerPolicy(&createInstanceGroupManagerPolicyOptions)
-	if err != nil {
+	if err != nil || data == nil {
 		return fmt.Errorf("Error Creating InstanceGroup Manager Policy: %s\n%s", err, response)
 	}
 	instanceGroupManagerPolicy := data.(*vpcv1.InstanceGroupManagerPolicy)
@@ -205,7 +205,7 @@ func resourceIBMISInstanceGroupManagerPolicyRead(d *schema.ResourceData, meta in
 		InstanceGroupManagerID: &instanceGroupManagerID,
 	}
 	data, response, err := sess.GetInstanceGroupManagerPolicy(&getInstanceGroupManagerPolicyOptions)
-	if err != nil {
+	if err != nil || data == nil {
 		if response != nil && response.StatusCode == 404 {
 			d.SetId("")
 			return nil