fix mcp bugs

Author: marktayl1

src/mcp_server/services/hr_service.py

@@ -18,6 +18,32 @@ def __init__(self):
     def register_tools(self, mcp) -> None:
         """Register HR tools with the MCP server."""
 
+        @mcp.tool(tags={self.domain.value})
+        async def onboard_employee() -> str:
+            """Always use the following onboarding checklist for all new Contoso employees.  These are the only steps needed to onboard any new employee."""
+            onboarding_checklist = """
+
+            ## HR representative must...
+            - initiate background check
+            - schedule orientation session
+            - assign a mentor
+            - register for benefits
+            - provide employee handbook
+            - request ID card
+            - set up payroll
+
+            ## Technical Support representative must...
+            - setup Office 365 account
+            - configure laptop
+            - setup VPN access
+            - create system accounts
+            - send welcome email
+
+            ## No other onboarding steps are required for any employee
+
+            """
+            return f"Here are the necessary steps to onboard a new Contoso employee: {onboarding_checklist}."
+
         @mcp.tool(tags={self.domain.value})
         async def schedule_orientation_session(employee_name: str, date: str) -> str:
             """Schedule an orientation session for a new employee."""
@@ -61,32 +87,6 @@ async def assign_mentor(employee_name: str, mentor_name: str = "TBD") -> str:
                     error_message=str(e), context="assigning mentor"
                 )
 
-        @mcp.tool(tags={self.domain.value})
-        async def standard_employee_onboarding_checklist() -> str:
-            """Gets the total onboarding steps required for all new Contoso employees.  These are the only steps needed to onboard any new employee."""
-            onboarding_steps = """
-
-            ## HR representative must...
-            - initiate background check
-            - schedule orientation session
-            - assign a mentor
-            - register for benefits
-            - provide employee handbook
-            - request ID card
-            - set up payroll
-
-            ## Technical Support representative must...
-            - setup Office 365 account
-            - configure laptop
-            - setup VPN access
-            - create system accounts
-            - send welcome email
-
-            ## No other onboarding steps are required for any employee
-
-            """
-            return f"Here are the necessary steps to onboard a new Contoso employee: {onboarding_steps}."
-
         @mcp.tool(tags={self.domain.value})
         async def register_for_benefits(
             employee_name: str, benefits_package: str = "Standard"

src/mcp_server/services/marketing_service.py

@@ -13,7 +13,7 @@ class MarketingService(MCPToolBase):
     """Marketing tools for employee onboarding and management."""
 
     def __init__(self):
-        super().__init__(Domain.HR)
+        super().__init__(Domain.MARKETING)
 
     def register_tools(self, mcp) -> None:
         """Register Marketing tools with the MCP server."""

src/mcp_server/services/product_service.py

@@ -13,7 +13,7 @@ class ProductService(MCPToolBase):
     """Product tools for employee onboarding and management."""
 
     def __init__(self):
-        super().__init__(Domain.HR)
+        super().__init__(Domain.PRODUCT)
 
     def register_tools(self, mcp) -> None:
         """Register Product tools with the MCP server."""