Improved test coverage for Assumption.

Signed-off-by: Marvin Hansen <[email protected]>

Author: marvin-hansen

deep_causality/src/traits/assumable/mod.rs

@@ -3,9 +3,7 @@
  * Copyright (c) "2025" . The DeepCausality Authors and Contributors. All Rights Reserved.
  */
 
-use crate::{
-    AssumptionError, DescriptionValue, EvalFn, Identifiable, NumericalValue, PropagatingEffect,
-};
+use crate::{AssumptionError, DescriptionValue, Identifiable, NumericalValue, PropagatingEffect};
 
 /// The Assumable trait defines the interface for objects that represent
 /// assumptions that can be tested and verified. Assumable types must also
@@ -27,7 +25,6 @@ use crate::{
 ///
 pub trait Assumable: Identifiable {
     fn description(&self) -> DescriptionValue;
-    fn assumption_fn(&self) -> EvalFn;
     fn assumption_tested(&self) -> bool;
     fn assumption_valid(&self) -> bool;
     fn verify_assumption(&self, data: &[PropagatingEffect]) -> Result<bool, AssumptionError>;

deep_causality/src/types/model_types/assumption/assumable.rs

@@ -3,17 +3,13 @@
  * Copyright (c) "2025" . The DeepCausality Authors and Contributors. All Rights Reserved.
  */
 use crate::types::model_types::assumption::Assumption;
-use crate::{Assumable, AssumptionError, DescriptionValue, EvalFn, PropagatingEffect};
+use crate::{Assumable, AssumptionError, DescriptionValue, PropagatingEffect};
 
 impl Assumable for Assumption {
     fn description(&self) -> DescriptionValue {
         self.description.to_string() as DescriptionValue
     }
 
-    fn assumption_fn(&self) -> EvalFn {
-        self.assumption_fn
-    }
-
     fn assumption_tested(&self) -> bool {
         *self.assumption_tested.read().unwrap()
     }

deep_causality/src/utils_test/test_utils.rs

@@ -200,7 +200,7 @@ pub fn get_test_assumption() -> Assumption {
 }
 
 fn test_has_data(data: &[PropagatingEffect]) -> Result<bool, AssumptionError> {
-    Ok(!data.is_empty())
+    Ok(!data.is_empty()) // Data is NOT empty i.e. true when it is 
 }
 
 pub fn get_test_num_array() -> [NumericalValue; 10] {

deep_causality/tests/types/model_types/assumption/assumption_tests.rs

@@ -27,7 +27,7 @@ fn test_assumption_tested() {
 }
 
 #[test]
-fn test_verify_assumption() {
+fn test_verify_assumption_success() {
     let assumption = test_utils::get_test_assumption();
 
     let tested = assumption.assumption_tested();
@@ -40,7 +40,14 @@ fn test_verify_assumption() {
         .iter()
         .map(|&x| PropagatingEffect::Numerical(x))
         .collect();
-    let valid = assumption.verify_assumption(&data).unwrap();
+
+    let res = assumption.verify_assumption(&data);
+    assert!(res.is_ok());
+
+    let tested = assumption.assumption_tested();
+    assert!(tested);
+
+    let valid = assumption.assumption_valid();
     assert!(valid);
 }
 
@@ -58,8 +65,9 @@ fn test_assumption_valid() {
         .iter()
         .map(|&x| PropagatingEffect::Numerical(x))
         .collect();
-    let valid = assumption.verify_assumption(&data).unwrap();
-    assert!(valid);
+
+    let res = assumption.verify_assumption(&data);
+    assert!(res.is_ok());
 
     let tested = assumption.assumption_tested();
     assert!(tested);
@@ -68,6 +76,29 @@ fn test_assumption_valid() {
     assert!(valid);
 }
 
+#[test]
+fn test_verify_assumption_invalid() {
+    let assumption = test_utils::get_test_assumption();
+
+    let tested = assumption.assumption_tested();
+    assert!(!tested);
+
+    let valid = assumption.assumption_valid();
+    assert!(!valid);
+
+    // Should eval to false b/c data empty
+    let res = assumption.verify_assumption(&[]);
+    assert!(res.is_ok());
+
+    // has been tested now.
+    let tested = assumption.assumption_tested();
+    assert!(tested);
+
+    // it is not valid
+    let valid = assumption.assumption_valid();
+    assert!(!valid);
+}
+
 #[test]
 fn test_assumption_id() {
     let id = 1;