addressed suggestions to PR #6

Author: TejasMorbagal

deep_code/tests/utils/test_ogc_api_record.py

@@ -137,7 +137,7 @@ def test_record_properties_to_dict(self):
 class TestLinksBuilder(unittest.TestCase):
     def test_build_theme_links_for_records(self):
         links_builder = LinksBuilder(themes=["climate", "ocean"])
-        theme_links = links_builder.build_them_links_for_records()
+        theme_links = links_builder.build_theme_links_for_records()
 
         expected_links = [
             {

deep_code/tools/publish.py

@@ -100,7 +100,6 @@ def publish_files(
 
 class Publisher:
     """Publishes products (datasets) to the OSC GitHub repository.
-    Inherits from BasePublisher for GitHub publishing logic.
     """
 
     def __init__(self, dataset_config_path: str, workflow_config_path: str):
@@ -317,7 +316,7 @@ def publish_workflow_experiment(self, write_to_file: bool = False):
         exp_record_properties = copy.deepcopy(wf_record_properties)
 
         link_builder = LinksBuilder(osc_themes)
-        theme_links = link_builder.build_them_links_for_records()
+        theme_links = link_builder.build_theme_links_for_records()
 
         workflow_record = WorkflowAsOgcRecord(
             id=workflow_id,

deep_code/utils/ogc_api_record.py

@@ -82,7 +82,7 @@ def to_dict(self, value_name: str | None = None) -> dict[str, JsonValue]:
         data = super().to_dict(value_name)
         if self.osc_workflow is not None:
             data["osc:workflow"] = self.osc_workflow
-            del data["osc_workflow"]  # Remove the original key as it be renamed it
+            del data["osc_workflow"]  # Remove the original key as it has been renamed
         if self.osc_project is not None:
             data["osc:project"] = self.osc_project
             del data["osc_project"]
@@ -94,13 +94,9 @@ def __init__(self, themes: list[str]):
         self.themes = themes
         self.theme_links = []
 
-    @staticmethod
-    def format_string(s):
-        return s.capitalize()
-
-    def build_them_links_for_records(self):
+    def build_theme_links_for_records(self):
         for theme in self.themes:
-            formatted_theme = self.format_string(theme)
+            formatted_theme = theme.capitalize()
             link = {
                 "rel": "related",
                 "href": f"../../themes/{theme}/catalog.json",