Skip to content

Commit 366b6ca

Browse files
authored
fix: Add semi-required "webhook-type" to slack actions (#6573)
Our slack actions appear all to be workflows, assigned the webhook-trigger accordingly. Also added build summary URLs for nightly check and publish. Follow-up #6384
1 parent 475128a commit 366b6ca

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

.github/workflows/create-docs-issues.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ jobs:
3232
env:
3333
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL_DEVREL }}
3434
with:
35+
webhook-type: webhook-trigger
3536
payload: |
3637
{
3738
"repository": "${{ github.repository }}",

.github/workflows/nightly-check-ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,10 @@ jobs:
104104
id: slack-nightly-failure
105105
if: ${{ failure() && github.repository_owner == 'deephaven' && github.ref == 'refs/heads/main' }}
106106
with:
107+
webhook-type: webhook-trigger
107108
payload: |
108109
{
109-
"slack_message": "Nightly build failure in ${{ matrix.gradle-task }} on Java ${{ matrix.test-jvm-version }} @ ${{ github.head_ref }} ${{ github.sha }}"
110+
"slack_message": "Nightly build failure in ${{ matrix.gradle-task }} on Java ${{ matrix.test-jvm-version }} @ ${{ github.head_ref }} ${{ github.sha }}" ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
110111
}
111112
env:
112113
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_NIGHTLY_FAILURE }}

.github/workflows/nightly-image-check.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,5 @@ jobs:
4141
env:
4242
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL_DHC_NOTIFY }}
4343
with:
44+
webhook-type: webhook-trigger
4445
payload: '{"repository": "${{ github.repository }}", "message": "${{ github.workflow }}/${{ github.job }} failure, some image is out of date", "link": "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}'

.github/workflows/nightly-publish-ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,10 @@ jobs:
5959
id: slack-nightly-failure
6060
if: failure()
6161
with:
62+
webhook-type: webhook-trigger
6263
payload: |
6364
{
64-
"slack_message": "Nightly publish failure @ ${{ github.head_ref }} ${{ github.sha }}"
65+
"slack_message": "Nightly publish failure @ ${{ github.head_ref }} ${{ github.sha }} ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
6566
}
6667
env:
6768
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_NIGHTLY_FAILURE }}

0 commit comments

Comments
 (0)